Re: [TiLP-devel] Gentoo stuff

[Julien B. <jb...@jb...>]

Brent Redeker <bre...@cc...> wrote:

Hi,

> It seems both patches were a result of one bug in Gentoo's Bugzilla. I
> think the keepdir patch is to fix problems with the Makefile
> attempting to modify stuff outside of the PREFIX that was set for
> it. And I think that the other patch was to fix some segfaults related
> to locale issues. There was also a problem related to compiling TiLP

It wasn't related to a locale issue, but some locales helped trigger
the bug, which was a basic coding mistake because someone forgot THAT
YOU MUST NEVER MODIFY A STRING RETURNED BY A GTK FUNCTION UNLESS THE
DOCUMENTATION EXPLICITLY TELLS THAT YOU CAN. And I bet there a couple
of other similar issues at some other places in TiLP, but I do not
have the time for a complete audit...

> against Gtk 2.4, which the Gentoo ebuild fixes with this line (which
> happens right before the ebuild runs the configure command):
> sed -e 's/GTK_DISABLE_DEPRECATED/GTK_DEPRECATED/g' -i src/Makefile.in

This is the wrong fix for this issue. I guess this does precisely the
contrary, ie it probably enables deprecated widgets, which is not what
we want. Better drop the -D entirely, or patch TiLP to not use the
deprecated widget, but TiLP may not build with GTK 2.2 after that.

Without a build log, I can't say much more.

> *tilp-6.68-r2 (13 Apr 2004)
>
>    13 Apr 2004; Patrick Kursawe <pho...@ge...>
>    tilp-6.68-r1.ebuild,
>    tilp-6.68-r2.ebuild, files/formatbug.patch:
>    Traced bug #40263 to a buffer overflow, provided patch.

I fixed this bug (in labels.c) ages ago already. It took me two hours
to track it down. Moreover, the Gentoo patch is simply completely
wrong and doesn't do the right thing. Trash it, the author of this
patch didn't bother enough to dig into the code and understand where
the bug came from, and why it was a bug in the first place.

> *tilp-6.68-r1 (29 Mar 2004)
>
>    29 Mar 2004; Patrick Kursawe <pho...@ge...>
>    tilp-6.68-r1.ebuild,
>    files/6.68-keepdir.patch:
>    Some changes because of bug #40263

What's this ".keep" directory that is special-cased in the patch ?
This patch seems bogus to me.

JB.

-- 
Julien BLACHE                                   <http://www.jblache.org> 
<jb...@jb...>                                  GPG KeyID 0xF5D65169