Re: [TiLP-devel] TiLP ported to FreeBSD

[Julien B. <jb...@jb...>]

Tijl Coosemans <ti...@ul...> wrote:

> Hello to all TiLP developers,

Hi Tilj,

>   Today I finished porting TiLP to FreeBSD. A set of patches for each
> package is available at http://tijl.studentenweb.org/tilp/

Good news :)

>   Currently I only have the Grey TIGL working. I might take a look at
> the others when I finish my exams at the end of January.

It shouldn't be too problematic to enable support for the other
cables. You'll need to figure out the low-level access routines, and
that's it :)

For the USB cable, you'll need the libusb which is ported to FreeBSD
already.

For the parallel cable, maybe we could use the libieee1284, although
I'm not sure it would cover our needs.

> ** General
>
>   FreeBSD currently doesn't have <stdint.h>. I believe the upcoming 5.0
> will support it though. To overcome this I encapsulated each #include
> <stdint.h> with:

Argh too bad :/ stdint.h is part of ISO C99...

>   I also added LIBS="$LIBS $INTLLIBS" in every ./configure. With this

This should already be done, if it isn't then it's a bug.

>   Next I noticed the ti*-config scripts had a bug when the --cflags
> option was given. They returned the dir without the -I prefix.

Needs to be fixed.

> ** libticables 3.5.3
>
>   I added a few lines to ./configure to define __FBSD__. These should be
> added to configure.ac though. I didn't because then I prevented
> using autoconf/automake/... during compilation. I wonder why you don't
> use any gcc predefined constants though. I believe either unix or
> __unix__ is defined on every unix platform. This is what I get on a
> FreeBSD box.

We don't want to rely on GCC specific features, so that TiLP can be
built easily on other platforms using other compilers (eg Tru64 with
Compaq's CC -- which is crap, for what matters :)).

> ** libtifiles 0.4.0
>
>   No system specific patches were necessary. <stdint.h> is used quite a
> lot though.

We should have a specific header file defining our own types using
whatever is available on the system, preferably stdint.h, falling back
to inttypes.h or etc...

> ** libticalcs 4.2.8
>
>   In src/calc_def.h I replaced <glib-1.2/glib.h> with <glib.h>, since I

*dung*

/me applies a big LART to Romain

> believe the glib-1.2 part is system dependent and ./configure adds a
> proper -I(include) to CFLAGS anyway. The downside is that TiLP's
> configure script chokes when checking for <tilp/calc_def.h>, but this
> can be overcome by adding the proper -I(include) to CPPFLAGS.

configure needs to be fixed wrt this.

>   At the moment this is done automatically by a Makefile I made for
> TiLP's entry in the FreeBSD ports tree, but I can imagine it isn't so
> convenient when you have to run ./configure manually. Probably, some
> construction can be figured out, like adding a CPPFLAGS= line at the
> same place as LIBS= CFLAGS= lines currently in there somewhere.

The autoconf check for libticalcs needs to be fixed to include the
output of ticalc-config, or something like this.

>   Related to this, I could comment out a redefinition of
> HAVE_TILP_TICALCS_H in TiLP's src/tilibs.h.

This include file should GO AWAY AND BURN IN HELL, please Romain...

It's one of the reason why TiLP takes so long to build...

> ** tilp 6.00 pre15
>
>   On some lines in the configure script $(prefix) is used. This gave
> some problems so I replaced them by $prefix. Should there be any
> difference between these two?

${prefix} would be better, needs checking & fixing.

>   src/term_cb.c wants to include error.h, but there doesn't seem to be
> any.

IIRC it was missing in one of the tarballs.

>   That should be it. I hope this can be of help to somebody. I'm not
> submitting anything to the FreeBSD ports tree yet as I first want to
> check a few more things, maybe take a look at the usb lib/driver and
> that's all for after exams. At the moment I'm just happy to be able to
> connect to my calc!

We definitely need to find some motivation and go on a cleanup spree
in TiLP. And I need to go back to the TiLP for Mac OS X port...

Not speaking of TiEmu :) Oh, well...


My TODO list for TiLP would be :
 - use packageconfig instead of ticalc-config & friends (easy)
 - cleanup the #include mess (not too difficult)
 - double check the autoconf macros for libti* (not too difficult)

After that, we could go on with a GTK 2 port.

Thoughts ?

JB.

-- 
Julien BLACHE                                   <http://www.jblache.org> 
<jb...@jb...>