[TiLP-devel] [ tilp-Bugs-1874095 ] TiLP-6.76 compile fails

[SourceForge.net <no...@so...>]

Bugs item #1874095, was opened at 2008-01-17 15:45
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=118378&aid=1874095&group_id=18378

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Megan M (violagirl23)
Assigned to: Nobody/Anonymous (nobody)
Summary: TiLP-6.76 compile fails

Initial Comment:
In the package manager for Gentoo--Portage--TiLP2 is not officially available yet (though I'm trying to get it entered in), only in an overlay.  Thus only the original, now unsupported TiLP is available.  Thus that is what my question pertains to.  Version 6.76 is available as stable and 6.79 as unstable.  Both failed to compile initially, as did TiLP-1.07, but I managed to get all of them working except for 6.79 by following the idea behind this bug report:
http://sourceforge.net/tracker/index.php?func=detail&aid=1805122&group_id=18378&atid=118378
In the original TiLP, if I add the line #undef GTK_DISABLE_DEPRECATED above #include <gtk/gtk.h> in all the files that failed, it compiled fine.  This applied for 6.79 as well, but there was one additional problem, with the rom_dump function in tilp_calcs.c.  The compile fails with the following error:
tilp_calcs.c: In function ‘tilp_calc_rom_dump’:
tilp_calcs.c:307: error: ‘ROM_SE’ undeclared (first use in this function)
tilp_calcs.c:307: error: (Each undeclared identifier is reported only once
tilp_calcs.c:307: error: for each function it appears in.)

I looked at the source code for the file and compared it to your previous version in the portage tree, 6.76.  I changed part of your source code and got it to compile.
In tilp_calcs, around line 307, there is the following code:
[quote]		if (ret == BUTTON1)
                {
                        ret = gif->msg_box3(_("Question"), _("Is your calculator model a SilverEdition ?"), _("Yes"), _("No"), _("Cancel"));

			if(ret == 3)

 				return -1;

 			else

 				return do_rom_dump((ret == BUTTON1) ? ROM_SE : 0);

 		}

                else

			return -1;
         	break;[/quote]

I changed it to the following:

[quote]		if (ret == BUTTON1)

		{

			ret = gif->msg_box3(_("Question"), _("Is your calculator model a SilverEdition ?"), _("Yes"), _("No"), _("Cancel"));

			if(ret == 3)

				return -1;

			else

				if (ret == BUTTON1)
					return do_rom_dump(0);
		}

		else

			return -1;

		break;[/quote]

Is this acceptable or will it cause the rom_dump to break?  If so, is there a better patch I can offer the Gentoo Portage tree?  I want to patch the program so it will compile and submit the patch to the Gentoo developers.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=118378&aid=1874095&group_id=18378