Re: [Themis-dev] Newest cookie system changes

[Raymond C. R. <ra...@ba...>]

On 1/14/2011 4:12 PM, Mark Hellegers wrote:
>> On 1/13/2011 3:28 PM, Mark Hellegers wrote:
>>>> On 1/12/2011 3:42 PM, Mark Hellegers wrote:
>>>>> Ah, got it.
>>>>> I compile with a separate makefile that I don't want to commit and I
>>>>> forgot to copy your change over to my makefile.
>>>>> It is now compiling. I will give it a spin.
>>>>>
>>>>> Mark
>>>> Cool, how's it working out for you so far?
>>>> Raymond
>>> Hmm, no more crash on themis.sf.net, but I don't see any cookies
>> getting
>>> stored either.
>>> Is there a part of the debugging output I can check to see if a site
>> has a
>>> cookie?
>>>
>>> Mark
>> I found the problem. Just before I committed the code, I added a new
>> variable to the cookie_st structure to designate a cookie as a session
>> cookie instead of relying on the discard variable which is really meant
>> for the discard flag in the set-cookie header (which isn't used very much
>> if at all). I forgot to then default the discard variable to false from
>> the true that it had been set to. So, basically, all cookies were being
>> thrown out immediately. I made the change and it should be working
>> properly now. :-)
> Yes, it is working properly now. I visited some sites and on a few sites I
> now see that I get a cookie in the cookies directory.
> Very nice. Does themis.sf.net not have a cookie that gets stored? I
> thought the reason for the crash was that it had a cookie.
> Now you just need to fix the warnings.... ;)
>
> Mark
>
It (themis.sf.net) sets a session cookie which doesn't get saved to disk 
since the cookie is supposed to expire when the browser is closed. I'll 
clean up the output when I get a moment this weekend. :)

Raymond