Re: [Synce-devel] Patches and stuff

[David E. <tw...@us...>]

On Thu, 2003-08-14 at 12:37, Mattias Eriksson wrote:
> tor 2003-08-14 klockan 11.11 skrev David Eriksson:
> > First, please be aware that you are using the GPL but the other parts of
> > SynCE are MIT licensed.
> 
> OK, I'll change the licence then to MIT. Especially since I have done
> alot of copy/paste.

:-)

> > Anyway, this application is great! Just a minor issue: as you know,
> > GNOME 2 is not happy about non-ascii chars. This means that you should
> > use wstr_to_utf8 instead of wstr_to_ascii for things that will be
> > displayed to the user.
> 
> Thanks for catching this, I'll fix this.
> 
> > I saw that you had copied pcommon.[ch] from librapi2/tools - maybe that
> > code should be integrated in the librapi2 library to avoid maintaining
> > the same code in two locations?
> 
> Well, I just copied it to get started fast. But if I do the switch to
> using gnome-vfs (with the synce-module) I probably can remove this from
> my code. I think that gnome-vfs is the way to go.

Is gnome-vfs ready for this?

> > > trayicon.patch:
> > > Added sessionhandling, added menu entries to open synce:/// and the
> > > software manager. dccm does still have to be started manually, the
> > > trayicon should probably start it... but this has still to be done.
> > 
> > Please commit this yourself!
> 
> Ok, I'll do that later.
> 
> > > What is left to do:
> > 
> > Feel free to add this to TODO files in the modules!
> 
> OK, I will. But I however think it might be a good idea to post some
> status reports on the list from time to time, to make it easier for
> people to find tasks to do. It will help people start contributing. 

That is a very good idea! I'll start doing that too.

> > There are some partnership fixes in the GNOME 1 version of
> > multisync_plugin that I have not yet ported to the GNOME 2 version.
> 
> What are those fixes for?

Just before SynCE 0.8 I added two new functions in librra, and the GNOME
1 version of multisync_plugin uses the first function:

  bool rra_partner_create(RRA* rra, uint32_t* index);
  bool rra_partner_replace(RRA* rra, uint32_t index);

The rra_partner_create function attempts to either select a partnership
previously created with one of these two functions, or otherwise create
a partnership on an empty partnership slot. It returns the index (1 or
2) of the new partnership in the second parameter if either operation
succeeds.

The rra_partner_replace function replaces the partnership specified in
index (1 or 2) with a new partnership.

See rra/src/rra-partners.c for examples of how to use these functions
and rra/lib/librra.c for the implementation.

The partnerships created with this sytem are saved in
~/.synce/rra/partner-ID, where ID is the hexadecimal value of PId. The
file looks something like this:

  [device]
  name=test1
 
  [partnership]
  PCur=1
  PId=1536922017
  PName=zion.2good.net


\David