Menu

#215 rtfconvert.c: 2 * possible botch in sizeof ?

SVN Trunk
closed-fixed
None
5
2017-02-15
2016-10-25
dcb
No

rtfconvert.c:388]: (warning) Found calculation inside sizeof().

Source code is

   (maxlen >= sizeof(escape_header + 2))

Maybe better code

   (maxlen >= sizeof(escape_header) + 2)

Also:

rtfconvert.c:399]: (warning) Found calculation inside sizeof().

  (maxlen >= sizeof(unicode_header + 1))

Discussion

  • David Eriksson

    David Eriksson - 2016-10-25

    SynCE has no active developers to fix this. Do you want SVN access?

     
  • Arndt Kaiser

    Arndt Kaiser - 2017-02-09

    This bug was fixed by commit 4326.

    David, can you please close the ticket or grant me the right to manage tickets?

    Cheers, Arndt

     
  • David Eriksson

    David Eriksson - 2017-02-15
    • status: open --> pending
    • assigned_to: Arndt Kaiser
     
  • David Eriksson

    David Eriksson - 2017-02-15

    Can you close it now?

     
  • Arndt Kaiser

    Arndt Kaiser - 2017-02-15

    No, i still can't change the ticket.

     
  • David Eriksson

    David Eriksson - 2017-02-15

    Now?

     
  • Arndt Kaiser

    Arndt Kaiser - 2017-02-15
    • status: pending --> closed-fixed
     
  • Arndt Kaiser

    Arndt Kaiser - 2017-02-15

    Thanks David,
    I am able to change Bug-Tickets now and can close the Ticket!

    I think it makes sense to set the same permissions for the Patch-Tickets, if it is OK for you...

     

Log in to post a comment.