Re: [Swig-devel] SWIG svn comit access

[William S F. <ws...@fu...>]

gga wrote:
> William S Fulton wrote:
>> gga wrote:
>>> Hi, William.
>>>
>>> I'm doing a lot of work on SWIG with ruby and I have found a bunch of
>>> problems here and there in the current translator.
>>> I've already submitted a bunch of patches and I have others soon coming
>>> again.
>>> I was wondering if it was possible for me to get commit access to the
>>> repository for a little while to merge my changes.
>>>
>>>
>> Hi Gonzalo
>>
>> I've had a look at your patches. They look okay on the face of it. We
>> usually commit a runtime test when patching the source - Test Driven
>> Development. Are you familiar with the test-suite? That needs checking
>> after patching the source with the additional tests. Usually we just add
>> a new runtime test to one of the existing tests so as to not have too
>> many testcases, unless it is a new feature, in which case we add a new
>> testcase. It requires a little extra work, but I'd expect anyone with
>> svn commit access to work that way. How does that sound?
> 
> Sounds okay.  I currently do have some issues with running the test
> suite (unrelated to my patches -- happens with a fresh svn checkout too).
> 
> Currently, for example:
> 
> Examples/test-suite/constants.i
> Examples/test-suite/cpp_broken.i
> 
> spit out a syntax error on parsing.
> 
> and the namespace_union_wrap.cxx created contains uncompilable code.
> 
> (this happens in python and ruby)
> 
> Before adding any test of mine, I would like to get a test-suite that works.
> 
> 
>> Subversion access is usually given to those showing some sort of
>> commitment to SWIG, so if I got you access would you be able to take a
>> look at other Ruby patches and bugs? There are only 8 Ruby bugs at the
>> moment, 4 of which are yours!
>>
> 
> I can probably deal with most bugs related to ruby.cxx and its .swg
> files at this point.
> Some of the bugs I reported (like the reinterpret_cast issue, I'm not
> quite sure how to fix yet, as I am still not familiar enough with the
> parser or core).
> The other bugs not reported by me are easy to fix or, in one case,
> probably not a bug but something the user can work around.
> 
> 
Gonzalo,

Welcome to the swig developers community and thanks for picking up some
of the Ruby module maintenance.

The test-suite indeed has only a few broken tests at the moment. If the
test is broken in another language as well as Ruby, don't worry about
it. The two newobject tests need attention for Ruby though. The
test-suite works best with a recent gcc. You need to run the test-suite
from the top level directory using 'make check-ruby-test-suite'. If you
run just make in the test-suite directory then you get to run the known
broken tests as specified in common.mk. For a release there shouldn't be
any broken tests using the top level check targets.

William