Menu
▾
▴
[Swig-devel] [ swig-Feature Requests-1632599 ] Improve const-correctness
|
From: SourceForge.net <no...@so...> - 2007-01-16 13:45:12
|
Feature Requests item #1632599, was opened at 2007-01-10 19:05 Message generated for change (Comment added) made by elfring You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=351645&aid=1632599&group_id=1645 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Pending Priority: 5 Private: No Submitted By: Markus Elfring (elfring) >Assigned to: Olly Betts (olly) Summary: Improve const-correctness Initial Comment: Would you like to apply the advices from the article "http://en.wikipedia.org/wiki/Const-correctness" to more places in your sources? I suggest to add the key word "const" to the type specifiers for parameters like the following. - http://swig.svn.sourceforge.net/viewvc/swig/trunk/Source/CParse/parser.y?revision=9632&view=markup n (function "copy_node") name (functions "is_operator", "make_class_name") - http://swig.svn.sourceforge.net/viewvc/swig/trunk/Source/DOH/base.c?revision=9629&view=markup buffer (function "DohWrite") - http://swig.svn.sourceforge.net/viewvc/swig/trunk/Source/DOH/file.c?revision=9607&view=markup filename (function "DohFileErrorDisplay") - http://swig.svn.sourceforge.net/viewvc/swig/trunk/Source/DOH/string.c?revision=9631&view=markup so (function "CopyString") - all global variables: cvsroot_ ... How do you think about to make them also static (useable only in their own compilation unit)? ---------------------------------------------------------------------- >Comment By: Markus Elfring (elfring) Date: 2007-01-16 14:45 Message: Logged In: YES user_id=572001 Originator: YES I would like to be sure that my suggestion fits to the intended API design. How do you think about it? ---------------------------------------------------------------------- Comment By: Olly Betts (olly) Date: 2007-01-14 13:31 Message: Logged In: YES user_id=14972 Originator: NO If you want to propose changes to the source code, please supply patches rather than attempting to describe the changes in English. This makes it much easier for use to understand and apply your changes. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=351645&aid=1632599&group_id=1645 |