From: William S F. <ws...@fu...> - 2013-08-31 07:50:24
|
On 29/08/13 07:25, William S Fulton wrote: > On 26/08/13 16:51, Simon Marchetto wrote: >> William, >> >> As you said, Scilab builds look better on Travis. >> >> Yes, there is still a potential timeout issue on the test suite (i will >> find a way to fix this) but the most important is the code, isn't it ? > Future maintenance is way more important than a dump of code. I feel > strongly about this given the number of unmaintainable aspects of SWIG > and the disappearance of language maintainers over time. I feel that > having a passing regression test-suite is a necessary requisite for > attempting any modification of the SWIG internals. > > I'll try see why parallel make solution for the timeout issue does not > work for Scilab when I review, if you havn't worked it out sooner. Why in Examples/test-suite/scilab do you pipe 'exit(1)' into scilab like this: env LD_LIBRARY_PATH=.:$$LD_LIBRARY_PATH $(RUNTOOL) echo 'exit(1)' |$(SCILAB) -nwni -nb -f $(srcdir)/ I ran without this piping and it worked okay. Could you briefly explain the conf cache used in the test-suite? > >> Did you have a look on our code, do you validate it ? Do you think we >> can merge soon in master ? > Thanks for your efforts to get it to the current state to work on > Travis. I'll do the review next. I have been doing this and have just committed a bunch of changes. Other comments to follow... > >> What else does it need for that ? Does documentation have to be written >> first, etc.. ? > A reasonable level of documentation is needed. Consider you are a first > time user. If the documentation isn't good enough to successfully wrap a > project for Scilab, then it isn't worth having Scilab as a SWIG target. > Normally this doesn't require much documentation effort as there isn't > that much that is language dependent. I havn't looked at the docs for > Scilab yet, but will do during the review. The docs are need something on handling C++. Can you add that in? Minimum version required needs documenting. What is the real minimum version? I tried 5.2 which configure accepts and the first example failed. Do you expect 5.2 to work? As you may have noticed in my previous email to the list, I'd like to target Scilab inclusion for swig-3.0.0. William |