From: SourceForge.net <no...@so...> - 2011-09-14 18:08:13
|
Patches item #3394784, was opened at 2011-08-19 21:34 Message generated for change (Comment added) made by talby You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=301645&aid=3394784&group_id=1645 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: general Group: None >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: Torsten Landschoff (torsten) >Assigned to: Robert Stone (talby) Summary: Patch for bug 1481958 Initial Comment: Seems I can not attach files to the bug tracker, so I am adding it here. The attached patch was originally authored by Chris Butler to solve the Debian bug at http://bugs.debian.org/579450 I added a unit test to cover the change and checked that the test suite for perl5 still passes on i386 and amd64. I will include this patch in the next Debian upload and hope that it can be merged upstream as well. ---------------------------------------------------------------------- >Comment By: Robert Stone (talby) Date: 2011-09-14 18:08 Message: Yes, in my test environment, the fix for 1481958 also caused the testcase in this patch to succeed. I used this patch as a starting point, but found a family of related problems. I did not include the new testcase, but rolled it's functionality into the li_typemaps_runtime.pl test. ---------------------------------------------------------------------- Comment By: William Fulton (wsfulton) Date: 2011-09-13 18:31 Message: talby, does your commit fixing 1481958 also fix this one / replace this patch? Or torsten can you confirm 1481958 makes this patch redundant? ---------------------------------------------------------------------- Comment By: Robert Stone (talby) Date: 2011-09-10 18:11 Message: There are definitely problems in this area of the code (even in a 32 bit build), however the proposed patch does not address all of them. I am working on expanding the li_typemaps testcase to capture all the issues, and should have a comprehensive fix ready soon. ---------------------------------------------------------------------- Comment By: szager (szager) Date: 2011-09-07 17:34 Message: I'm not sure whether there's an active perl maintainer for SWIG right now; that may explain the delay. I'll reiterate my previous comment here: - Should remove the redundant 'v >= 0' check when v is of type UV. For what it's worth, I would approve the patch. Stefan ---------------------------------------------------------------------- Comment By: Torsten Landschoff (torsten) Date: 2011-09-06 22:38 Message: Is there anything I can do to support acceptance of this patch? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=301645&aid=3394784&group_id=1645 |