From: William S F. <ws...@fu...> - 2009-12-22 20:01:34
|
Olly Betts wrote: > Well, the name "output_helper" is used by several other backends, so I > think > it wouldn't be good to change it just for PHP. I think whether this > should > be changed globally is probably William's call. > > But "output_helper" seems to describe what it is *for* quite well, whereas > "t_maybe_add_to_array" just describes what it *does*. So this seems to be > an issue of naming philosophy... According to rubytypemaps.swg and pytypemaps.swg output_helper is for backwards compatibility. I don't know this function, but whatever replaced it must be in the svn history. > I'm not sure what stage William's UTL replacement plan (which I > understand will > encompass non-UTL languages too) is at, or how that would affect this > though. > If this ends up being redundant in the near future, it seems a bit > pointless to > make changes like this and have to deal with any fall-out. At this point in time, I'm not going to make any UTL improvements, so please make plans in accordance with what we currently have. William |