[studs-user] html:link href="..." title="..." target="..."

[Earnie B. <ea...@us...>]

Reviewing the Struts Framework documentation I see that ``target'' is a 
valid attribute of html:link but it doesn't appear to be fully 
implemented in 
studs.taglib.html.BaseInteractiveTag.renderMetaAttributes.  I do find 
the variable ``target'' is defined in the studs.taglib.html.HtmlLinkTag 
extended class.

I'm thinking that the correct change to implement the target attribute 
is the following change.  I'm looking for opinions on this change.

<diff file="studs/taglib/html/BaseInteractiveTag.php">
@@ -126,6 +126,11 @@
                        $meta .= ' title="' . $this->title . '"';
                }

+               if (isset($this->target) && !is_null($this->target))
+               {
+                       $meta .= ' target="' . $this->target . '"';
+               }
+
                // NOTE: perhaps image tag should have an 
HtmlBaseImageTag parent?
                if (!is_null($this->alt) && (is_a($this, 
'HtmlImageTag') || is_a($this, 'HtmlImgTag')))
                {
</diff>


Earnie Boyd

http://shop.siebunlimited.com