Re: [studs-user] isCancelled() in GolfLog demo webapp

[<joh...@on...>]

Dan Allen wrote:

>On 7/25/05, Johan Mjönes <joh...@on...> wrote:
>  
>
>>While trying out Studs using the example web application (GolfLog) I
>>noticed that I was unable to add players using the interface (with no
>>warning or error presented).
>>
>>While trying to locate the issue, I noticed that in
>>EditPlayerSubmitAction.php, in the execute() method,
>>$this->isCancelled() seems to return true, even though the form was not
>>cancelled.
>>
>>I'm new to both Struts and Studs, so I might be missing something, but
>>is this an error in Studs (or GolfLog) or am I simply missing something?
>>
>>Best Regards,
>>
>>Johan Mjones
>>    
>>
>
>Johan,
>
>I did some research into the issue and I actually found a couple of
>bugs.  When I went to the non-index.php version of the paths (using
>mod_rewrite), it screwed up the handling of the session cookie path. 
>I was able to put in a nice resolution for that.  
>
Great! We like nice resolutions :D

>I also realized that
>checks for a valid token were not working since the session had not
>been started, so I also fixed that problem. 
>
Yes. Actually, after I sent the email, I continued my own investigation, 
and noticed that isCancelled() actually was set to false, but as you 
said, is was in fact isValidToken() that failed because of the failed 
session. The strange thing (for me) was that the session was actually 
started (or at least - a PHPSESSID cookie was set for the correct URL 
and sent to web server on each request). I didn't get any further since 
dinner with my girlfriend was on the schedule (and just when things 
started to get exciting ;).

> Finally, it appears that
>the web server on sourceforge where golflog is hosted has some serious
>file read problems, so the session data gets dropped randomly (I don't
>experience this on any of my other test servers).  So I went ahead and
>disabled the check for a valid form token in the demo, but it should
>work in the next version of the golflog package (0.9.8).
>
>All of this will be fixed in 0.9.8 and available in CVS shortly.
>
>  
>
Excellent! Actually, I think I'll just take they time to appreciate what 
you are doing. I've been evaluating Studs and Mojavi, and right now 
Studs is obviously the right choice. It's more similar to Struts (which 
I like) and a lot more active. Mojavi has been in 3.0 development (and 
therefore, awaiting PHP5 compliance) for over 8 months. Anyway - keep up 
the excellent work!

Best Regards,

Johan

-- 
Johan Mjönes
Programmer
Phone: +46 8 789 12 00
Fax: +46 8 789 12 12
Cell: +46 7 052 838 55
E-mail: joh...@on...
Internet: www.ongame.com


This e-mail (including attachments) is strictly confidential and intended solely for designated recipient(s). It contains privileged and confidential information. If you have received this e-mail in error, you must not disseminate, copy, distribute or take any action in reliance on it. Please notify us immediately and delete this e-mail and any attachments. Thank you.