[Stp-devel] [PATCH] lib/STP/Client/TestRequest.pm - check new return value (3/5)

[Leann O. <oga...@os...>]

Hi All,

Fixing up two places that were checking a return value of -1 from
getConfigParam().  Thanks,

Leann

# 
# patch "lib/STP/Client/TestRequest.pm"
#  from [29c4dc632020018c292477333a9a8929b5327d40]
#    to [984b83d843dc93fe9d2edc220479c6cf01c00aa8]
# 
--- lib/STP/Client/TestRequest.pm
+++ lib/STP/Client/TestRequest.pm
@@ -118,9 +118,9 @@
     $self->{ 'local_state' } =
       $self->{ 'config' }->getConfigParam( "use_local_state" );
 
-    $self->{ 'admin_email' } =
-      $self->{ 'config' }->getConfigParam( "admin_email" );
-    if ( $self->{ 'admin_email' } eq '-1' ) {
+    unless ( $self->{ 'admin_email' } =
+             $self->{ 'config' }->getConfigParam( "admin_email" ) )
+    {
         print STDERR "failed to get admin_email value from config $!";
         console_note "failed to get admin_email value from config $!";
         if ( DEBUG ) {
@@ -140,11 +140,10 @@
     }
     $self->{ 'hostname' } = $hostname;
 
+    # Sanity check to see if network is working.
     $self->{ 'net_health' } =
       $self->{ 'config' }->getConfigParam( "net_health_check" );
-
-    # Sanity check to see if network is working.
-    unless ( $self->{ 'net_health' } eq -1 ) {
+    if ( $self->{ 'net_health' } ) {
         my $res = eval( system( $self->{ 'net_health' } ) );
         unless ( $res eq 0 ) {
             print STDERR "Network problem, exiting $!";