[Stp-devel] Re: patch II

SourceForge Headquarters 225 Broadway Suite 1600 San Diego, CA 92101 +1 (858) 454-5900

Minor edits.

On Tue, May 20, 2003 at 04:26:48PM -0700, Cliff White wrote:
> 
> corrected per yer mail
> ----------------------
> 
> diff -Natur a/Audit.txt b/Audit.txt
> --- a/Audit.txt	Tue May 20 16:21:29 2003
> +++ b/Audit.txt	Tue May 20 16:25:02 2003
> @@ -28,7 +28,7 @@
>       - Does it output a valid failure explanation to $RESULT_EMAIL?
>       - Does it properly kill the test and wrap.sh processes?
>  
> -2. Test Variables (This is ona "if this information is needed, does the test

ona?

> +2. Test Variables (This is only "if this information is needed, does the test
>                     get it from 'x'" basis)
>    a. Get number of processors in machine from $CPU_COUNT
>    b. Get the disk configuration from $DISK_INFO
> @@ -62,11 +62,11 @@
>  
>  
>  6. index.html (for valid or invalid results)
> +        - we now supply a RESULT_HEADER and RESULT_FOOTER which
> +          includes machine configuration and test id information. 

include

> +
>    a. Does the index.html include the content from $RESULT_HEADER?
> -  b. Does the $RESULT_HEADER handle the index.html <head>..<body> section?
> -     - The test does have the option of overriding this.  If so, the 
> -       $RESULT_HEADER file still must be used for the links section.  See the
> -       API file for details.
> +  b. Does the index.html file include the content from $RESULT_FOOTER? 
>    c. Does it create a valid index.html on test execution failure?
>    d. Does it create a valid $RESULT_EMAIL on test execution failure?
>    e. Does it create a valid $RESULT_EMAIL on test success? (summary info only!)
> diff -Natur a/stp_include.sh b/stp_include.sh
> --- a/stp_include.sh	Tue May 20 16:06:35 2003
> +++ b/stp_include.sh	Tue May 20 16:22:31 2003
> @@ -116,6 +116,7 @@
>  # Handle the HTML result template
>  #
>  export RESULT_HEADER="/tmp/STP-result_header.html"
> +export RESULT_FOOTER="/tmp/STP-result_footer.html"
>  
>  cat << EOF > $RESULT_HEADER
>  <html><head>
> @@ -124,9 +125,13 @@
>  <body>
>  <h1>Results for $TEST_NAME</h1>
>  <h2>Request ID: $TEST_ID ran on $PATCH_NAME [PLM: $PATCH_ID]</h2>
> +<p><a href=\"environment/machine_info\">Machine Configuration Summary</a>
>  <p>
> +EOF
> +
> +cat << EOF > $RESULT_FOOTER
> +<br>
>  <ul>Informative Links:
> -<li> <a href=\"environment/machine_info\">Machine Configuration Summary</a>
>  <li> <a href=\"COPYING\">Results License</a>
>  <li> <a href=\"environment/\">Environment Documentation</a>
>  <li> <a href=\"profile/\">Profile Report</a> (if available)

I thought you wanted the profile data at the top?

Either way, go ahead and commit instead of resending.

Thanks,
Nathan