Menu
▾
▴
springide-eclip-developer
You can subscribe to this list here.
| 2004 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
(21) |
Oct
(41) |
Nov
(18) |
Dec
(7) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2005 |
Jan
|
Feb
|
Mar
(15) |
Apr
(17) |
May
(2) |
Jun
(6) |
Jul
(13) |
Aug
(4) |
Sep
|
Oct
|
Nov
|
Dec
(3) |
| 2006 |
Jan
(3) |
Feb
|
Mar
(1) |
Apr
(4) |
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
| 2009 |
Jan
|
Feb
(2) |
Mar
|
Apr
(1) |
May
(1) |
Jun
|
Jul
(1) |
Aug
|
Sep
|
Oct
|
Nov
|
Dec
(1) |
| 2013 |
Jan
|
Feb
|
Mar
|
Apr
(1) |
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
| 2014 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
(1) |
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
| 2018 |
Jan
|
Feb
(1) |
Mar
|
Apr
|
May
(1) |
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
| 2022 |
Jan
|
Feb
(1) |
Mar
|
Apr
|
May
(1) |
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
| 2023 |
Jan
|
Feb
|
Mar
|
Apr
(1) |
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
|
From: <tor...@t-...> - 2004-09-21 18:59:53
|
We are asked for the new release of Spring IDE in the support forum: http://forum.springframework.org/viewtopic.php? t=96&sid=32ef6a7d04e8dff59946f85c25a8b755 I will create an update site release of the new version today and upload it to the website of our project on SF. Maybe you can give it a try. What do you think about shipping the new version end of this month? Cheers, Torsten |
|
From: Loren R. <lo...@gm...> - 2004-09-21 01:21:15
|
A bunch of comments: 1. It should be possible to support both Eclipse 2 and 3, but it's likely to be a lot of work, work that could instead go into developing new features. 2. The folks who wrote the "Building Commercial-Quality Eclipse Plugins" book were faced with supporting Eclipse 2 and 3 for their plugins, and utlimately decided to use a pre-processor. See http://www.qualityeclipse.com/?page=ant/tools/content.html and also their presentation at EclipseCon http://www.eclipsecon.org/EclipseCon_2004_TechnicalTrackPresentations/19_Clayberg_Rubel.pdf 3. I've run the code through the debugger, and I don't see where NatureTests should run into asynchronous problems. All the changes to the model appear to happen on the main thread. 4. I'm looking into why the wait for autobuild isn't sufficient to prevent unpredictable results for the validation tests On Sun, 19 Sep 2004 17:01:09 +0200, Torsten Juergeleit <tor...@t-...> wrote: > I'm up and running with Loren's tests too. Nice stuff. > > Yes, it seems we have issues with asynchronous modifications from > within different threads. One thread is the model's > ResourceChangeListener which updates the model on resource > modifications and another thread is the Eclipse UI thread with Spring > IDE UI's write access to the model [configuration dialogs -> > BeanProject.setConfigs()]. > > We have to make the bean model thread safe by introducing some locking > mechanism and batch operations as the Java model does. Modifications to > the beans model could leverage Eclipse 3.0's new job scheduling API > [JobManager.newLock()]. > > Additionally I ran into problems with the validator running while the > workspace tree is locked (used to re-validate on changes of bean > classes in the Java model). In this state the workspace (which supports > multiple concurrent readers but only one concurrent writers) does not > allow modifications, e.g. manipulation of problem markers. So I have to > introduce batched validations which are running after the workspace > tree is unlocked again. This is done most easily with the job API too. > > But this means we have to drop support for Eclipse 2.x!!! We will have > a lot of complains from Eclipse 2.x or WSAD users. > > What do you think? > > I have updated the CVS head of Spring IDE with the following new > features: > > - IBeansProject has a new method "Collection getConfigs(String > className)" to retrieve all IBeanConfig instances which are using the > specified bean class -> required for re-validation of IBeanConfigs > after modifications of bean classes in the Java model (JIRA issue > #IDE-21) > > - UI's editor context menu actions (open type and show in view) have an > action set and commands with configurable keybindings (JIRA issue > #IDE-4) > > Cheers, > Torsten > > > On 17.09.2004, at 23:48, Loren Rosen wrote: > > > I have occasionally seen intermitant assertion failures, though not in > > that particular place. I agree that something asychronous is a likely > > culprit. > > > > A few lines above the failing assertion, you'll see that the thread > > waits for the autobuild to complete (autobuilding apparently runs > > asynchronously on another thread). Perhaps there's yet another thread > > doing work here that we don't know about. > > > > It's of course not a solution, but it would be instructive to put the > > test thread asleep for several seconds just before this assertion. > > > > One thing I'll do over the weekend or on Monday is see if I can get > > the debugger to tell me what threads are running, or maybe put some > > breakpoints in the bean model code and see it's being modified > > asynchronously. > > > > > > On Fri, 17 Sep 2004 17:58:50 +0100, Watkins, David > > <dav...@fa...> wrote: > >> Loren, > >> > >> Just checked out the new project and am up and testing! > >> > >> However it is behaving a little strangely - Most of the time > >> everything > >> works and I get the green bar, but sometimes (<10%) I get a red bar > >> (always with the same trace) > >> > >> junit.framework.AssertionFailedError > >> at junit.framework.Assert.fail(Assert.java:47) > >> at junit.framework.Assert.assertTrue(Assert.java:20) > >> at junit.framework.Assert.assertTrue(Assert.java:27) > >> at > >> org.springframework.ide.test.NatureTests.testNatureAddAndRemove(Nature > >> Te > >> sts.java:70) > >> ....[snip].... > >> > >> Not 100% sure whats going on, I'm guessing that sometimes the model > >> is > >> not being updated with the project before that line of code runs. > >> This > >> would tally with some of the things I've seen with the refactoring > >> stuff > >> I've been working on.... > >> > >> Cheers, > >> dw > >> > >> > >> > >> > >>> -----Original Message----- > >>> From: spr...@li... > >>> [mailto:spr...@li...] > >>> On Behalf Of Loren Rosen > >>> Sent: 17 September 2004 17:34 > >>> To: spr...@li... > >>> Subject: [Springide-eclip-developer] test package checked in > >>> > >>> I've checked in the beginnings of the test package, as a > >>> separate CVS module. (Problem earlier was I was somehow using > >>> the pserver protocol to talk to sourceforge instead of extssh.) > >>> > >>> > >>> ------------------------------------------------------- > >>> This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one > >>> of 170 Project Admins to receive an Apple iPod Mini FREE for > >>> your judgement on who ports your project to Linux PPC the > >>> best. Sponsored by IBM. > >>> Deadline: Sept. 24. Go here: http://sf.net/ppc_contest.php > >>> _______________________________________________ > >>> Springide-eclip-developer mailing list > >>> Spr...@li... > >>> https://lists.sourceforge.net/lists/listinfo/springide-eclip- > >>> developer > >>> > >> > >> ------------------------------------------------------- > >> This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170 > >> Project Admins to receive an Apple iPod Mini FREE for your judgement > >> on > >> who ports your project to Linux PPC the best. Sponsored by IBM. > >> Deadline: Sept. 24. Go here: http://sf.net/ppc_contest.php > >> _______________________________________________ > >> Springide-eclip-developer mailing list > >> Spr...@li... > >> https://lists.sourceforge.net/lists/listinfo/springide-eclip-developer > >> > > > > > > ------------------------------------------------------- > > > > This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170 > > Project Admins to receive an Apple iPod Mini FREE for your judgement on > > who ports your project to Linux PPC the best. Sponsored by IBM. > > Deadline: Sept. 24. Go here: http://sf.net/ppc_contest.php > > _______________________________________________ > > Springide-eclip-developer mailing list > > Spr...@li... > > https://lists.sourceforge.net/lists/listinfo/springide-eclip-developer > > > > ------------------------------------------------------- > This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170 > Project Admins to receive an Apple iPod Mini FREE for your judgement on > who ports your project to Linux PPC the best. Sponsored by IBM. > Deadline: Sept. 24. Go here: http://sf.net/ppc_contest.php > _______________________________________________ > Springide-eclip-developer mailing list > Spr...@li... > https://lists.sourceforge.net/lists/listinfo/springide-eclip-developer > |
|
From: <tor...@t-...> - 2004-09-19 15:01:09
|
I'm up and running with Loren's tests too. Nice stuff. Yes, it seems we have issues with asynchronous modifications from within different threads. One thread is the model's ResourceChangeListener which updates the model on resource modifications and another thread is the Eclipse UI thread with Spring IDE UI's write access to the model [configuration dialogs -> BeanProject.setConfigs()]. We have to make the bean model thread safe by introducing some locking mechanism and batch operations as the Java model does. Modifications to the beans model could leverage Eclipse 3.0's new job scheduling API [JobManager.newLock()]. Additionally I ran into problems with the validator running while the workspace tree is locked (used to re-validate on changes of bean classes in the Java model). In this state the workspace (which supports multiple concurrent readers but only one concurrent writers) does not allow modifications, e.g. manipulation of problem markers. So I have to introduce batched validations which are running after the workspace tree is unlocked again. This is done most easily with the job API too. But this means we have to drop support for Eclipse 2.x!!! We will have a lot of complains from Eclipse 2.x or WSAD users. What do you think? I have updated the CVS head of Spring IDE with the following new features: - IBeansProject has a new method "Collection getConfigs(String className)" to retrieve all IBeanConfig instances which are using the specified bean class -> required for re-validation of IBeanConfigs after modifications of bean classes in the Java model (JIRA issue #IDE-21) - UI's editor context menu actions (open type and show in view) have an action set and commands with configurable keybindings (JIRA issue #IDE-4) Cheers, Torsten On 17.09.2004, at 23:48, Loren Rosen wrote: > I have occasionally seen intermitant assertion failures, though not in > that particular place. I agree that something asychronous is a likely > culprit. > > A few lines above the failing assertion, you'll see that the thread > waits for the autobuild to complete (autobuilding apparently runs > asynchronously on another thread). Perhaps there's yet another thread > doing work here that we don't know about. > > It's of course not a solution, but it would be instructive to put the > test thread asleep for several seconds just before this assertion. > > One thing I'll do over the weekend or on Monday is see if I can get > the debugger to tell me what threads are running, or maybe put some > breakpoints in the bean model code and see it's being modified > asynchronously. > > > On Fri, 17 Sep 2004 17:58:50 +0100, Watkins, David > <dav...@fa...> wrote: >> Loren, >> >> Just checked out the new project and am up and testing! >> >> However it is behaving a little strangely - Most of the time >> everything >> works and I get the green bar, but sometimes (<10%) I get a red bar >> (always with the same trace) >> >> junit.framework.AssertionFailedError >> at junit.framework.Assert.fail(Assert.java:47) >> at junit.framework.Assert.assertTrue(Assert.java:20) >> at junit.framework.Assert.assertTrue(Assert.java:27) >> at >> org.springframework.ide.test.NatureTests.testNatureAddAndRemove(Nature >> Te >> sts.java:70) >> ....[snip].... >> >> Not 100% sure whats going on, I'm guessing that sometimes the model >> is >> not being updated with the project before that line of code runs. >> This >> would tally with some of the things I've seen with the refactoring >> stuff >> I've been working on.... >> >> Cheers, >> dw >> >> >> >> >>> -----Original Message----- >>> From: spr...@li... >>> [mailto:spr...@li...] >>> On Behalf Of Loren Rosen >>> Sent: 17 September 2004 17:34 >>> To: spr...@li... >>> Subject: [Springide-eclip-developer] test package checked in >>> >>> I've checked in the beginnings of the test package, as a >>> separate CVS module. (Problem earlier was I was somehow using >>> the pserver protocol to talk to sourceforge instead of extssh.) >>> >>> >>> ------------------------------------------------------- >>> This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one >>> of 170 Project Admins to receive an Apple iPod Mini FREE for >>> your judgement on who ports your project to Linux PPC the >>> best. Sponsored by IBM. >>> Deadline: Sept. 24. Go here: http://sf.net/ppc_contest.php >>> _______________________________________________ >>> Springide-eclip-developer mailing list >>> Spr...@li... >>> https://lists.sourceforge.net/lists/listinfo/springide-eclip- >>> developer >>> >> >> ------------------------------------------------------- >> This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170 >> Project Admins to receive an Apple iPod Mini FREE for your judgement >> on >> who ports your project to Linux PPC the best. Sponsored by IBM. >> Deadline: Sept. 24. Go here: http://sf.net/ppc_contest.php >> _______________________________________________ >> Springide-eclip-developer mailing list >> Spr...@li... >> https://lists.sourceforge.net/lists/listinfo/springide-eclip-developer >> > > > ------------------------------------------------------- > This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170 > Project Admins to receive an Apple iPod Mini FREE for your judgement on > who ports your project to Linux PPC the best. Sponsored by IBM. > Deadline: Sept. 24. Go here: http://sf.net/ppc_contest.php > _______________________________________________ > Springide-eclip-developer mailing list > Spr...@li... > https://lists.sourceforge.net/lists/listinfo/springide-eclip-developer > |
|
From: Loren R. <lo...@gm...> - 2004-09-17 21:50:11
|
I have occasionally seen intermitant assertion failures, though not in that particular place. I agree that something asychronous is a likely culprit. A few lines above the failing assertion, you'll see that the thread waits for the autobuild to complete (autobuilding apparently runs asynchronously on another thread). Perhaps there's yet another thread doing work here that we don't know about. It's of course not a solution, but it would be instructive to put the test thread asleep for several seconds just before this assertion. One thing I'll do over the weekend or on Monday is see if I can get the debugger to tell me what threads are running, or maybe put some breakpoints in the bean model code and see it's being modified asynchronously. On Fri, 17 Sep 2004 17:58:50 +0100, Watkins, David <dav...@fa...> wrote: > Loren, > > Just checked out the new project and am up and testing! > > However it is behaving a little strangely - Most of the time everything > works and I get the green bar, but sometimes (<10%) I get a red bar > (always with the same trace) > > junit.framework.AssertionFailedError > at junit.framework.Assert.fail(Assert.java:47) > at junit.framework.Assert.assertTrue(Assert.java:20) > at junit.framework.Assert.assertTrue(Assert.java:27) > at > org.springframework.ide.test.NatureTests.testNatureAddAndRemove(NatureTe > sts.java:70) > ....[snip].... > > Not 100% sure whats going on, I'm guessing that sometimes the model is > not being updated with the project before that line of code runs. This > would tally with some of the things I've seen with the refactoring stuff > I've been working on.... > > Cheers, > dw > > > > > > -----Original Message----- > > From: spr...@li... > > [mailto:spr...@li...] > > On Behalf Of Loren Rosen > > Sent: 17 September 2004 17:34 > > To: spr...@li... > > Subject: [Springide-eclip-developer] test package checked in > > > > I've checked in the beginnings of the test package, as a > > separate CVS module. (Problem earlier was I was somehow using > > the pserver protocol to talk to sourceforge instead of extssh.) > > > > > > ------------------------------------------------------- > > This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one > > of 170 Project Admins to receive an Apple iPod Mini FREE for > > your judgement on who ports your project to Linux PPC the > > best. Sponsored by IBM. > > Deadline: Sept. 24. Go here: http://sf.net/ppc_contest.php > > _______________________________________________ > > Springide-eclip-developer mailing list > > Spr...@li... > > https://lists.sourceforge.net/lists/listinfo/springide-eclip-developer > > > > ------------------------------------------------------- > This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170 > Project Admins to receive an Apple iPod Mini FREE for your judgement on > who ports your project to Linux PPC the best. Sponsored by IBM. > Deadline: Sept. 24. Go here: http://sf.net/ppc_contest.php > _______________________________________________ > Springide-eclip-developer mailing list > Spr...@li... > https://lists.sourceforge.net/lists/listinfo/springide-eclip-developer > |
|
From: Watkins, D. <dav...@fa...> - 2004-09-17 16:58:58
|
Loren,
Just checked out the new project and am up and testing! =20
However it is behaving a little strangely - Most of the time everything
works and I get the green bar, but sometimes (<10%) I get a red bar
(always with the same trace)
junit.framework.AssertionFailedError
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertTrue(Assert.java:27)
at
org.springframework.ide.test.NatureTests.testNatureAddAndRemove(NatureTe
sts.java:70)
....[snip]....
Not 100% sure whats going on, I'm guessing that sometimes the model is
not being updated with the project before that line of code runs. This
would tally with some of the things I've seen with the refactoring stuff
I've been working on....
Cheers,
dw
> -----Original Message-----
> From: spr...@li...=20
> [mailto:spr...@li...]
> On Behalf Of Loren Rosen
> Sent: 17 September 2004 17:34
> To: spr...@li...
> Subject: [Springide-eclip-developer] test package checked in
>=20
> I've checked in the beginnings of the test package, as a=20
> separate CVS module. (Problem earlier was I was somehow using=20
> the pserver protocol to talk to sourceforge instead of extssh.)
>=20
>=20
> -------------------------------------------------------
> This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one=20
> of 170 Project Admins to receive an Apple iPod Mini FREE for=20
> your judgement on who ports your project to Linux PPC the=20
> best. Sponsored by IBM.
> Deadline: Sept. 24. Go here: http://sf.net/ppc_contest.php=20
> _______________________________________________
> Springide-eclip-developer mailing list
> Spr...@li...
> https://lists.sourceforge.net/lists/listinfo/springide-eclip-developer
>=20
|
|
From: Loren R. <lo...@gm...> - 2004-09-17 16:34:17
|
I've checked in the beginnings of the test package, as a separate CVS module. (Problem earlier was I was somehow using the pserver protocol to talk to sourceforge instead of extssh.) |
|
From: Loren R. <lo...@gm...> - 2004-09-16 22:38:17
|
The regression problem turned out to be due to a bug which you fixed yesterday. It works now. I don't directly use the spring code in the tests, but I do need to setup projects with the other springide plugins, and these need to reference spring core and run with it. The various issues with having the spring core code in a separate plugin might be solvable, but for the moment it's not worth worrying about. On Thu, 16 Sep 2004 22:54:49 +0200, Torsten Juergeleit <tor...@t-...> wrote: > Loren, > > > Figured out the problem. I succeeded in importing all the external > > code as plug-in dependencies. This included the springframework code. > > Problem is that one of the springide packages has a local copy of a > > newer version of the spring-core jar. End result was I was running > > code that tried to use a mix of springframework classes from two > > different places. > > Yes, Spring IDE's core plugin brings it's own version of Spring's core > jar (spring-core.jar), Xerces (required for XML parser with DOM level 3 > support) and commons-logging.jar (required by spring-core.jar). > > Why do you need the spring framework code? > Aren't you creating plugins which depend on the Spring IDE plugin's? If > yes, then you should reference the libraries which are part of Spring > IDE's plugin (namely core with spring-core.jar and Xerces). > > Or do I miss something? > > > Of course eventually we'll need to replace the internal use > > spring-code.jar with reference to the an updated version of the plugin > > that wraps the springframework code. > > The separate plugin 'org.springframework' with the Spring Framework > core jar is not used anymore. I dropped it because it was a > troublemaker: > > - We had to tie a version of Spring IDE's core plugin with a specific > version of this Spring Framework (core) plugin because of changing API > in spring-core.jar (with every new release of Spring the XML > configuration parsers internals are different). If someone has a > different (newer or older) version of 'org.springframework' then Spring > IDE's core isn't working anymore!!! > > - I had class loader issues with spring-core.jar which needs an XML > parser (which is part of a different plugin - Spring IDE's core). If > spring-core.jar is part of a separate plugin then it can't "see" the > Xerces XML parser in Spring IDE's core plugin. It "sees" only the older > XML parser API of the Apache Crimson parser of JDK 1.4.x. But Spring > IDE's core plugin already initialized the Xerces parser with it's new > XML parser API (SAX2, DOM, XPATH, ...). This results in > ClassNotFoundExceptions. > > So I decided to drop supporting a separate plugin for spring-core.jar. > It's not part of the new Spring IDE CVS repository anymore. > > The Spring Framework reference documentation moved to a new plugin > called 'org.springframework.ide.eclipse.beans.core.doc'. > > > There is one less validation error than before, but > > that's likely to be either a real bug in the new springide code or an > > expected change in the errors the validator should generate. I'll > > discuss that issue separately, > > Could you please send a sample with the validation error which is not > found anymore? > This might be an issue with the refactored validator or with the new > beans model. > > Cheers, > Torsten > > > > > On 15.09.2004, at 23:44, Loren Rosen wrote: > > > Figured out the problem. I succeeded in importing all the external > > code as plug-in dependencies. This included the springframework code. > > Problem is that one of the springide packages has a local copy of a > > newer version of the spring-core jar. End result was I was running > > code that tried to use a mix of springframework classes from two > > different places. This caused ClassNotFound exceptions. Reports of the > > exceptions were in the log files, but other than that simply caused > > validation to silently fail. > > > > It's arguable that validation shouldn't fail silently. The fix would > > be to put an exception handler in BeansConfig.getException. But this > > problem shouldn't arise much in practice. > > > > Of course eventually we'll need to replace the internal use > > spring-code.jar with reference to the an updated version of the plugin > > that wraps the springframework code. > > > > Also, as I mentioned, I now know how to setup the eclipse projects > > with proper plugin dependencies. Eventually I could check in my > > modified plugin.xml files-- this will save work when upgrading to new > > releases of eclipse. > > > > With the change to use the local spring-code.jar, the regression tests > > run as expected. There is one less validation error than before, but > > that's likely to be either a real bug in the new springide code or an > > expected change in the errors the validator should generate. I'll > > discuss that issue separately, > > > > > > > > On Wed, 15 Sep 2004 17:15:08 +0100, Watkins, David > > <dav...@fa...> wrote: > >> Loren, > >> The problem markers are working with the code I'm using. Are you not > >> seeing the little red x's or is it the structure of the marker itself > >> which is wrong. It sounds like it's the former but if it's the > >> second > >> then I know Torsten changed the contents of the marker to give more > >> information - this way we should be able to look at providing quick > >> fix > >> support. > >> > >> I've no idea what could be wrong with the CVS stuff. I know I can > >> check > >> into the existing code but haven't tried creating a new top-level > >> folder. > >> > >> Dw > >> > >> > >>> -----Original Message----- > >>> From: spr...@li... > >>> [mailto:spr...@li...] > >>> On Behalf Of Loren Rosen > >>> Sent: 15 September 2004 17:01 > >>> To: Spr...@li... > >>> Subject: Re: [Springide-eclip-developer] Fwd: Re: problems > >>> with latest version of Spring IDE code > >>> > >>> After updating with the latest code, the tests for adding and > >>> removing the beans nature work. However, I can now run the > >>> tests of the validator, and these fail. It appears that > >>> annotations are not being made for validation errors. You can > >>> easily confirm this manually. > >>> > >>> The tests are in a separate package, which is intended to be > >>> a separate eclipse project and separate CVS module. I tried > >>> to push them into CVS at sourceforge, but it seems I don't > >>> have the proper permissions to do this. > >>> > >>> > >>> On Wed, 15 Sep 2004 10:15:42 +0100, Watkins, David > >>> <dav...@fa...> wrote: > >>>> I've manually tested this from the latest head release and > >>> it seems to > >>>> be fixed. > >>>> > >>>> dw > >>>> > >>>>> -----Original Message----- > >>>>> From: spr...@li... > >>>>> [mailto:spr...@li...] > >>>>> On Behalf Of Loren Rosen > >>>>> Sent: 14 September 2004 20:00 > >>>>> To: Spr...@li... > >>>>> Subject: [Springide-eclip-developer] Fwd: Re: problems > >>> with latest > >>>>> version of Spring IDE code > >>>>> > >>>>> moving over another e-mail thread. > >>>>> > >>>>> --- Torsten Juergeleit <tor...@t-...> wrote: > >>>>> > >>>>>> From: tor...@t-... (Torsten > >>>>>> Juergeleit) > >>>>>> Subject: Re: problems with latest version of Spring IDE code > >>>>>> Date: Mon, 13 Sep 2004 22:32:36 +0200 > >>>>>> To: Loren Rosen <lor...@ya...>, David Watkins > >>>>>> <dav...@fa...> > >>>>>> > >>>>>> Sorry guys, I fixed the problem in BeanModel's internal > >>> resource > >>>>>> change event handler (did wrong check for 'isSpringProject()' > >>>>>> event :-( ). > >>>>>> Changes are commited to CVS head. > >>>>>> > >>>>>> BTW, I created a mailing list for Spring IDE: > >>>>>> > >>>>>> > >>>>> > >>> https://lists.sourceforge.net/lists/subscribe/springide-eclip-develo > >>>>> pe > >>>>>> r > >>>>>> > >>>>>> Cheers, > >>>>>> Torsten > >>>>>> > >>>>>> > >>>>>> On 13.09.2004, at 18:45, Watkins, David wrote: > >>>>>> > >>>>>>> Hi Loren, > >>>>>>> I've been getting this with on my own (manual) > >>>>>> tests. Killing the > >>>>>>> runtime workspace and restarting it causes the > >>>>>> updated project to be > >>>>>>> seen and everything works. I think your diagnosis > >>>>>> is correct - it > >>>>>>> seems > >>>>>>> as if the 'add nature' action isn't updating the > >>>>>> BeansModel with the > >>>>>>> new > >>>>>>> project. I'd be very keen on getting the tests > >>>>>> checked in asap - are > >>>>>>> they in a separate plugin or within the existing > >>>>>> plugin modules? Once > >>>>>>> I've got the tests I'll see if I can add a fix as > >>>>>> it's beginning to bug > >>>>>>> me too! > >>>>>>> > >>>>>>> Cheers, > >>>>>>> dw > >>>>>>> > >>>>>>>> -----Original Message----- > >>>>>>>> From: Loren Rosen [mailto:lor...@ya...] > >>>>>>>> Sent: 13 September 2004 17:37 > >>>>>>>> To: Torsten Juergeleit > >>>>>>>> Cc: Watkins, David > >>>>>>>> Subject: problems with latest version of Spring > >>>>>> IDE code > >>>>>>>> > >>>>>>>> I've got my tests to compile and run the > >>>>>> springide-eclipse > >>>>>>>> code checked out from sourceforge. > >>>>>>>> This took some work to get the eclipse projects > >>>>>> configured, > >>>>>>>> but that's another story. The more immediate > >>>>>> problem is that > >>>>>>>> my tests fail. This is a regression from the > >>>>>> 1.0.3 release. > >>>>>>>> > >>>>>>>> The first test run is one that simply sets the > >>>>>> Bean project > >>>>>>>> nature, then unsets it. Before, after and > >>>>>> in-between it > >>>>>>>> checks that various eclipse attributes are as > >>>>>> they should be. > >>>>>>>> This test fails in the middle. > >>>>>>>> > >>>>>>>> Concretely, the test calls > >>>>>>>> BeansCoreUtils.addProjectNature() to add the bean > >>>>>> project > >>>>>>>> nature. Then it calls model.hasProject to check > >>>>>> that the > >>>>>>>> beans model knows about the project just added. > >>>>>> This check fails. > >>>>>>>> > >>>>>>>> If these test assertions are commented out, the > >>>>>> code then > >>>>>>>> calls BeansCoreUtils.removeProjectNature(), and > >>>>>> this gets a > >>>>>>>> NullPointerException, essentially for the same > >>>>>> reason that > >>>>>>>> hasProject() returns false. > >>>>>>>> > >>>>>>>> The other test failures come down to the same > >>>>>> cause. > >>>>>>>> > >>>>>>>> It looks as if the beans model in the newer code > >>>>>> is not > >>>>>>>> keeping things consistent with eclipse's own idea > >>>>>> of what > >>>>>>>> projects have what natures. It may be that this > >>>>>> code isn't > >>>>>>>> expected to be stable yet, but I thought you'd > >>>>>> want to know. > >>>>>>>> > >>>>>>>> I can check in my code now, but of course you'll > >>>>>> have to be > >>>>>>>> aware that the tests will fail. > >>>>>>>> > >>>>>>>> > >>>>>>>> > >>>>>>>> _______________________________ Do you Yahoo!? > >>>>>>>> Shop for Back-to-School deals on Yahoo! Shopping. > >>>>>>>> http://shopping.yahoo.com/backtoschool > >>>>>>>> > >>>>>>> > >>>>>> > >>>>>> > >>>>> > >>>>> > >>>>> ------------------------------------------------------- > >>>>> This SF.Net email is sponsored by: thawte's Crypto Challenge Vl > >>>>> Crack the code and win a Sony DCRHC40 MiniDV Digital Handycam > >>>>> Camcorder. More prizes in the weekly Lunch Hour Challenge. > >>>>> Sign up NOW http://ad.doubleclick.net/clk;10740251;10262165;m > >>>>> _______________________________________________ > >>>>> Springide-eclip-developer mailing list > >>>>> Spr...@li... > >>>>> > >>> https://lists.sourceforge.net/lists/listinfo/springide-eclip-develop > >>>>> er > >>>>> > >>>> > >>> > >>> > >>> ------------------------------------------------------- > >>> This SF.Net email is sponsored by: thawte's Crypto Challenge > >>> Vl Crack the code and win a Sony DCRHC40 MiniDV Digital > >>> Handycam Camcorder. More prizes in the weekly Lunch Hour Challenge. > >>> Sign up NOW http://ad.doubleclick.net/clk;10740251;10262165;m > >>> _______________________________________________ > >>> Springide-eclip-developer mailing list > >>> Spr...@li... > >>> https://lists.sourceforge.net/lists/listinfo/springide-eclip- > >>> developer > >>> > >> > >> > >> > >> > >> ------------------------------------------------------- > >> This SF.Net email is sponsored by: thawte's Crypto Challenge Vl > >> Crack the code and win a Sony DCRHC40 MiniDV Digital Handycam > >> Camcorder. More prizes in the weekly Lunch Hour Challenge. > >> Sign up NOW http://ad.doubleclick.net/clk;10740251;10262165;m > >> _______________________________________________ > >> Springide-eclip-developer mailing list > >> Spr...@li... > >> https://lists.sourceforge.net/lists/listinfo/springide-eclip-developer > >> > > > > > > ------------------------------------------------------- > > This SF.Net email is sponsored by: thawte's Crypto Challenge Vl > > Crack the code and win a Sony DCRHC40 MiniDV Digital Handycam > > Camcorder. More prizes in the weekly Lunch Hour Challenge. > > Sign up NOW http://ad.doubleclick.net/clk;10740251;10262165;m > > _______________________________________________ > > Springide-eclip-developer mailing list > > Spr...@li... > > https://lists.sourceforge.net/lists/listinfo/springide-eclip-developer > > > > ------------------------------------------------------- > This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170 > Project Admins to receive an Apple iPod Mini FREE for your judgement on > who ports your project to Linux PPC the best. Sponsored by IBM. > Deadline: Sept. 24. Go here: http://sf.net/ppc_contest.php > > > _______________________________________________ > Springide-eclip-developer mailing list > Spr...@li... > https://lists.sourceforge.net/lists/listinfo/springide-eclip-developer > |
|
From: <tor...@t-...> - 2004-09-16 20:54:57
|
Loren, > Figured out the problem. I succeeded in importing all the external > code as plug-in dependencies. This included the springframework code. > Problem is that one of the springide packages has a local copy of a > newer version of the spring-core jar. End result was I was running > code that tried to use a mix of springframework classes from two > different places. Yes, Spring IDE's core plugin brings it's own version of Spring's core jar (spring-core.jar), Xerces (required for XML parser with DOM level 3 support) and commons-logging.jar (required by spring-core.jar). Why do you need the spring framework code? Aren't you creating plugins which depend on the Spring IDE plugin's? If yes, then you should reference the libraries which are part of Spring IDE's plugin (namely core with spring-core.jar and Xerces). Or do I miss something? > Of course eventually we'll need to replace the internal use > spring-code.jar with reference to the an updated version of the plugin > that wraps the springframework code. The separate plugin 'org.springframework' with the Spring Framework core jar is not used anymore. I dropped it because it was a troublemaker: - We had to tie a version of Spring IDE's core plugin with a specific version of this Spring Framework (core) plugin because of changing API in spring-core.jar (with every new release of Spring the XML configuration parsers internals are different). If someone has a different (newer or older) version of 'org.springframework' then Spring IDE's core isn't working anymore!!! - I had class loader issues with spring-core.jar which needs an XML parser (which is part of a different plugin - Spring IDE's core). If spring-core.jar is part of a separate plugin then it can't "see" the Xerces XML parser in Spring IDE's core plugin. It "sees" only the older XML parser API of the Apache Crimson parser of JDK 1.4.x. But Spring IDE's core plugin already initialized the Xerces parser with it's new XML parser API (SAX2, DOM, XPATH, ...). This results in ClassNotFoundExceptions. So I decided to drop supporting a separate plugin for spring-core.jar. It's not part of the new Spring IDE CVS repository anymore. The Spring Framework reference documentation moved to a new plugin called 'org.springframework.ide.eclipse.beans.core.doc'. > There is one less validation error than before, but > that's likely to be either a real bug in the new springide code or an > expected change in the errors the validator should generate. I'll > discuss that issue separately, Could you please send a sample with the validation error which is not found anymore? This might be an issue with the refactored validator or with the new beans model. Cheers, Torsten On 15.09.2004, at 23:44, Loren Rosen wrote: > Figured out the problem. I succeeded in importing all the external > code as plug-in dependencies. This included the springframework code. > Problem is that one of the springide packages has a local copy of a > newer version of the spring-core jar. End result was I was running > code that tried to use a mix of springframework classes from two > different places. This caused ClassNotFound exceptions. Reports of the > exceptions were in the log files, but other than that simply caused > validation to silently fail. > > It's arguable that validation shouldn't fail silently. The fix would > be to put an exception handler in BeansConfig.getException. But this > problem shouldn't arise much in practice. > > Of course eventually we'll need to replace the internal use > spring-code.jar with reference to the an updated version of the plugin > that wraps the springframework code. > > Also, as I mentioned, I now know how to setup the eclipse projects > with proper plugin dependencies. Eventually I could check in my > modified plugin.xml files-- this will save work when upgrading to new > releases of eclipse. > > With the change to use the local spring-code.jar, the regression tests > run as expected. There is one less validation error than before, but > that's likely to be either a real bug in the new springide code or an > expected change in the errors the validator should generate. I'll > discuss that issue separately, > > > > On Wed, 15 Sep 2004 17:15:08 +0100, Watkins, David > <dav...@fa...> wrote: >> Loren, >> The problem markers are working with the code I'm using. Are you not >> seeing the little red x's or is it the structure of the marker itself >> which is wrong. It sounds like it's the former but if it's the >> second >> then I know Torsten changed the contents of the marker to give more >> information - this way we should be able to look at providing quick >> fix >> support. >> >> I've no idea what could be wrong with the CVS stuff. I know I can >> check >> into the existing code but haven't tried creating a new top-level >> folder. >> >> Dw >> >> >>> -----Original Message----- >>> From: spr...@li... >>> [mailto:spr...@li...] >>> On Behalf Of Loren Rosen >>> Sent: 15 September 2004 17:01 >>> To: Spr...@li... >>> Subject: Re: [Springide-eclip-developer] Fwd: Re: problems >>> with latest version of Spring IDE code >>> >>> After updating with the latest code, the tests for adding and >>> removing the beans nature work. However, I can now run the >>> tests of the validator, and these fail. It appears that >>> annotations are not being made for validation errors. You can >>> easily confirm this manually. >>> >>> The tests are in a separate package, which is intended to be >>> a separate eclipse project and separate CVS module. I tried >>> to push them into CVS at sourceforge, but it seems I don't >>> have the proper permissions to do this. >>> >>> >>> On Wed, 15 Sep 2004 10:15:42 +0100, Watkins, David >>> <dav...@fa...> wrote: >>>> I've manually tested this from the latest head release and >>> it seems to >>>> be fixed. >>>> >>>> dw >>>> >>>>> -----Original Message----- >>>>> From: spr...@li... >>>>> [mailto:spr...@li...] >>>>> On Behalf Of Loren Rosen >>>>> Sent: 14 September 2004 20:00 >>>>> To: Spr...@li... >>>>> Subject: [Springide-eclip-developer] Fwd: Re: problems >>> with latest >>>>> version of Spring IDE code >>>>> >>>>> moving over another e-mail thread. >>>>> >>>>> --- Torsten Juergeleit <tor...@t-...> wrote: >>>>> >>>>>> From: tor...@t-... (Torsten >>>>>> Juergeleit) >>>>>> Subject: Re: problems with latest version of Spring IDE code >>>>>> Date: Mon, 13 Sep 2004 22:32:36 +0200 >>>>>> To: Loren Rosen <lor...@ya...>, David Watkins >>>>>> <dav...@fa...> >>>>>> >>>>>> Sorry guys, I fixed the problem in BeanModel's internal >>> resource >>>>>> change event handler (did wrong check for 'isSpringProject()' >>>>>> event :-( ). >>>>>> Changes are commited to CVS head. >>>>>> >>>>>> BTW, I created a mailing list for Spring IDE: >>>>>> >>>>>> >>>>> >>> https://lists.sourceforge.net/lists/subscribe/springide-eclip-develo >>>>> pe >>>>>> r >>>>>> >>>>>> Cheers, >>>>>> Torsten >>>>>> >>>>>> >>>>>> On 13.09.2004, at 18:45, Watkins, David wrote: >>>>>> >>>>>>> Hi Loren, >>>>>>> I've been getting this with on my own (manual) >>>>>> tests. Killing the >>>>>>> runtime workspace and restarting it causes the >>>>>> updated project to be >>>>>>> seen and everything works. I think your diagnosis >>>>>> is correct - it >>>>>>> seems >>>>>>> as if the 'add nature' action isn't updating the >>>>>> BeansModel with the >>>>>>> new >>>>>>> project. I'd be very keen on getting the tests >>>>>> checked in asap - are >>>>>>> they in a separate plugin or within the existing >>>>>> plugin modules? Once >>>>>>> I've got the tests I'll see if I can add a fix as >>>>>> it's beginning to bug >>>>>>> me too! >>>>>>> >>>>>>> Cheers, >>>>>>> dw >>>>>>> >>>>>>>> -----Original Message----- >>>>>>>> From: Loren Rosen [mailto:lor...@ya...] >>>>>>>> Sent: 13 September 2004 17:37 >>>>>>>> To: Torsten Juergeleit >>>>>>>> Cc: Watkins, David >>>>>>>> Subject: problems with latest version of Spring >>>>>> IDE code >>>>>>>> >>>>>>>> I've got my tests to compile and run the >>>>>> springide-eclipse >>>>>>>> code checked out from sourceforge. >>>>>>>> This took some work to get the eclipse projects >>>>>> configured, >>>>>>>> but that's another story. The more immediate >>>>>> problem is that >>>>>>>> my tests fail. This is a regression from the >>>>>> 1.0.3 release. >>>>>>>> >>>>>>>> The first test run is one that simply sets the >>>>>> Bean project >>>>>>>> nature, then unsets it. Before, after and >>>>>> in-between it >>>>>>>> checks that various eclipse attributes are as >>>>>> they should be. >>>>>>>> This test fails in the middle. >>>>>>>> >>>>>>>> Concretely, the test calls >>>>>>>> BeansCoreUtils.addProjectNature() to add the bean >>>>>> project >>>>>>>> nature. Then it calls model.hasProject to check >>>>>> that the >>>>>>>> beans model knows about the project just added. >>>>>> This check fails. >>>>>>>> >>>>>>>> If these test assertions are commented out, the >>>>>> code then >>>>>>>> calls BeansCoreUtils.removeProjectNature(), and >>>>>> this gets a >>>>>>>> NullPointerException, essentially for the same >>>>>> reason that >>>>>>>> hasProject() returns false. >>>>>>>> >>>>>>>> The other test failures come down to the same >>>>>> cause. >>>>>>>> >>>>>>>> It looks as if the beans model in the newer code >>>>>> is not >>>>>>>> keeping things consistent with eclipse's own idea >>>>>> of what >>>>>>>> projects have what natures. It may be that this >>>>>> code isn't >>>>>>>> expected to be stable yet, but I thought you'd >>>>>> want to know. >>>>>>>> >>>>>>>> I can check in my code now, but of course you'll >>>>>> have to be >>>>>>>> aware that the tests will fail. >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> _______________________________ Do you Yahoo!? >>>>>>>> Shop for Back-to-School deals on Yahoo! Shopping. >>>>>>>> http://shopping.yahoo.com/backtoschool >>>>>>>> >>>>>>> >>>>>> >>>>>> >>>>> >>>>> >>>>> ------------------------------------------------------- >>>>> This SF.Net email is sponsored by: thawte's Crypto Challenge Vl >>>>> Crack the code and win a Sony DCRHC40 MiniDV Digital Handycam >>>>> Camcorder. More prizes in the weekly Lunch Hour Challenge. >>>>> Sign up NOW http://ad.doubleclick.net/clk;10740251;10262165;m >>>>> _______________________________________________ >>>>> Springide-eclip-developer mailing list >>>>> Spr...@li... >>>>> >>> https://lists.sourceforge.net/lists/listinfo/springide-eclip-develop >>>>> er >>>>> >>>> >>> >>> >>> ------------------------------------------------------- >>> This SF.Net email is sponsored by: thawte's Crypto Challenge >>> Vl Crack the code and win a Sony DCRHC40 MiniDV Digital >>> Handycam Camcorder. More prizes in the weekly Lunch Hour Challenge. >>> Sign up NOW http://ad.doubleclick.net/clk;10740251;10262165;m >>> _______________________________________________ >>> Springide-eclip-developer mailing list >>> Spr...@li... >>> https://lists.sourceforge.net/lists/listinfo/springide-eclip- >>> developer >>> >> >> >> >> >> ------------------------------------------------------- >> This SF.Net email is sponsored by: thawte's Crypto Challenge Vl >> Crack the code and win a Sony DCRHC40 MiniDV Digital Handycam >> Camcorder. More prizes in the weekly Lunch Hour Challenge. >> Sign up NOW http://ad.doubleclick.net/clk;10740251;10262165;m >> _______________________________________________ >> Springide-eclip-developer mailing list >> Spr...@li... >> https://lists.sourceforge.net/lists/listinfo/springide-eclip-developer >> > > > ------------------------------------------------------- > This SF.Net email is sponsored by: thawte's Crypto Challenge Vl > Crack the code and win a Sony DCRHC40 MiniDV Digital Handycam > Camcorder. More prizes in the weekly Lunch Hour Challenge. > Sign up NOW http://ad.doubleclick.net/clk;10740251;10262165;m > _______________________________________________ > Springide-eclip-developer mailing list > Spr...@li... > https://lists.sourceforge.net/lists/listinfo/springide-eclip-developer > |
|
From: <tor...@t-...> - 2004-09-16 20:54:46
|
Loren, > So the small number of regression tests I have now pass. It appears > that the wording of some of the error messages changed, and I changed > the test code to match. Spring IDE's problem marker which are created via BeansCoreUtils.createproblemMarker() hold additional data (defined in the interface org.springframework.ide.eclipse.beans.core.IBeansProjectMarker). You can use "marker.getAttribute(IBeansProjectMarker.ERROR_CODE, IBeansProjectMarker.ERROR_CODE_NONE) == IBeansProjectMarker.ERROR_CODE_xxx" to check for a specific validation error. For possible validation errors and their problem marker data please refer to org.springframework.ide.eclipse.beans.core.model.BeansConfigValidator. Cheers, Torsten On 16.09.2004, at 19:53, Loren Rosen wrote: > So the small number of regression tests I have now pass. It appears > that the wording of some of the error messages changed, and I changed > the test code to match. > > There are of course many more tests that should be written, but what I > have can be checked in. Only stumbling block being the permissions > issue with adding new CVS modules. > > > ------------------------------------------------------- > This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170 > Project Admins to receive an Apple iPod Mini FREE for your judgement on > who ports your project to Linux PPC the best. Sponsored by IBM. > Deadline: Sept. 24. Go here: http://sf.net/ppc_contest.php > _______________________________________________ > Springide-eclip-developer mailing list > Spr...@li... > https://lists.sourceforge.net/lists/listinfo/springide-eclip-developer |
|
From: <tor...@t-...> - 2004-09-16 20:12:02
|
Loren, > Only stumbling block being the permissions > issue with adding new CVS modules. Strange, I checked your permissions. They are the same as for David. |
|
From: Loren R. <lo...@gm...> - 2004-09-16 17:53:47
|
So the small number of regression tests I have now pass. It appears that the wording of some of the error messages changed, and I changed the test code to match. There are of course many more tests that should be written, but what I have can be checked in. Only stumbling block being the permissions issue with adding new CVS modules. |
|
From: Loren R. <lo...@gm...> - 2004-09-15 21:44:52
|
Figured out the problem. I succeeded in importing all the external code as plug-in dependencies. This included the springframework code. Problem is that one of the springide packages has a local copy of a newer version of the spring-core jar. End result was I was running code that tried to use a mix of springframework classes from two different places. This caused ClassNotFound exceptions. Reports of the exceptions were in the log files, but other than that simply caused validation to silently fail. It's arguable that validation shouldn't fail silently. The fix would be to put an exception handler in BeansConfig.getException. But this problem shouldn't arise much in practice. Of course eventually we'll need to replace the internal use spring-code.jar with reference to the an updated version of the plugin that wraps the springframework code. Also, as I mentioned, I now know how to setup the eclipse projects with proper plugin dependencies. Eventually I could check in my modified plugin.xml files-- this will save work when upgrading to new releases of eclipse. With the change to use the local spring-code.jar, the regression tests run as expected. There is one less validation error than before, but that's likely to be either a real bug in the new springide code or an expected change in the errors the validator should generate. I'll discuss that issue separately, On Wed, 15 Sep 2004 17:15:08 +0100, Watkins, David <dav...@fa...> wrote: > Loren, > The problem markers are working with the code I'm using. Are you not > seeing the little red x's or is it the structure of the marker itself > which is wrong. It sounds like it's the former but if it's the second > then I know Torsten changed the contents of the marker to give more > information - this way we should be able to look at providing quick fix > support. > > I've no idea what could be wrong with the CVS stuff. I know I can check > into the existing code but haven't tried creating a new top-level > folder. > > Dw > > > > -----Original Message----- > > From: spr...@li... > > [mailto:spr...@li...] > > On Behalf Of Loren Rosen > > Sent: 15 September 2004 17:01 > > To: Spr...@li... > > Subject: Re: [Springide-eclip-developer] Fwd: Re: problems > > with latest version of Spring IDE code > > > > After updating with the latest code, the tests for adding and > > removing the beans nature work. However, I can now run the > > tests of the validator, and these fail. It appears that > > annotations are not being made for validation errors. You can > > easily confirm this manually. > > > > The tests are in a separate package, which is intended to be > > a separate eclipse project and separate CVS module. I tried > > to push them into CVS at sourceforge, but it seems I don't > > have the proper permissions to do this. > > > > > > On Wed, 15 Sep 2004 10:15:42 +0100, Watkins, David > > <dav...@fa...> wrote: > > > I've manually tested this from the latest head release and > > it seems to > > > be fixed. > > > > > > dw > > > > > > > -----Original Message----- > > > > From: spr...@li... > > > > [mailto:spr...@li...] > > > > On Behalf Of Loren Rosen > > > > Sent: 14 September 2004 20:00 > > > > To: Spr...@li... > > > > Subject: [Springide-eclip-developer] Fwd: Re: problems > > with latest > > > > version of Spring IDE code > > > > > > > > moving over another e-mail thread. > > > > > > > > --- Torsten Juergeleit <tor...@t-...> wrote: > > > > > > > > > From: tor...@t-... (Torsten > > > > > Juergeleit) > > > > > Subject: Re: problems with latest version of Spring IDE code > > > > > Date: Mon, 13 Sep 2004 22:32:36 +0200 > > > > > To: Loren Rosen <lor...@ya...>, David Watkins > > > > > <dav...@fa...> > > > > > > > > > > Sorry guys, I fixed the problem in BeanModel's internal > > resource > > > > > change event handler (did wrong check for 'isSpringProject()' > > > > > event :-( ). > > > > > Changes are commited to CVS head. > > > > > > > > > > BTW, I created a mailing list for Spring IDE: > > > > > > > > > > > > > > > > https://lists.sourceforge.net/lists/subscribe/springide-eclip-develo > > > > pe > > > > > r > > > > > > > > > > Cheers, > > > > > Torsten > > > > > > > > > > > > > > > On 13.09.2004, at 18:45, Watkins, David wrote: > > > > > > > > > > > Hi Loren, > > > > > > I've been getting this with on my own (manual) > > > > > tests. Killing the > > > > > > runtime workspace and restarting it causes the > > > > > updated project to be > > > > > > seen and everything works. I think your diagnosis > > > > > is correct - it > > > > > > seems > > > > > > as if the 'add nature' action isn't updating the > > > > > BeansModel with the > > > > > > new > > > > > > project. I'd be very keen on getting the tests > > > > > checked in asap - are > > > > > > they in a separate plugin or within the existing > > > > > plugin modules? Once > > > > > > I've got the tests I'll see if I can add a fix as > > > > > it's beginning to bug > > > > > > me too! > > > > > > > > > > > > Cheers, > > > > > > dw > > > > > > > > > > > >> -----Original Message----- > > > > > >> From: Loren Rosen [mailto:lor...@ya...] > > > > > >> Sent: 13 September 2004 17:37 > > > > > >> To: Torsten Juergeleit > > > > > >> Cc: Watkins, David > > > > > >> Subject: problems with latest version of Spring > > > > > IDE code > > > > > >> > > > > > >> I've got my tests to compile and run the > > > > > springide-eclipse > > > > > >> code checked out from sourceforge. > > > > > >> This took some work to get the eclipse projects > > > > > configured, > > > > > >> but that's another story. The more immediate > > > > > problem is that > > > > > >> my tests fail. This is a regression from the > > > > > 1.0.3 release. > > > > > >> > > > > > >> The first test run is one that simply sets the > > > > > Bean project > > > > > >> nature, then unsets it. Before, after and > > > > > in-between it > > > > > >> checks that various eclipse attributes are as > > > > > they should be. > > > > > >> This test fails in the middle. > > > > > >> > > > > > >> Concretely, the test calls > > > > > >> BeansCoreUtils.addProjectNature() to add the bean > > > > > project > > > > > >> nature. Then it calls model.hasProject to check > > > > > that the > > > > > >> beans model knows about the project just added. > > > > > This check fails. > > > > > >> > > > > > >> If these test assertions are commented out, the > > > > > code then > > > > > >> calls BeansCoreUtils.removeProjectNature(), and > > > > > this gets a > > > > > >> NullPointerException, essentially for the same > > > > > reason that > > > > > >> hasProject() returns false. > > > > > >> > > > > > >> The other test failures come down to the same > > > > > cause. > > > > > >> > > > > > >> It looks as if the beans model in the newer code > > > > > is not > > > > > >> keeping things consistent with eclipse's own idea > > > > > of what > > > > > >> projects have what natures. It may be that this > > > > > code isn't > > > > > >> expected to be stable yet, but I thought you'd > > > > > want to know. > > > > > >> > > > > > >> I can check in my code now, but of course you'll > > > > > have to be > > > > > >> aware that the tests will fail. > > > > > >> > > > > > >> > > > > > >> > > > > > >> _______________________________ Do you Yahoo!? > > > > > >> Shop for Back-to-School deals on Yahoo! Shopping. > > > > > >> http://shopping.yahoo.com/backtoschool > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > > ------------------------------------------------------- > > > > This SF.Net email is sponsored by: thawte's Crypto Challenge Vl > > > > Crack the code and win a Sony DCRHC40 MiniDV Digital Handycam > > > > Camcorder. More prizes in the weekly Lunch Hour Challenge. > > > > Sign up NOW http://ad.doubleclick.net/clk;10740251;10262165;m > > > > _______________________________________________ > > > > Springide-eclip-developer mailing list > > > > Spr...@li... > > > > > > https://lists.sourceforge.net/lists/listinfo/springide-eclip-develop > > > > er > > > > > > > > > > > > > ------------------------------------------------------- > > This SF.Net email is sponsored by: thawte's Crypto Challenge > > Vl Crack the code and win a Sony DCRHC40 MiniDV Digital > > Handycam Camcorder. More prizes in the weekly Lunch Hour Challenge. > > Sign up NOW http://ad.doubleclick.net/clk;10740251;10262165;m > > _______________________________________________ > > Springide-eclip-developer mailing list > > Spr...@li... > > https://lists.sourceforge.net/lists/listinfo/springide-eclip-developer > > > > > > > ------------------------------------------------------- > This SF.Net email is sponsored by: thawte's Crypto Challenge Vl > Crack the code and win a Sony DCRHC40 MiniDV Digital Handycam > Camcorder. More prizes in the weekly Lunch Hour Challenge. > Sign up NOW http://ad.doubleclick.net/clk;10740251;10262165;m > _______________________________________________ > Springide-eclip-developer mailing list > Spr...@li... > https://lists.sourceforge.net/lists/listinfo/springide-eclip-developer > |
|
From: Loren R. <lo...@gm...> - 2004-09-15 17:00:32
|
Running manually, I see no red X's. The test retrieves zero annotations-- there's none to even have the wrong structure. But if you're seeing them, I'll take another look -- perhaps something changed with the way the validation process is triggered. On Wed, 15 Sep 2004 17:15:08 +0100, Watkins, David <dav...@fa...> wrote: > Loren, > The problem markers are working with the code I'm using. Are you not > seeing the little red x's or is it the structure of the marker itself > which is wrong. It sounds like it's the former but if it's the second > then I know Torsten changed the contents of the marker to give more > information - this way we should be able to look at providing quick fix > support. > > I've no idea what could be wrong with the CVS stuff. I know I can check > into the existing code but haven't tried creating a new top-level > folder. > > Dw > > > > -----Original Message----- > > From: spr...@li... > > [mailto:spr...@li...] > > On Behalf Of Loren Rosen > > Sent: 15 September 2004 17:01 > > To: Spr...@li... > > Subject: Re: [Springide-eclip-developer] Fwd: Re: problems > > with latest version of Spring IDE code > > > > After updating with the latest code, the tests for adding and > > removing the beans nature work. However, I can now run the > > tests of the validator, and these fail. It appears that > > annotations are not being made for validation errors. You can > > easily confirm this manually. > > > > The tests are in a separate package, which is intended to be > > a separate eclipse project and separate CVS module. I tried > > to push them into CVS at sourceforge, but it seems I don't > > have the proper permissions to do this. > > > > > > On Wed, 15 Sep 2004 10:15:42 +0100, Watkins, David > > <dav...@fa...> wrote: > > > I've manually tested this from the latest head release and > > it seems to > > > be fixed. > > > > > > dw > > > > > > > -----Original Message----- > > > > From: spr...@li... > > > > [mailto:spr...@li...] > > > > On Behalf Of Loren Rosen > > > > Sent: 14 September 2004 20:00 > > > > To: Spr...@li... > > > > Subject: [Springide-eclip-developer] Fwd: Re: problems > > with latest > > > > version of Spring IDE code > > > > > > > > moving over another e-mail thread. > > > > > > > > --- Torsten Juergeleit <tor...@t-...> wrote: > > > > > > > > > From: tor...@t-... (Torsten > > > > > Juergeleit) > > > > > Subject: Re: problems with latest version of Spring IDE code > > > > > Date: Mon, 13 Sep 2004 22:32:36 +0200 > > > > > To: Loren Rosen <lor...@ya...>, David Watkins > > > > > <dav...@fa...> > > > > > > > > > > Sorry guys, I fixed the problem in BeanModel's internal > > resource > > > > > change event handler (did wrong check for 'isSpringProject()' > > > > > event :-( ). > > > > > Changes are commited to CVS head. > > > > > > > > > > BTW, I created a mailing list for Spring IDE: > > > > > > > > > > > > > > > > https://lists.sourceforge.net/lists/subscribe/springide-eclip-develo > > > > pe > > > > > r > > > > > > > > > > Cheers, > > > > > Torsten > > > > > > > > > > > > > > > On 13.09.2004, at 18:45, Watkins, David wrote: > > > > > > > > > > > Hi Loren, > > > > > > I've been getting this with on my own (manual) > > > > > tests. Killing the > > > > > > runtime workspace and restarting it causes the > > > > > updated project to be > > > > > > seen and everything works. I think your diagnosis > > > > > is correct - it > > > > > > seems > > > > > > as if the 'add nature' action isn't updating the > > > > > BeansModel with the > > > > > > new > > > > > > project. I'd be very keen on getting the tests > > > > > checked in asap - are > > > > > > they in a separate plugin or within the existing > > > > > plugin modules? Once > > > > > > I've got the tests I'll see if I can add a fix as > > > > > it's beginning to bug > > > > > > me too! > > > > > > > > > > > > Cheers, > > > > > > dw > > > > > > > > > > > >> -----Original Message----- > > > > > >> From: Loren Rosen [mailto:lor...@ya...] > > > > > >> Sent: 13 September 2004 17:37 > > > > > >> To: Torsten Juergeleit > > > > > >> Cc: Watkins, David > > > > > >> Subject: problems with latest version of Spring > > > > > IDE code > > > > > >> > > > > > >> I've got my tests to compile and run the > > > > > springide-eclipse > > > > > >> code checked out from sourceforge. > > > > > >> This took some work to get the eclipse projects > > > > > configured, > > > > > >> but that's another story. The more immediate > > > > > problem is that > > > > > >> my tests fail. This is a regression from the > > > > > 1.0.3 release. > > > > > >> > > > > > >> The first test run is one that simply sets the > > > > > Bean project > > > > > >> nature, then unsets it. Before, after and > > > > > in-between it > > > > > >> checks that various eclipse attributes are as > > > > > they should be. > > > > > >> This test fails in the middle. > > > > > >> > > > > > >> Concretely, the test calls > > > > > >> BeansCoreUtils.addProjectNature() to add the bean > > > > > project > > > > > >> nature. Then it calls model.hasProject to check > > > > > that the > > > > > >> beans model knows about the project just added. > > > > > This check fails. > > > > > >> > > > > > >> If these test assertions are commented out, the > > > > > code then > > > > > >> calls BeansCoreUtils.removeProjectNature(), and > > > > > this gets a > > > > > >> NullPointerException, essentially for the same > > > > > reason that > > > > > >> hasProject() returns false. > > > > > >> > > > > > >> The other test failures come down to the same > > > > > cause. > > > > > >> > > > > > >> It looks as if the beans model in the newer code > > > > > is not > > > > > >> keeping things consistent with eclipse's own idea > > > > > of what > > > > > >> projects have what natures. It may be that this > > > > > code isn't > > > > > >> expected to be stable yet, but I thought you'd > > > > > want to know. > > > > > >> > > > > > >> I can check in my code now, but of course you'll > > > > > have to be > > > > > >> aware that the tests will fail. > > > > > >> > > > > > >> > > > > > >> > > > > > >> _______________________________ Do you Yahoo!? > > > > > >> Shop for Back-to-School deals on Yahoo! Shopping. > > > > > >> http://shopping.yahoo.com/backtoschool > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > > ------------------------------------------------------- > > > > This SF.Net email is sponsored by: thawte's Crypto Challenge Vl > > > > Crack the code and win a Sony DCRHC40 MiniDV Digital Handycam > > > > Camcorder. More prizes in the weekly Lunch Hour Challenge. > > > > Sign up NOW http://ad.doubleclick.net/clk;10740251;10262165;m > > > > _______________________________________________ > > > > Springide-eclip-developer mailing list > > > > Spr...@li... > > > > > > https://lists.sourceforge.net/lists/listinfo/springide-eclip-develop > > > > er > > > > > > > > > > > > > ------------------------------------------------------- > > This SF.Net email is sponsored by: thawte's Crypto Challenge > > Vl Crack the code and win a Sony DCRHC40 MiniDV Digital > > Handycam Camcorder. More prizes in the weekly Lunch Hour Challenge. > > Sign up NOW http://ad.doubleclick.net/clk;10740251;10262165;m > > _______________________________________________ > > Springide-eclip-developer mailing list > > Spr...@li... > > https://lists.sourceforge.net/lists/listinfo/springide-eclip-developer > > > > > > > ------------------------------------------------------- > This SF.Net email is sponsored by: thawte's Crypto Challenge Vl > Crack the code and win a Sony DCRHC40 MiniDV Digital Handycam > Camcorder. More prizes in the weekly Lunch Hour Challenge. > Sign up NOW http://ad.doubleclick.net/clk;10740251;10262165;m > _______________________________________________ > Springide-eclip-developer mailing list > Spr...@li... > https://lists.sourceforge.net/lists/listinfo/springide-eclip-developer > |
|
From: Watkins, D. <dav...@fa...> - 2004-09-15 16:15:18
|
Loren, The problem markers are working with the code I'm using. Are you not seeing the little red x's or is it the structure of the marker itself which is wrong. It sounds like it's the former but if it's the second then I know Torsten changed the contents of the marker to give more information - this way we should be able to look at providing quick fix support. I've no idea what could be wrong with the CVS stuff. I know I can check into the existing code but haven't tried creating a new top-level folder. Dw =20 > -----Original Message----- > From: spr...@li...=20 > [mailto:spr...@li...] > On Behalf Of Loren Rosen > Sent: 15 September 2004 17:01 > To: Spr...@li... > Subject: Re: [Springide-eclip-developer] Fwd: Re: problems=20 > with latest version of Spring IDE code >=20 > After updating with the latest code, the tests for adding and=20 > removing the beans nature work. However, I can now run the=20 > tests of the validator, and these fail. It appears that=20 > annotations are not being made for validation errors. You can=20 > easily confirm this manually. >=20 > The tests are in a separate package, which is intended to be=20 > a separate eclipse project and separate CVS module. I tried=20 > to push them into CVS at sourceforge, but it seems I don't=20 > have the proper permissions to do this. >=20 >=20 > On Wed, 15 Sep 2004 10:15:42 +0100, Watkins, David=20 > <dav...@fa...> wrote: > > I've manually tested this from the latest head release and=20 > it seems to=20 > > be fixed. > >=20 > > dw > >=20 > > > -----Original Message----- > > > From: spr...@li... > > > [mailto:spr...@li...] > > > On Behalf Of Loren Rosen > > > Sent: 14 September 2004 20:00 > > > To: Spr...@li... > > > Subject: [Springide-eclip-developer] Fwd: Re: problems=20 > with latest=20 > > > version of Spring IDE code > > > > > > moving over another e-mail thread. > > > > > > --- Torsten Juergeleit <tor...@t-...> wrote: > > > > > > > From: tor...@t-... (Torsten > > > > Juergeleit) > > > > Subject: Re: problems with latest version of Spring IDE code > > > > Date: Mon, 13 Sep 2004 22:32:36 +0200 > > > > To: Loren Rosen <lor...@ya...>, David Watkins=20 > > > > <dav...@fa...> > > > > > > > > Sorry guys, I fixed the problem in BeanModel's internal=20 > resource=20 > > > > change event handler (did wrong check for 'isSpringProject()'=20 > > > > event :-( ). > > > > Changes are commited to CVS head. > > > > > > > > BTW, I created a mailing list for Spring IDE: > > > > > > > > > > >=20 > https://lists.sourceforge.net/lists/subscribe/springide-eclip-develo > > > pe > > > > r > > > >=20 > > > > Cheers, > > > > Torsten > > > > > > > > > > > > On 13.09.2004, at 18:45, Watkins, David wrote: > > > > > > > > > Hi Loren, > > > > > I've been getting this with on my own (manual) > > > > tests. Killing the > > > > > runtime workspace and restarting it causes the > > > > updated project to be > > > > > seen and everything works. I think your diagnosis > > > > is correct - it > > > > > seems > > > > > as if the 'add nature' action isn't updating the > > > > BeansModel with the > > > > > new > > > > > project. I'd be very keen on getting the tests > > > > checked in asap - are > > > > > they in a separate plugin or within the existing > > > > plugin modules? Once > > > > > I've got the tests I'll see if I can add a fix as > > > > it's beginning to bug > > > > > me too! > > > > > > > > > > Cheers, > > > > > dw > > > > > > > > > >> -----Original Message----- > > > > >> From: Loren Rosen [mailto:lor...@ya...] > > > > >> Sent: 13 September 2004 17:37 > > > > >> To: Torsten Juergeleit > > > > >> Cc: Watkins, David > > > > >> Subject: problems with latest version of Spring > > > > IDE code > > > > >> > > > > >> I've got my tests to compile and run the > > > > springide-eclipse > > > > >> code checked out from sourceforge. > > > > >> This took some work to get the eclipse projects > > > > configured, > > > > >> but that's another story. The more immediate > > > > problem is that > > > > >> my tests fail. This is a regression from the > > > > 1.0.3 release. > > > > >> > > > > >> The first test run is one that simply sets the > > > > Bean project > > > > >> nature, then unsets it. Before, after and > > > > in-between it > > > > >> checks that various eclipse attributes are as > > > > they should be. > > > > >> This test fails in the middle. > > > > >> > > > > >> Concretely, the test calls > > > > >> BeansCoreUtils.addProjectNature() to add the bean > > > > project > > > > >> nature. Then it calls model.hasProject to check > > > > that the > > > > >> beans model knows about the project just added. > > > > This check fails. > > > > >> > > > > >> If these test assertions are commented out, the > > > > code then > > > > >> calls BeansCoreUtils.removeProjectNature(), and > > > > this gets a > > > > >> NullPointerException, essentially for the same > > > > reason that > > > > >> hasProject() returns false. > > > > >> > > > > >> The other test failures come down to the same > > > > cause. > > > > >> > > > > >> It looks as if the beans model in the newer code > > > > is not > > > > >> keeping things consistent with eclipse's own idea > > > > of what > > > > >> projects have what natures. It may be that this > > > > code isn't > > > > >> expected to be stable yet, but I thought you'd > > > > want to know. > > > > >> > > > > >> I can check in my code now, but of course you'll > > > > have to be > > > > >> aware that the tests will fail. > > > > >> > > > > >> > > > > >> > > > > >> _______________________________ Do you Yahoo!? > > > > >> Shop for Back-to-School deals on Yahoo! Shopping. > > > > >> http://shopping.yahoo.com/backtoschool > > > > >> > > > > > > > > > > > > > > > > > > >=20 > > > ------------------------------------------------------- > > > This SF.Net email is sponsored by: thawte's Crypto Challenge Vl=20 > > > Crack the code and win a Sony DCRHC40 MiniDV Digital Handycam=20 > > > Camcorder. More prizes in the weekly Lunch Hour Challenge. > > > Sign up NOW http://ad.doubleclick.net/clk;10740251;10262165;m > > > _______________________________________________ > > > Springide-eclip-developer mailing list=20 > > > Spr...@li... > > >=20 > https://lists.sourceforge.net/lists/listinfo/springide-eclip-develop > > > er > > > > > >=20 >=20 > ------------------------------------------------------- > This SF.Net email is sponsored by: thawte's Crypto Challenge=20 > Vl Crack the code and win a Sony DCRHC40 MiniDV Digital=20 > Handycam Camcorder. More prizes in the weekly Lunch Hour Challenge. > Sign up NOW http://ad.doubleclick.net/clk;10740251;10262165;m > _______________________________________________ > Springide-eclip-developer mailing list > Spr...@li... > https://lists.sourceforge.net/lists/listinfo/springide-eclip-developer >=20 |
|
From: Loren R. <lo...@gm...> - 2004-09-15 16:00:45
|
After updating with the latest code, the tests for adding and removing the beans nature work. However, I can now run the tests of the validator, and these fail. It appears that annotations are not being made for validation errors. You can easily confirm this manually. The tests are in a separate package, which is intended to be a separate eclipse project and separate CVS module. I tried to push them into CVS at sourceforge, but it seems I don't have the proper permissions to do this. On Wed, 15 Sep 2004 10:15:42 +0100, Watkins, David <dav...@fa...> wrote: > I've manually tested this from the latest head release and it seems to > be fixed. > > dw > > > -----Original Message----- > > From: spr...@li... > > [mailto:spr...@li...] > > On Behalf Of Loren Rosen > > Sent: 14 September 2004 20:00 > > To: Spr...@li... > > Subject: [Springide-eclip-developer] Fwd: Re: problems with > > latest version of Spring IDE code > > > > moving over another e-mail thread. > > > > --- Torsten Juergeleit <tor...@t-...> wrote: > > > > > From: tor...@t-... (Torsten > > > Juergeleit) > > > Subject: Re: problems with latest version of Spring IDE code > > > Date: Mon, 13 Sep 2004 22:32:36 +0200 > > > To: Loren Rosen <lor...@ya...>, David Watkins > > > <dav...@fa...> > > > > > > Sorry guys, I fixed the problem in BeanModel's internal resource > > > change event handler (did wrong check for 'isSpringProject()' event > > > :-( ). > > > Changes are commited to CVS head. > > > > > > BTW, I created a mailing list for Spring IDE: > > > > > > > > https://lists.sourceforge.net/lists/subscribe/springide-eclip-develope > > > r > > > > > > Cheers, > > > Torsten > > > > > > > > > On 13.09.2004, at 18:45, Watkins, David wrote: > > > > > > > Hi Loren, > > > > I've been getting this with on my own (manual) > > > tests. Killing the > > > > runtime workspace and restarting it causes the > > > updated project to be > > > > seen and everything works. I think your diagnosis > > > is correct - it > > > > seems > > > > as if the 'add nature' action isn't updating the > > > BeansModel with the > > > > new > > > > project. I'd be very keen on getting the tests > > > checked in asap - are > > > > they in a separate plugin or within the existing > > > plugin modules? Once > > > > I've got the tests I'll see if I can add a fix as > > > it's beginning to bug > > > > me too! > > > > > > > > Cheers, > > > > dw > > > > > > > >> -----Original Message----- > > > >> From: Loren Rosen [mailto:lor...@ya...] > > > >> Sent: 13 September 2004 17:37 > > > >> To: Torsten Juergeleit > > > >> Cc: Watkins, David > > > >> Subject: problems with latest version of Spring > > > IDE code > > > >> > > > >> I've got my tests to compile and run the > > > springide-eclipse > > > >> code checked out from sourceforge. > > > >> This took some work to get the eclipse projects > > > configured, > > > >> but that's another story. The more immediate > > > problem is that > > > >> my tests fail. This is a regression from the > > > 1.0.3 release. > > > >> > > > >> The first test run is one that simply sets the > > > Bean project > > > >> nature, then unsets it. Before, after and > > > in-between it > > > >> checks that various eclipse attributes are as > > > they should be. > > > >> This test fails in the middle. > > > >> > > > >> Concretely, the test calls > > > >> BeansCoreUtils.addProjectNature() to add the bean > > > project > > > >> nature. Then it calls model.hasProject to check > > > that the > > > >> beans model knows about the project just added. > > > This check fails. > > > >> > > > >> If these test assertions are commented out, the > > > code then > > > >> calls BeansCoreUtils.removeProjectNature(), and > > > this gets a > > > >> NullPointerException, essentially for the same > > > reason that > > > >> hasProject() returns false. > > > >> > > > >> The other test failures come down to the same > > > cause. > > > >> > > > >> It looks as if the beans model in the newer code > > > is not > > > >> keeping things consistent with eclipse's own idea > > > of what > > > >> projects have what natures. It may be that this > > > code isn't > > > >> expected to be stable yet, but I thought you'd > > > want to know. > > > >> > > > >> I can check in my code now, but of course you'll > > > have to be > > > >> aware that the tests will fail. > > > >> > > > >> > > > >> > > > >> _______________________________ > > > >> Do you Yahoo!? > > > >> Shop for Back-to-School deals on Yahoo! Shopping. > > > >> http://shopping.yahoo.com/backtoschool > > > >> > > > > > > > > > > > > > > > > ------------------------------------------------------- > > This SF.Net email is sponsored by: thawte's Crypto Challenge > > Vl Crack the code and win a Sony DCRHC40 MiniDV Digital > > Handycam Camcorder. More prizes in the weekly Lunch Hour Challenge. > > Sign up NOW http://ad.doubleclick.net/clk;10740251;10262165;m > > _______________________________________________ > > Springide-eclip-developer mailing list > > Spr...@li... > > https://lists.sourceforge.net/lists/listinfo/springide-eclip-developer > > > |
|
From: Loren R. <lo...@gm...> - 2004-09-14 18:59:41
|
moving over another e-mail thread. --- Torsten Juergeleit <tor...@t-...> wrote: > From: tor...@t-... (Torsten > Juergeleit) > Subject: Re: problems with latest version of Spring > IDE code > Date: Mon, 13 Sep 2004 22:32:36 +0200 > To: Loren Rosen <lor...@ya...>, > David Watkins <dav...@fa...> > > Sorry guys, I fixed the problem in BeanModel's > internal resource change > event handler (did wrong check for > 'isSpringProject()' event :-( ). > Changes are commited to CVS head. > > BTW, I created a mailing list for Spring IDE: > > https://lists.sourceforge.net/lists/subscribe/springide-eclip-developer > > Cheers, > Torsten > > > On 13.09.2004, at 18:45, Watkins, David wrote: > > > Hi Loren, > > I've been getting this with on my own (manual) > tests. Killing the > > runtime workspace and restarting it causes the > updated project to be > > seen and everything works. I think your diagnosis > is correct - it > > seems > > as if the 'add nature' action isn't updating the > BeansModel with the > > new > > project. I'd be very keen on getting the tests > checked in asap - are > > they in a separate plugin or within the existing > plugin modules? Once > > I've got the tests I'll see if I can add a fix as > it's beginning to bug > > me too! > > > > Cheers, > > dw > > > >> -----Original Message----- > >> From: Loren Rosen [mailto:lor...@ya...] > >> Sent: 13 September 2004 17:37 > >> To: Torsten Juergeleit > >> Cc: Watkins, David > >> Subject: problems with latest version of Spring > IDE code > >> > >> I've got my tests to compile and run the > springide-eclipse > >> code checked out from sourceforge. > >> This took some work to get the eclipse projects > configured, > >> but that's another story. The more immediate > problem is that > >> my tests fail. This is a regression from the > 1.0.3 release. > >> > >> The first test run is one that simply sets the > Bean project > >> nature, then unsets it. Before, after and > in-between it > >> checks that various eclipse attributes are as > they should be. > >> This test fails in the middle. > >> > >> Concretely, the test calls > >> BeansCoreUtils.addProjectNature() to add the bean > project > >> nature. Then it calls model.hasProject to check > that the > >> beans model knows about the project just added. > This check fails. > >> > >> If these test assertions are commented out, the > code then > >> calls BeansCoreUtils.removeProjectNature(), and > this gets a > >> NullPointerException, essentially for the same > reason that > >> hasProject() returns false. > >> > >> The other test failures come down to the same > cause. > >> > >> It looks as if the beans model in the newer code > is not > >> keeping things consistent with eclipse's own idea > of what > >> projects have what natures. It may be that this > code isn't > >> expected to be stable yet, but I thought you'd > want to know. > >> > >> I can check in my code now, but of course you'll > have to be > >> aware that the tests will fail. > >> > >> > >> > >> _______________________________ > >> Do you Yahoo!? > >> Shop for Back-to-School deals on Yahoo! Shopping. > >> http://shopping.yahoo.com/backtoschool > >> > > > > |
|
From: Watkins, D. <dav...@fa...> - 2004-09-14 12:59:56
|
Just 'seeding' the list!
> > With regards to the re-validate options then my refactoring=20
> stuff will=20
> > only pick up changes coming in via the refactoring actions (rename,=20
> > move etc), it doesn't pick up on direct changes to the=20
> code, however=20
> > it should be relatively simple to either add a context menu=20
> (which I=20
> > think is a bit 'clunky') or to add support for change=20
> listening in the=20
> > java editor. The only problem with the latter is the speed=20
> with which=20
> > we can process changes coming from the editor. We may need=20
> to look at=20
> > implementing localised revalidation. Anyway, I'll take a look.
>=20
> Providing a context menu to Java editor should be feasible=20
> (the AnyEdit plugin is a very good sample). For limittion the=20
> re-validation only to those config files which uses the=20
> corresponding Java type as bean class we have to extend the=20
> Bean model. I will add support for looking up config files by=20
> a given class name for the localised revalidation.=20
> Support for asking the model if a given class name is used as=20
> a bean class (and for which beans) is already available. This=20
> is used by the new version of the BeansUILabelDecorator.
>=20
> David, maybe you can investigate for a way to add a resource=20
> change listener to the Java editor and calling the=20
> revalidation in an efficient way.
>=20
> I will refactor the BeansProjectValidator that it can be used=20
> independently from the Eclipse incremental builder (which it=20
> currently implements / extends).
>=20
> > Whilst we're on the subject is there a time line for the=20
> next release.
> > If it's reasonable way off I can move over some of the=20
> non-v3 specific=20
> > stuff to the core/ui packages (mainly the search pages).
>=20
> That would be cool.
>=20
> > I'm also
> > wanting to make the core model more active via the interfaces - for=20
> > instance it'd be nice top have a option to 'search for spring files'
> > which can parse non java resources looking for the DTD=20
> signature and=20
> > add them to the config list. This woud make adopting=20
> Spring-IDE even=20
> > simpler for existing Spring users. If possible, I'd like=20
> to do this=20
> > via the interfaces rather than dropping down to the=20
> internal classes.
>=20
> We have to think about refactoring the Spring IDE model=20
> interfaces in a way the Spring Framework bean factory does.=20
> Currently we have only one interface per object. To not=20
> clutter these interfaces with stuff which is only used in=20
> rare cases we should define specialized sub-interfaces, e.g.
>=20
> interface IBeansClassAware {
> // all the bean class related methods
> boolean isBeanClass(String className)
> :
> }
>=20
> class BeansModel implements IBeansModel, IBeansClassAware {
> :
> }
>=20
> class BeansProject implements IBeansProject, IBeansClassAware {
> :
> }
>=20
> class Bean implements IBean, IBeanClassAware {
> :
> }
>=20
> So let's collect all requirements and cluster the=20
> corresponding methods into specialized interfaces.
>=20
> > Also, out of
> > interest do you and Loren think we'd be better maintainining a low=20
> > level history/changes document or are you happy to read CVS=20
> comments?
>=20
> I started to maintain a changes.txt file for every plugin.=20
> Here are all major addition / modifications are listed. Maybe=20
> we can leverage this.
>=20
> Btw. shouldn't we switch with our discussions to the mailing=20
> list=20
> (https://lists.sourceforge.net/lists/listinfo/springide-eclip-
> developer
> )? Maybe we get additional ideas from other developers=20
> through the list.
>=20
> Cheers,
> Torsten
>=20
>=20
>=20
> On 14.09.2004, at 11:35, Watkins, David wrote:
>=20
> > Torsten,
> >
> > Fantastic news! Many, many congratulations to you and Melanie. He=20
> > looks very peaceful in the photo - hope he's not keeping you up all=20
> > night!
> >
> > With regards to the re-validate options then my refactoring=20
> stuff will=20
> > only pick up changes coming in via the refactoring actions (rename,=20
> > move etc), it doesn't pick up on direct changes to the=20
> code, however=20
> > it should be relatively simple to either add a context menu=20
> (which I=20
> > think is a bit 'clunky') or to add support for change=20
> listening in the=20
> > java editor. The only problem with the latter is the speed=20
> with which=20
> > we can process changes coming from the editor. We may need=20
> to look at=20
> > implementing localised revalidation. Anyway, I'll take a look.
> >
> > Whilst we're on the subject is there a time line for the=20
> next release.
> > If it's reasonable way off I can move over some of the=20
> non-v3 specific=20
> > stuff to the core/ui packages (mainly the search pages). I'm also=20
> > wanting to make the core model more active via the interfaces - for=20
> > instance it'd be nice top have a option to 'search for spring files'
> > which can parse non java resources looking for the DTD=20
> signature and=20
> > add them to the config list. This woud make adopting=20
> Spring-IDE even=20
> > simpler for existing Spring users. If possible, I'd like=20
> to do this=20
> > via the interfaces rather than dropping down to the=20
> internal classes.
> >
> > I appreciate you've got your hands full at the moment so=20
> don't worry=20
> > if you haven't got much time to spend on the project. Also, out of=20
> > interest do you and Loren think we'd be better maintainining a low=20
> > level history/changes document or are you happy to read CVS=20
> comments?
> >
> > Anyway, congratulations once again.
> >
> > Cheers,
> > dw
> >
> >
> >> -----Original Message-----
> >> From: Torsten Juergeleit [mailto:tor...@t-...]
> >> Sent: 13 September 2004 20:26
> >> To: Loren Rosen; Watkins, David
> >> Subject: Refactoring and Spring IDE
> >>
> >> David,
> >>
> >> would the following JIRA issue be resolved with your refactoring=20
> >> support for Spring IDE?
> >>
> >> http://opensource.atlassian.com/projects/spring/browse/IDE-21
> >>
> >> Or does it make sense to add an entry to the Java editor's context=20
> >> menu for re-validating all Spring projects? Maybe we could=20
> limit the=20
> >> re-validation to the config files where the corresponding=20
> Java type=20
> >> (opened in the Java editor) is used as bean class.
> >>
> >> BTW, currently I am a little short of time for Spring IDE.
> >> This is due our first baby child was born 8 days before=20
> >> (http://www.kliniken-mtk.de/babycards/baby/C94N518N.html ).
> >>
> >> Cheers,
> >> Torsten
> >>
> >>
> >
>=20
>=20
|
1 message has been excluded from this view by a project administrator.
