Re: [Springide-eclip-developer] Fwd: Re: problems with latest version of Spring IDE code

SourceForge Headquarters 1320 Columbia Street Suite 310 San Diego, CA 92101 +1 (858) 422-6466

The regression problem turned out to be due to a bug which you fixed
yesterday. It works now.

I don't directly use the spring code in the tests, but I do need to
setup projects with the other springide plugins, and these need to
reference spring core and run with it.

The various issues with having the spring core code in a separate
plugin might be solvable, but for the moment it's not worth worrying
about.

On Thu, 16 Sep 2004 22:54:49 +0200, Torsten Juergeleit
<tor...@t-...> wrote:
> Loren,
> 
> > Figured out the problem. I succeeded in importing all the external
> > code as plug-in dependencies. This included the springframework code.
> > Problem is that one of the springide packages has a local copy of a
> > newer version of the spring-core jar. End result was I was running
> > code that tried to use a mix of springframework classes from two
> > different places.
> 
> Yes, Spring IDE's core plugin brings it's own version of Spring's core
> jar (spring-core.jar), Xerces (required for XML parser with DOM level 3
> support) and commons-logging.jar (required by spring-core.jar).
> 
> Why do you need the spring framework code?
> Aren't you creating plugins which depend on the Spring IDE plugin's? If
> yes, then you should reference the libraries which are part of Spring
> IDE's plugin (namely core with spring-core.jar and Xerces).
> 
> Or do I miss something?
> 
> > Of course eventually we'll need to replace the internal use
> > spring-code.jar with reference to the an updated version of the plugin
> > that wraps the springframework code.
> 
> The separate plugin 'org.springframework' with the Spring Framework
> core jar is not used anymore. I dropped it because it was a
> troublemaker:
> 
> - We had to tie a version of Spring IDE's core plugin with a specific
> version of this Spring Framework (core) plugin because of changing API
> in spring-core.jar (with every new release of Spring the XML
> configuration parsers internals are different). If someone has a
> different (newer or older) version of 'org.springframework' then Spring
> IDE's core isn't working anymore!!!
> 
> - I had class loader issues with spring-core.jar which needs an XML
> parser (which is part of a different plugin - Spring IDE's core). If
> spring-core.jar is part of a separate plugin then it can't "see" the
> Xerces XML parser in Spring IDE's core plugin. It "sees" only the older
> XML parser API of the Apache Crimson parser of JDK 1.4.x. But Spring
> IDE's core plugin already initialized the Xerces parser with it's new
> XML parser API (SAX2, DOM, XPATH, ...). This results in
> ClassNotFoundExceptions.
> 
> So I decided to drop supporting a separate plugin for spring-core.jar.
> It's not part of the new Spring IDE CVS repository anymore.
> 
> The Spring Framework reference documentation moved to a new plugin
> called 'org.springframework.ide.eclipse.beans.core.doc'.
> 
> > There is one less validation error than before, but
> > that's likely to be either a real bug in the new springide code or an
> > expected change in the errors the validator should generate. I'll
> > discuss that issue separately,
> 
> Could you please send a sample with the validation error which is not
> found anymore?
> This might be an issue with the refactored validator or with the new
> beans model.
> 
> Cheers,
> Torsten
> 
> 
> 
> 
> On 15.09.2004, at 23:44, Loren Rosen wrote:
> 
> > Figured out the problem. I succeeded in importing all the external
> > code as plug-in dependencies. This included the springframework code.
> > Problem is that one of the springide packages has a local copy of a
> > newer version of the spring-core jar. End result was I was running
> > code that tried to use a mix of springframework classes from two
> > different places. This caused ClassNotFound exceptions. Reports of the
> > exceptions were in the log files, but other than that simply caused
> > validation to silently fail.
> >
> > It's arguable that validation shouldn't fail silently. The fix would
> > be to put an exception handler in BeansConfig.getException. But this
> > problem shouldn't arise much in practice.
> >
> > Of course eventually we'll need to replace the internal use
> > spring-code.jar with reference to the an updated version of the plugin
> > that wraps the springframework code.
> >
> > Also, as I mentioned, I now know how to setup the eclipse projects
> > with proper plugin dependencies. Eventually I could check in my
> > modified plugin.xml files-- this will save work when upgrading to new
> > releases of eclipse.
> >
> > With the change to use the local spring-code.jar, the regression tests
> > run as expected. There is one less validation error than before, but
> > that's likely to be either a real bug in the new springide code or an
> > expected change in the errors the validator should generate. I'll
> > discuss that issue separately,
> >
> >
> >
> > On Wed, 15 Sep 2004 17:15:08 +0100, Watkins, David
> > <dav...@fa...> wrote:
> >> Loren,
> >> The problem markers are working with the code I'm using.  Are you not
> >> seeing the little red x's or is it the structure of the marker itself
> >> which is wrong.   It sounds like it's the former but if it's the
> >> second
> >> then I know Torsten changed the contents of the marker to give more
> >> information - this way we should be able to look at providing quick
> >> fix
> >> support.
> >>
> >> I've no idea what could be wrong with the CVS stuff.  I know I can
> >> check
> >> into the existing code but haven't tried creating a new top-level
> >> folder.
> >>
> >> Dw
> >>
> >>
> >>> -----Original Message-----
> >>> From: spr...@li...
> >>> [mailto:spr...@li...]
> >>>  On Behalf Of Loren Rosen
> >>> Sent: 15 September 2004 17:01
> >>> To: Spr...@li...
> >>> Subject: Re: [Springide-eclip-developer] Fwd: Re: problems
> >>> with latest version of Spring IDE code
> >>>
> >>> After updating with the latest code, the tests for adding and
> >>> removing the beans nature work. However, I can now run the
> >>> tests of the validator, and these fail. It appears that
> >>> annotations are not being made for validation errors. You can
> >>> easily confirm this manually.
> >>>
> >>> The tests are in a separate package, which is intended to be
> >>> a separate eclipse project and separate CVS module. I tried
> >>> to push them into CVS at sourceforge, but it seems I don't
> >>> have the proper permissions to do this.
> >>>
> >>>
> >>> On Wed, 15 Sep 2004 10:15:42 +0100, Watkins, David
> >>> <dav...@fa...> wrote:
> >>>> I've manually tested this from the latest head release and
> >>> it seems to
> >>>> be fixed.
> >>>>
> >>>> dw
> >>>>
> >>>>> -----Original Message-----
> >>>>> From: spr...@li...
> >>>>> [mailto:spr...@li...]
> >>>>>  On Behalf Of Loren Rosen
> >>>>> Sent: 14 September 2004 20:00
> >>>>> To: Spr...@li...
> >>>>> Subject: [Springide-eclip-developer] Fwd: Re: problems
> >>> with latest
> >>>>> version of Spring IDE code
> >>>>>
> >>>>> moving over another e-mail thread.
> >>>>>
> >>>>> --- Torsten Juergeleit <tor...@t-...> wrote:
> >>>>>
> >>>>>> From: tor...@t-... (Torsten
> >>>>>> Juergeleit)
> >>>>>> Subject: Re: problems with latest version of Spring IDE code
> >>>>>> Date: Mon, 13 Sep 2004 22:32:36 +0200
> >>>>>> To: Loren Rosen <lor...@ya...>,  David Watkins
> >>>>>> <dav...@fa...>
> >>>>>>
> >>>>>> Sorry guys, I fixed the problem in BeanModel's internal
> >>> resource
> >>>>>> change event handler (did wrong check for 'isSpringProject()'
> >>>>>> event :-( ).
> >>>>>> Changes are commited to CVS head.
> >>>>>>
> >>>>>> BTW, I created a mailing list for Spring IDE:
> >>>>>>
> >>>>>>
> >>>>>
> >>> https://lists.sourceforge.net/lists/subscribe/springide-eclip-develo
> >>>>> pe
> >>>>>> r
> >>>>>>
> >>>>>> Cheers,
> >>>>>> Torsten
> >>>>>>
> >>>>>>
> >>>>>> On 13.09.2004, at 18:45, Watkins, David wrote:
> >>>>>>
> >>>>>>> Hi Loren,
> >>>>>>> I've been getting this with on my own (manual)
> >>>>>> tests.  Killing the
> >>>>>>> runtime workspace and restarting it causes the
> >>>>>> updated project to be
> >>>>>>> seen and everything works.  I think your diagnosis
> >>>>>> is correct - it
> >>>>>>> seems
> >>>>>>> as if the 'add nature' action isn't updating the
> >>>>>> BeansModel with the
> >>>>>>> new
> >>>>>>> project.  I'd be very keen on getting the tests
> >>>>>> checked in asap - are
> >>>>>>> they in a separate plugin or within the existing
> >>>>>> plugin modules?  Once
> >>>>>>> I've got the tests I'll see if I can add a fix as
> >>>>>> it's beginning to bug
> >>>>>>> me too!
> >>>>>>>
> >>>>>>> Cheers,
> >>>>>>> dw
> >>>>>>>
> >>>>>>>> -----Original Message-----
> >>>>>>>> From: Loren Rosen [mailto:lor...@ya...]
> >>>>>>>> Sent: 13 September 2004 17:37
> >>>>>>>> To: Torsten Juergeleit
> >>>>>>>> Cc: Watkins, David
> >>>>>>>> Subject: problems with latest version of Spring
> >>>>>> IDE code
> >>>>>>>>
> >>>>>>>> I've got my tests to compile and run the
> >>>>>> springide-eclipse
> >>>>>>>> code checked out from sourceforge.
> >>>>>>>> This took some work to get the eclipse projects
> >>>>>> configured,
> >>>>>>>> but that's another story. The more immediate
> >>>>>> problem is that
> >>>>>>>> my tests fail. This is a regression from the
> >>>>>> 1.0.3 release.
> >>>>>>>>
> >>>>>>>> The first test run is one that simply sets the
> >>>>>> Bean project
> >>>>>>>> nature, then unsets it. Before, after and
> >>>>>> in-between it
> >>>>>>>> checks that various eclipse attributes are as
> >>>>>> they should be.
> >>>>>>>> This test fails in the middle.
> >>>>>>>>
> >>>>>>>> Concretely, the test calls
> >>>>>>>> BeansCoreUtils.addProjectNature() to add the bean
> >>>>>> project
> >>>>>>>> nature. Then it calls model.hasProject to check
> >>>>>> that the
> >>>>>>>> beans model knows about the project just added.
> >>>>>> This check fails.
> >>>>>>>>
> >>>>>>>> If these test assertions are commented out, the
> >>>>>> code then
> >>>>>>>> calls BeansCoreUtils.removeProjectNature(), and
> >>>>>> this gets a
> >>>>>>>> NullPointerException, essentially for the same
> >>>>>> reason that
> >>>>>>>> hasProject() returns false.
> >>>>>>>>
> >>>>>>>> The other test failures come down to the same
> >>>>>> cause.
> >>>>>>>>
> >>>>>>>> It looks as if the beans model in the newer code
> >>>>>> is not
> >>>>>>>> keeping things consistent with eclipse's own idea
> >>>>>> of what
> >>>>>>>> projects have what natures. It may be that this
> >>>>>> code isn't
> >>>>>>>> expected to be stable yet, but I thought you'd
> >>>>>> want to know.
> >>>>>>>>
> >>>>>>>> I can check in my code now, but of course you'll
> >>>>>> have to be
> >>>>>>>> aware that the tests will fail.
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>> _______________________________ Do you Yahoo!?
> >>>>>>>> Shop for Back-to-School deals on Yahoo! Shopping.
> >>>>>>>> http://shopping.yahoo.com/backtoschool
> >>>>>>>>
> >>>>>>>
> >>>>>>
> >>>>>>
> >>>>>
> >>>>>
> >>>>> -------------------------------------------------------
> >>>>> This SF.Net email is sponsored by: thawte's Crypto Challenge Vl
> >>>>> Crack the code and win a Sony DCRHC40 MiniDV Digital Handycam
> >>>>> Camcorder. More prizes in the weekly Lunch Hour Challenge.
> >>>>> Sign up NOW http://ad.doubleclick.net/clk;10740251;10262165;m
> >>>>> _______________________________________________
> >>>>> Springide-eclip-developer mailing list
> >>>>> Spr...@li...
> >>>>>
> >>> https://lists.sourceforge.net/lists/listinfo/springide-eclip-develop
> >>>>> er
> >>>>>
> >>>>
> >>>
> >>>
> >>> -------------------------------------------------------
> >>> This SF.Net email is sponsored by: thawte's Crypto Challenge
> >>> Vl Crack the code and win a Sony DCRHC40 MiniDV Digital
> >>> Handycam Camcorder. More prizes in the weekly Lunch Hour Challenge.
> >>> Sign up NOW http://ad.doubleclick.net/clk;10740251;10262165;m
> >>> _______________________________________________
> >>> Springide-eclip-developer mailing list
> >>> Spr...@li...
> >>> https://lists.sourceforge.net/lists/listinfo/springide-eclip-
> >>> developer
> >>>
> >>
> >>
> >>
> >>
> >> -------------------------------------------------------
> >> This SF.Net email is sponsored by: thawte's Crypto Challenge Vl
> >> Crack the code and win a Sony DCRHC40 MiniDV Digital Handycam
> >> Camcorder. More prizes in the weekly Lunch Hour Challenge.
> >> Sign up NOW http://ad.doubleclick.net/clk;10740251;10262165;m
> >> _______________________________________________
> >> Springide-eclip-developer mailing list
> >> Spr...@li...
> >> https://lists.sourceforge.net/lists/listinfo/springide-eclip-developer
> >>
> >
> >
> > -------------------------------------------------------
> > This SF.Net email is sponsored by: thawte's Crypto Challenge Vl
> > Crack the code and win a Sony DCRHC40 MiniDV Digital Handycam
> > Camcorder. More prizes in the weekly Lunch Hour Challenge.
> > Sign up NOW http://ad.doubleclick.net/clk;10740251;10262165;m
> > _______________________________________________
> > Springide-eclip-developer mailing list
> > Spr...@li...
> > https://lists.sourceforge.net/lists/listinfo/springide-eclip-developer
> >
> 
> -------------------------------------------------------
> This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170
> Project Admins to receive an Apple iPod Mini FREE for your judgement on
> who ports your project to Linux PPC the best. Sponsored by IBM.
> Deadline: Sept. 24. Go here: http://sf.net/ppc_contest.php
> 
> 
> _______________________________________________
> Springide-eclip-developer mailing list
> Spr...@li...
> https://lists.sourceforge.net/lists/listinfo/springide-eclip-developer
>