springframework-developer — Spring Framework developers list

Re: [Springframework-developer] unable to turn off automatic detection of all handler adaptors?

[Juergen H. <ju...@in...>]

I've just added a corresponding "detectAllHandlerAdapters" property.

Juergen
 

-----Original Message-----
From: spr...@li...
[mailto:spr...@li...] On Behalf Of
Seth Ladd
Sent: Monday, October 31, 2005 1:28 AM
To: spr...@li...
Subject: Re: [Springframework-developer] unable to turn off automatic
detection of all handler adaptors?

On 10/29/05, Juergen Hoeller <ju...@in...> wrote:
> Hi Seth,
>
> Well, I guess HandlerAdapters are practically always detected by type. 
> But point taken, for completeness, there should be the option to only 
> use a single HandlerAdapter bean of name "handlerAdapter" as well.

I agree.  While I'm not sure it's very practical, adding that functionality
does provide balance.

Thanks,
Seth


-------------------------------------------------------
This SF.Net email is sponsored by the JBoss Inc.
Get Certified Today * Register for a JBoss Training Course Free
Certification Exam for All Training Attendees Through End of 2005 Visit
http://www.jboss.com/services/certification for more information
_______________________________________________
Springframework-developer mailing list
Spr...@li...
https://lists.sourceforge.net/lists/listinfo/springframework-developer

[Springframework-developer] Spring Portlet MVC - Multipart Support

[John L. <jl...@ar...>]

The main issue with integrating Multipart support into Spring Portlet 
MVC is the need for commons-fileupload-1.1 for JSR-168 support.  I've 
talked with Juergen about this and we agree that we do not want to 
update Spring's use of commons-fileupload until some kind of release 
gets pushed out.

I (and several others) have asked the maintainers of commons-fileupload 
about their plans for a 1.1 release.  I was directed to a 20 Oct 2005 
posting from Martin Cooper on the commons-dev mailing list.  In that 
posting he states that there is no formal release plan yet, but he is 
hopeful to spend some time on it soon.  You can see the complete posting 
here:

http://www.mail-archive.com/com...@ja.../msg68563.html

Given the lack of specificity around a 1.1 release, we are going to put 
integration of Multipart support for Spring Portlet MVC on hold for 
now.  Once commons-fileupload-1.1 is released, then we will formally 
integrate it into Spring.

Until this happens, you can either use a custom version of the 
appropriate classes or utilize commons-fileupload-1.1-dev directly 
yourself.  The latter option is actually quite simple.  As an example, 
here is a simplified version of an onSubmitAction method for a 
SimpleFormController that handles a file upload:

   protected void onSubmitAction(ActionRequest request,
           ActionResponse response, Object command, BindException errors)
           throws ServletException, IOException {

       PortletRequestContext prc = new PortletRequestContext(request);
       boolean isMultiPart = FileUpload.isMultipartContent(prc);

       if (isMultiPart) {

           DiskFileItemFactory factory = new DiskFileItemFactory();
           factory.setSizeThreshold(getMaxFileSize());
               PortletFileUpload upload = new PortletFileUpload(factory);
                          try {
               List fileItems = upload.parseRequest(request);
               for (Iterator i = fileItems.iterator(); i.hasNext();) {
                   FileItem fileItem = (FileItem) i.next();
                   if (!"".equals(fileItem.getName()) && 
fileItem.getSize() > 0 ) {
                       byte array[] = new byte[(int)fileItem.getSize()];
                       fileItem.getInputStream().read(array);
                       // do something here to save the array
                       // and possibly use fileItem.getContentType()
                   }
               }
           } catch (Exception e) {
               // process any relevant exceptions
           }

       } else {
           // no file submitted
       }
   }

Please send me any feedback about this.

John Lewis

[Springframework-developer] spring build.372 Build Successful

[<al...@in...>]

View results here -> http://opensource.jteam.nl/build/buildresults/spring?log=log20051109001704Lbuild.372

[Springframework-developer] continuous builds

[Darren D. <da...@da...>]

In case anyone had even noticed that they'd stopped for a week, they're
back :)

http://springframework.sourceforge.net/test/

CVS updates are now performed prior to every build on every machine for
a more accurate and up to date integration build.

Regards,
--=20
Darren Davison
Public Key: 0xDD356B0D

[Springframework-developer] jikes

[Darren D. <da...@da...>]

Is anyone using Jikes to compile Spring?  I get the following error if I
try..

    [javac] Found 1 semantic error compiling
"/home/darren/workspace/spring/src/org/springframework/aop/interceptor/Jamo=
nPerformanceMonitorInterceptor.java":

    [javac]     20. import com.jamonapi.MonitorFactory;
    [javac]                             ^------------^
    [javac] *** Semantic Error: The class file "MonitorFactory.class" in
"/home/darren/workspace/spring/lib/jamon/JAMon.jar/com/jamonapi" has an
invalid format (ConstantValue attribute without final).


Regards,

--=20
Darren Davison
Public Key: 0xDD356B0D

Re: [Springframework-developer] Documentation update

[Colin S. <col...@ex...>]

Todd Nine wrote:

> Hi all,
>   I would like to contribute some additional documentation to section 
> 17.2.  While spring strives to eliminate EJB, I have mostly used it as 
> a tool to integrate POJO business code with the benefits or Remote 
> Stateless EJB's to utilize clustering.  I would like to elaborate on 
> the section of using a ContextSignltonBeanFactoryLocator to only cache 
> the first initialization of a BeanFactory.  What would be the fasted 
> way to get the update to you so that it can be published with the next 
> site push?
>
> Thanks,
> Todd

Todd,

Does the documentation exist? If so, you could shoot it off to me to 
merge in. We could also take a patch, but if the text is only in one 
block it will not save significant amounts of time in actually applying 
it...

Colin

Re: [Springframework-developer] AbstractPerformanceMonitorInterceptor changed for bad in 1.2.5

[Juergen H. <ju...@in...>]

Thanks for pointing this out, Marc. This has already been fixed right after
1.2.5, always having prefix/suffix to be at least empty String
(http://opensource2.atlassian.com/projects/spring/browse/SPR-1355).

The nightly 1.2.6 snapshots already contain this fix for a while. Feel free
to give it a try and let me know whether it works for you!

Juergen
 

-----Original Message-----
From: spr...@li...
[mailto:spr...@li...] On Behalf Of
Marc Logemann
Sent: Monday, October 31, 2005 8:22 PM
To: spr...@li...
Subject: [Springframework-developer] AbstractPerformanceMonitorInterceptor
changed for bad in 1.2.5

Hi,

please take a look at that stack:

java.lang.NullPointerException
	at java.lang.StringBuffer.<init>(StringBuffer.java:80)
	at
org.springframework.aop.interceptor.AbstractPerformanceMonitorInterceptor.cr
eateInvocationTraceName(AbstractPerformanceMonitorInterceptor.java:80)
	at
org.springframework.aop.interceptor.JamonPerformanceMonitorInterceptor.invok
eUnderTrace(JamonPerformanceMonitorInterceptor.java:57)
[..]


this is the related Spring config:

     <!-- =================================== -->
     <!--           AutpoProxy Creator        -->
     <!-- =================================== -->
     <bean id="proxyCreator" 
class="org.springframework.aop.framework.autoproxy.BeanNameAutoProxyCreator"
>
         <property name="beanNames">
             <list>
                 <value>loginService</value>
             </list>
         </property>
         <property name="interceptorNames">
             <list>
                 <value>JAMonInterceptor</value>
             </list>
         </property>
     </bean>

     <bean id="JAMonInterceptor" 
class="org.springframework.aop.interceptor.JamonPerformanceMonitorIntercepto
r"/>

This configuration worked for months but after upgrading to Spring 1.2.5 i
am getting the stack. The reason is quite obvious, Juergen tried to be a
good boy and used StringBuffer instead of String concatenation and
initialized it with a Prefix, but i dont have a prefix and i dont know if
its a good idea to take for granted that there is one.

See the relevant method from Spring _before_ 1.2.5

--- snipp  ---
protected String createInvocationTraceName(MethodInvocation invocation){
  String invocationData =
invocation.getMethod().getDeclaringClass().getName() + "." +
invocation.getMethod().getName();
  return getPrefix() + invocationData + getSuffix(); }
--- snapp ---

Now the current one in 1.2.5:

--- snipp ---
protected String createInvocationTraceName(MethodInvocation invocation){
  StringBuffer sb = new StringBuffer(getPrefix());
  sb.append(invocation.getMethod().getDeclaringClass().getName());
  sb.append('.').append(invocation.getMethod().getName());
  sb.append(getSuffix());
  return sb.toString();
}
--- snapp ---

So either we should intitialize the prefix property with "" or just dont use
the parametrized constructor of StringBuffer.

Tell me what you think....

Marc Logemann
http://www.logemann.org



-------------------------------------------------------
This SF.Net email is sponsored by the JBoss Inc.
Get Certified Today * Register for a JBoss Training Course Free
Certification Exam for All Training Attendees Through End of 2005 Visit
http://www.jboss.com/services/certification for more information
_______________________________________________
Springframework-developer mailing list
Spr...@li...
https://lists.sourceforge.net/lists/listinfo/springframework-developer

[Springframework-developer] FAILED BUILD: openpower-linux1 (last 30 lines included)

[Darren D. <da...@sh...>]

1131448749
FAILED
Error: JAVA_HOME is not defined correctly.
  We cannot execute java

This is an automated mail from one of the SF Compile Farm machines.  
The machine name noted in the subject encountered a failure building
or running the Spring test suite.  The last few lines of the output
were included for info.

NB: No further mail will be sent from this machine until a
successful build occurs on the machine in question.

See http://springframework.sourceforge.net/test/ for further
information.

Re: [Springframework-developer] Proposition for "controlled" copy of java bean properties

[Juergen H. <ju...@in...>]

Thanks for the suggestion, Adelino!

I've added such a "copyProperties(Object source, Object target, Class
editable)" variant to BeanUtils, although adapted into the existing
BeanUtils copyProperties implementation.

By coincidence, I have already reworked the BeanUtils copyProperties
implementation for Spring 1.2.6 already, to properly ignore properties not
found in the target class (but found in the source class), even if not
explicitly specified as "ignoreProperties".

This will be part of the next nighly 1.2.6 snapshot. Please give it a try
and let me know whether it works for you!

Juergen
 

-----Original Message-----
From: spr...@li...
[mailto:spr...@li...] On Behalf Of
Rodrigues Adelino
Sent: Tuesday, November 08, 2005 11:12 AM
To: spr...@li...
Subject: [Springframework-developer] Proposition for "controlled" copy of
java bean properties

Hi,

PROBLEM DESCRIPTION

Today BeanUtils in Spring offers the possibility to copy properties between
2 java beans:

static void copyProperties(Object source, Object target) static void
copyProperties(Object source, Object target, String[] ignoreProperties) 
 
As the instrospection does not
care about how the target variable was declared, calling such a method will
copy more properties that one wants.

To illustrate this point, let's consider the following types:

interface EditablePriceableItem {
	public int getPrice();
	public void setPrice(int val);
}


class PurchaseItem implements EditablePriceableItem {
	//... attributes
	public String getPurchaseNr() { ... }
	public void setPurchaseNr(String nr) { ... }
	public int getPrice() { ... } ;
	public void setPrice(int val) { ... };
}

class Project implements EditablePriceableItem {
	//... attributes
	public String getDescription() { ... }
	public void setDescription(String desc) { ... }
	public int getPrice() { ... } ;
	public void setPrice(int val) { ... };
}

Somewhere in a class, we have:

	EditablePriceableItem priceableSrc;
	EditablePriceableItem priceableTarget;

	//(1)
	// ...
	// priceableSrc is set by some method
	// ...
	//
	//(2)
	// priceableTarget gets instanciated
	// ...

	//(3)
	//Now I want to copy Priceable properties (and only priceable
properties !)
	//from priceableSrc to priceableTarget
	BeanUtils.copyProperties(priceableSrc,priceableTarget);

Although variables are declared as EditablePriceableItem, what gets copied
in (3) depends on the concrete type of priceableSrc and priceableTarget.

a) When priceableSrc and priceableTarget are instances of PurchaseItem,
	price and purchaseNr are copied
b) When priceableSrc and priceableTarget are instances of Project,
	price and description are copied
c) When priceableSrc is an instance of PurchaseItem and priceableTarget
    is an instance of Project (or the opposite) only price gets copied

As a conclusion the behaviour in (3) is not uniform.


PROPOSITION
To control the scope of properties that are copied, it would be very useful
to have a method such as:

static void copyProperties(Object source, Object target, Class
editableScope)

where editableScope is an interface or class that declares the properties.
Writing (3) as:

	BeanUtils.copyProperties(priceableSrc,priceableTarget,
	                         EditablePriceableItem.class);

would provide a consistent behaviour.

What do you think of this?



Regards, Adelino.

P.S.: Here attached a simple implementation of such method.


________________________________________________________________________
This e-mail has been scanned for all known viruses by EMEA.
________________________________________________________________________

[Springframework-developer] Proposition for "controlled" copy of java bean properties

[Rodrigues A. <Ade...@em...>]

Hi,

PROBLEM=20DESCRIPTION

Today=20BeanUtils=20in=20Spring=20offers=20the=20possibility=20to=20copy=20=
properties=20between
2=20java=20beans:

static=20void=20copyProperties(Object=20source,=20Object=20target)
static=20void=20copyProperties(Object=20source,=20Object=20target,=20Strin=
g[]=20ignoreProperties)=20
=20
As=20the=20instrospection=20does=20not=20
care=20about=20how=20the=20target=20variable=20was=20declared,=20calling=20=
such=20a=20method=20will
copy=20more=20properties=20that=20one=20wants.

To=20illustrate=20this=20point,=20let's=20consider=20the=20following=20typ=
es:

interface=20EditablePriceableItem=20{
=09public=20int=20getPrice();
=09public=20void=20setPrice(int=20val);
}


class=20PurchaseItem=20implements=20EditablePriceableItem=20{
=09//...=20attributes
=09public=20String=20getPurchaseNr()=20{=20...=20}
=09public=20void=20setPurchaseNr(String=20nr)=20{=20...=20}
=09public=20int=20getPrice()=20{=20...=20}=20;
=09public=20void=20setPrice(int=20val)=20{=20...=20};
}

class=20Project=20implements=20EditablePriceableItem=20{
=09//...=20attributes
=09public=20String=20getDescription()=20{=20...=20}
=09public=20void=20setDescription(String=20desc)=20{=20...=20}
=09public=20int=20getPrice()=20{=20...=20}=20;
=09public=20void=20setPrice(int=20val)=20{=20...=20};
}

Somewhere=20in=20a=20class,=20we=20have:

=09EditablePriceableItem=20priceableSrc;
=09EditablePriceableItem=20priceableTarget;

=09//(1)
=09//=20...
=09//=20priceableSrc=20is=20set=20by=20some=20method
=09//=20...
=09//
=09//(2)
=09//=20priceableTarget=20gets=20instanciated
=09//=20...

=09//(3)
=09//Now=20I=20want=20to=20copy=20Priceable=20properties=20(and=20only=20p=
riceable=20properties=20!)
=09//from=20priceableSrc=20to=20priceableTarget
=09BeanUtils.copyProperties(priceableSrc,priceableTarget);

Although=20variables=20are=20declared=20as=20EditablePriceableItem,=20what=
=20gets=20copied=20in=20(3)
depends=20on=20the=20concrete=20type=20of=20priceableSrc=20and=20priceable=
Target.

a)=20When=20priceableSrc=20and=20priceableTarget=20are=20instances=20of=20=
PurchaseItem,
=09price=20and=20purchaseNr=20are=20copied
b)=20When=20priceableSrc=20and=20priceableTarget=20are=20instances=20of=20=
Project,
=09price=20and=20description=20are=20copied
c)=20When=20priceableSrc=20is=20an=20instance=20of=20PurchaseItem=20and=20=
priceableTarget
=20=20=20=20is=20an=20instance=20of=20Project=20(or=20the=20opposite)=20on=
ly=20price=20gets=20copied

As=20a=20conclusion=20the=20behaviour=20in=20(3)=20is=20not=20uniform.


PROPOSITION
To=20control=20the=20scope=20of=20properties=20that=20are=20copied,=20it=20=
would=20be=20very=20useful
to=20have=20a=20method=20such=20as:

static=20void=20copyProperties(Object=20source,=20Object=20target,=20Class=
=20editableScope)

where=20editableScope=20is=20an=20interface=20or=20class=20that=20declares=
=20the=20properties.
Writing=20(3)=20as:

=09BeanUtils.copyProperties(priceableSrc,priceableTarget,
=09=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20EditablePriceableItem.class);

would=20provide=20a=20consistent=20behaviour.

What=20do=20you=20think=20of=20this?



Regards,=20Adelino.

P.S.:=20Here=20attached=20a=20simple=20implementation=20of=20such=20method=
.


________________________________________________________________________
This=20e-mail=20has=20been=20scanned=20for=20all=20known=20viruses=20by=20=
EMEA.
________________________________________________________________________

Re: [Springframework-developer] Re: [PATCH 3/3]: Remove questionable casts

[Juergen H. <ju...@in...>]

Thanks for spotting those too, Chris! Indeed, those can be replaced by array
access. Of course, those are all just in the test suite anyway... ;-)

Juergen


-----Original Message-----
From: spr...@li...
[mailto:spr...@li...] On Behalf Of
Chris Tilden
Sent: Tuesday, November 08, 2005 1:14 AM
To: Spring Framework Developer List
Subject: [Springframework-developer] Re: [PATCH 3/3]: Remove questionable
casts

http://opensource2.atlassian.com/projects/spring/browse/SPR-1451

On 11/7/05, Chris Tilden <chr...@gm...> wrote:
> removed questionable casts
>
>
>


-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. Download
it for free - -and be entered to win a 42" plasma tv or your very own
Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php
_______________________________________________
Springframework-developer mailing list
Spr...@li...
https://lists.sourceforge.net/lists/listinfo/springframework-developer

Re: [Springframework-developer] [PATCH 1/3]: Fix new Boolean

[Juergen H. <ju...@in...>]

Indeed, that's the main reason why use the Boolean constructors. I consider
that acceptable for 1.3 compatibility, even without explicit 1.4/1.3
fallback.

I've fixed the "new String(...)" usages, where appropriate. The only ones
passing in Strings into the constructor where in the test suite, though.

In any case, thanks for pointing those out, Chris!

Juergen
 

-----Original Message-----
From: spr...@li...
[mailto:spr...@li...] On Behalf Of
Guillaume Poirier
Sent: Tuesday, November 08, 2005 1:43 AM
To: spr...@li...
Subject: Re: [Springframework-developer] [PATCH 1/3]: Fix new Boolean

Boolean.valueOf() is indeed the better form, but the method is only
avalaible since J2SE 1.4, and AFAIK, Spring is 1.3 compatible, that means
that method cannot be used without having a fallback for 1.3.

Guillaume

Chris Tilden wrote:

>usage of Boolean constructor is not recommended:
>     switched to use Boolean.valueOf() instead
>  
>
>-----------------------------------------------------------------------
>-
>
>  
> ----------------------------------------------------------------------
>  r79:  chris | 2005-10-31 16:33:39 -0800
>  
>  branch for new Boolean fix
>  
> ----------------------------------------------------------------------
>  r80:  chris | 2005-10-31 16:35:04 -0800
>  
>  usage of Boolean constructor is not recommended:
>     switched to use Boolean.valueOf() instead
>  
> ----------------------------------------------------------------------
>
>
samples/countries/src/org/springframework/samples/countries/web/CountriesExc
elView.java |    4 ++--
>
samples/countries/src/org/springframework/samples/countries/web/CountriesPdf
View.java   |    4 ++--
> src/org/springframework/aop/framework/Cglib2AopProxy.java
|    2 +-
> src/org/springframework/core/style/ToStringCreator.java
|    2 +-
> src/org/springframework/jdbc/datasource/LazyConnectionDataSourceProxy.java
|    6 +++---
> src/org/springframework/jdbc/support/lob/OracleLobHandler.java
|    2 +-
> src/org/springframework/orm/hibernate/HibernateTemplate.java
|    2 +-
> src/org/springframework/orm/hibernate3/HibernateTemplate.java
|    2 +-
> src/org/springframework/remoting/jaxrpc/JaxRpcPortClientInterceptor.java
|    4 ++--
> src/org/springframework/web/servlet/tags/HtmlEscapingAwareTag.java
|    2 +-
> test/org/springframework/jdbc/object/SqlUpdateTests.java
|    4 ++--
>
test/org/springframework/jdbc/support/rowset/ResultSetWrappingRowSetTests.ja
va          |    4 ++--
> test/org/springframework/util/comparator/ComparatorTests.java
|    4 ++--
> test/org/springframework/web/util/ExpressionEvaluationUtilsTests.java
|    2 +-
> 14 files changed, 22 insertions(+), 22 deletions(-)
>
>=== 
>spring-nightly/samples/countries/src/org/springframework/samples/countr
>ies/web/CountriesExcelView.java 
>==================================================================
>---
spring-nightly/samples/countries/src/org/springframework/samples/countries/w
eb/CountriesExcelView.java	(revision 79)
>+++
spring-nightly/samples/countries/src/org/springframework/samples/countries/w
eb/CountriesExcelView.java	(local)
>@@ -113,12 +113,12 @@
> 		row++;
> 
> 		getCell(sheet, row,
0).setCellValue(getMessageSourceAccessor().getMessage("sort.asc"));
>-		getCell(sheet, row,
1).setCellValue(getMessageSourceAccessor().getMessage(new
Boolean(sort.isAscending()).toString()));
>+		getCell(sheet, row, 
>+1).setCellValue(getMessageSourceAccessor().getMessage(Boolean.valueOf(
>+sort.isAscending()).toString()));
> 		getCell(sheet, row, 1).setCellStyle(csp);
> 		row++;
> 
> 		getCell(sheet, row,
0).setCellValue(getMessageSourceAccessor().getMessage("sort.igncase"));
>-		getCell(sheet, row,
1).setCellValue(getMessageSourceAccessor().getMessage(new
Boolean(sort.isIgnoreCase()).toString()));
>+		getCell(sheet, row, 
>+1).setCellValue(getMessageSourceAccessor().getMessage(Boolean.valueOf(
>+sort.isIgnoreCase()).toString()));
> 		getCell(sheet, row, 1).setCellStyle(csp);
> 		row++;
> 
>=== 
>spring-nightly/samples/countries/src/org/springframework/samples/countr
>ies/web/CountriesPdfView.java 
>==================================================================
>---
spring-nightly/samples/countries/src/org/springframework/samples/countries/w
eb/CountriesPdfView.java	(revision 79)
>+++
spring-nightly/samples/countries/src/org/springframework/samples/countries/w
eb/CountriesPdfView.java	(local)
>@@ -119,13 +119,13 @@
> 
> 		cell = new PdfPCell(new
Phrase(getMessageSourceAccessor().getMessage( "sort.asc"), HEADING_FONT));
> 		table.addCell(cell);
>-		cell = new PdfPCell(new
Phrase(getMessageSourceAccessor().getMessage(new
Boolean(sort.isAscending()).toString()),
>+		cell = new PdfPCell(new 
>+Phrase(getMessageSourceAccessor().getMessage(Boolean.valueOf(sort.isAs
>+cending()).toString()),
> 				HEADING_DATA_FONT));
> 		table.addCell(cell);
> 
> 		cell = new PdfPCell(new
Phrase(getMessageSourceAccessor().getMessage( "sort.igncase"),
HEADING_FONT));
> 		table.addCell(cell);
>-		cell = new PdfPCell(new
Phrase(getMessageSourceAccessor().getMessage(new
Boolean(sort.isIgnoreCase()).toString()),
>+		cell = new PdfPCell(new 
>+Phrase(getMessageSourceAccessor().getMessage(Boolean.valueOf(sort.isIg
>+noreCase()).toString()),
> 				HEADING_DATA_FONT));
> 		table.addCell(cell);
> 
>=== 
>spring-nightly/src/org/springframework/aop/framework/Cglib2AopProxy.jav
>a ==================================================================
>---
spring-nightly/src/org/springframework/aop/framework/Cglib2AopProxy.java
(revision 79)
>+++
spring-nightly/src/org/springframework/aop/framework/Cglib2AopProxy.java
(local)
>@@ -549,7 +549,7 @@
> 				return Boolean.FALSE;
> 			}
> 
>-			return new
Boolean(AopProxyUtils.equalsInProxy(this.advised, otherAdvised));
>+			return
Boolean.valueOf(AopProxyUtils.equalsInProxy(this.advised, 
>+otherAdvised));
> 		}
> 	}
> 
>=== 
>spring-nightly/src/org/springframework/core/style/ToStringCreator.java
>==================================================================
>--- spring-nightly/src/org/springframework/core/style/ToStringCreator.java
(revision 79)
>+++ spring-nightly/src/org/springframework/core/style/ToStringCreator.java
(local)
>@@ -142,7 +142,7 @@
> 	 * @return this, to support call-chaining
> 	 */
> 	public ToStringCreator append(String fieldName, boolean value) {
>-		return append(fieldName, new Boolean(value));
>+		return append(fieldName, Boolean.valueOf(value));
> 	}
> 
> 	/**
>=== 
>spring-nightly/src/org/springframework/jdbc/datasource/LazyConnectionDa
>taSourceProxy.java 
>==================================================================
>---
spring-nightly/src/org/springframework/jdbc/datasource/LazyConnectionDataSou
rceProxy.java	(revision 79)
>+++
spring-nightly/src/org/springframework/jdbc/datasource/LazyConnectionDataSou
rceProxy.java	(local)
>@@ -112,7 +112,7 @@
> 	 * @see java.sql.Connection#getAutoCommit
> 	 */
> 	public void setDefaultAutoCommit(boolean defaultAutoCommit) {
>-		this.defaultAutoCommit = new Boolean(defaultAutoCommit);
>+		this.defaultAutoCommit = Boolean.valueOf(defaultAutoCommit);
> 	}
> 
> 	/**
>@@ -160,7 +160,7 @@
> 	 */
> 	protected synchronized void
checkDefaultConnectionProperties(Connection con) throws SQLException {
> 		if (this.defaultAutoCommit == null) {
>-			this.defaultAutoCommit = new
Boolean(con.getAutoCommit());
>+			this.defaultAutoCommit =
Boolean.valueOf(con.getAutoCommit());
> 		}
> 		if (this.defaultTransactionIsolation == null) {
> 			this.defaultTransactionIsolation = new 
>Integer(con.getTransactionIsolation());
>@@ -317,7 +317,7 @@
> 					return null;
> 				}
> 				else if
(method.getName().equals("isClosed")) {
>-					return new Boolean(this.closed);
>+					return Boolean.valueOf(this.closed);
> 				}
> 				else if (method.getName().equals("close")) {
> 					// Ignore: no target connection yet.
>=== 
>spring-nightly/src/org/springframework/jdbc/support/lob/OracleLobHandle
>r.java 
>==================================================================
>---
spring-nightly/src/org/springframework/jdbc/support/lob/OracleLobHandler.jav
a	(revision 79)
>+++
spring-nightly/src/org/springframework/jdbc/support/lob/OracleLobHandler.jav
a	(local)
>@@ -160,7 +160,7 @@
> 	 * @see oracle.sql.CLOB#createTemporary
> 	 */
> 	public void setCache(boolean cache) {
>-		this.cache = new Boolean(cache);
>+		this.cache = Boolean.valueOf(cache);
> 	}
> 
> 
>=== 
>spring-nightly/src/org/springframework/orm/hibernate/HibernateTemplate.
>java ==================================================================
>---
spring-nightly/src/org/springframework/orm/hibernate/HibernateTemplate.java
(revision 79)
>+++
spring-nightly/src/org/springframework/orm/hibernate/HibernateTemplate.java
(local)
>@@ -508,7 +508,7 @@
> 	public boolean contains(final Object entity) throws
DataAccessException {
> 		Boolean result = (Boolean) execute(new HibernateCallback() {
> 			public Object doInHibernate(Session session) {
>-				return new
Boolean(session.contains(entity));
>+				return
Boolean.valueOf(session.contains(entity));
> 			}
> 		}, true);
> 		return result.booleanValue();
>=== 
>spring-nightly/src/org/springframework/orm/hibernate3/HibernateTemplate
>.java 
>==================================================================
>---
spring-nightly/src/org/springframework/orm/hibernate3/HibernateTemplate.java
(revision 79)
>+++
spring-nightly/src/org/springframework/orm/hibernate3/HibernateTemplate.java
(local)
>@@ -549,7 +549,7 @@
> 	public boolean contains(final Object entity) throws
DataAccessException {
> 		Boolean result = (Boolean) execute(new HibernateCallback() {
> 			public Object doInHibernate(Session session) {
>-				return new
Boolean(session.contains(entity));
>+				return
Boolean.valueOf(session.contains(entity));
> 			}
> 		}, true);
> 		return result.booleanValue();
>=== 
>spring-nightly/src/org/springframework/remoting/jaxrpc/JaxRpcPortClient
>Interceptor.java 
>==================================================================
>---
spring-nightly/src/org/springframework/remoting/jaxrpc/JaxRpcPortClientInter
ceptor.java	(revision 79)
>+++
spring-nightly/src/org/springframework/remoting/jaxrpc/JaxRpcPortClientInter
ceptor.java	(local)
>@@ -416,7 +416,7 @@
> 			stub._setProperty(Stub.ENDPOINT_ADDRESS_PROPERTY,
this.endpointAddress);
> 		}
> 		if (this.maintainSession) {
>-			stub._setProperty(Stub.SESSION_MAINTAIN_PROPERTY,
new Boolean(this.maintainSession));
>+			stub._setProperty(Stub.SESSION_MAINTAIN_PROPERTY, 
>+Boolean.valueOf(this.maintainSession));
> 		}
> 		if (this.customProperties != null) {
> 			Enumeration en =
this.customProperties.propertyNames();
>@@ -572,7 +572,7 @@
> 			call.setTargetEndpointAddress(this.endpointAddress);
> 		}
> 		if (this.maintainSession) {
>-			call.setProperty(Call.SESSION_MAINTAIN_PROPERTY, new
Boolean(this.maintainSession));
>+			call.setProperty(Call.SESSION_MAINTAIN_PROPERTY, 
>+Boolean.valueOf(this.maintainSession));
> 		}
> 		if (this.customProperties != null) {
> 			Enumeration en =
this.customProperties.propertyNames();
>=== 
>spring-nightly/src/org/springframework/web/servlet/tags/HtmlEscapingAwa
>reTag.java 
>==================================================================
>---
spring-nightly/src/org/springframework/web/servlet/tags/HtmlEscapingAwareTag
.java	(revision 79)
>+++
spring-nightly/src/org/springframework/web/servlet/tags/HtmlEscapingAwareTag
.java	(local)
>@@ -46,7 +46,7 @@
> 	 */
> 	public void setHtmlEscape(String htmlEscape) throws JspException {
> 		this.htmlEscape =
>-				new
Boolean(ExpressionEvaluationUtils.evaluateBoolean("htmlEscape", htmlEscape,
pageContext));
>+				
>+Boolean.valueOf(ExpressionEvaluationUtils.evaluateBoolean("htmlEscape"
>+, htmlEscape, pageContext));
> 	}
> 
> 	/**
>=== 
>spring-nightly/test/org/springframework/jdbc/object/SqlUpdateTests.java
>==================================================================
>--- spring-nightly/test/org/springframework/jdbc/object/SqlUpdateTests.java
(revision 79)
>+++ spring-nightly/test/org/springframework/jdbc/object/SqlUpdateTests.java
(local)
>@@ -432,7 +432,7 @@
> 		public int run(int performanceId, int type, String name,
boolean confirmed) {
> 			Object[] params =
> 				new Object[] {new Integer(performanceId),
new Integer(type), name,
>-
new Boolean(confirmed)};
>+
Boolean.valueOf(confirmed)};
> 			return update(params);
> 		}
> 	}
>@@ -466,7 +466,7 @@
> 		public int run(int performanceId, int type, String name,
boolean confirmed) {
> 			Object[] params =
> 				new Object[] {
>-					new Integer(performanceId), new
Integer(type), name, new Boolean(confirmed)};
>+					new Integer(performanceId), new
Integer(type), name, 
>+Boolean.valueOf(confirmed)};
> 			return update(params);
> 		}
> 	}
>=== 
>spring-nightly/test/org/springframework/jdbc/support/rowset/ResultSetWr
>appingRowSetTests.java 
>==================================================================
>---
spring-nightly/test/org/springframework/jdbc/support/rowset/ResultSetWrappin
gRowSetTests.java	(revision 79)
>+++
spring-nightly/test/org/springframework/jdbc/support/rowset/ResultSetWrappin
gRowSetTests.java	(local)
>@@ -173,13 +173,13 @@
> 	public void testGetBooleanInt() throws Exception {
> 		Method rset =
ResultSet.class.getDeclaredMethod("getBoolean", new Class[] {int.class});
> 		Method rowset =
ResultSetWrappingSqlRowSet.class.getDeclaredMethod("getBoolean", new Class[]
{int.class});
>-		doTest(rset, rowset, new Integer(1), new Boolean(true));
>+		doTest(rset, rowset, new Integer(1), Boolean.valueOf(true));
> 	}
> 
> 	public void testGetBooleanString() throws Exception {
> 		Method rset =
ResultSet.class.getDeclaredMethod("getBoolean", new Class[] {String.class});
> 		Method rowset =
ResultSetWrappingSqlRowSet.class.getDeclaredMethod("getBoolean", new Class[]
{String.class});
>-		doTest(rset, rowset, "test", new Boolean(true));
>+		doTest(rset, rowset, "test", Boolean.valueOf(true));
> 	}
> 
> 	private void doTest(Method rsetMethod, Method rowsetMethod, Object 
>arg, Object ret) throws Exception { === 
>spring-nightly/test/org/springframework/util/comparator/ComparatorTests
>.java 
>==================================================================
>---
spring-nightly/test/org/springframework/util/comparator/ComparatorTests.java
(revision 79)
>+++
spring-nightly/test/org/springframework/util/comparator/ComparatorTests.java
(local)
>@@ -49,12 +49,12 @@
> 
> 	public void testBooleanComparatorTrueLow() {
> 		Comparator c = BooleanComparator.TRUE_LOW;
>-		assertTrue(c.compare(new Boolean(true), new Boolean(false))
< 0);
>+		assertTrue(c.compare(Boolean.valueOf(true),
Boolean.valueOf(false)) 
>+< 0);
> 	}
> 
> 	public void testBooleanComparatorTrueHigh() {
> 		Comparator c = BooleanComparator.TRUE_HIGH;
>-		assertTrue(c.compare(new Boolean(true), new Boolean(false))
> 0);
>+		assertTrue(c.compare(Boolean.valueOf(true),
Boolean.valueOf(false)) 
>+> 0);
> 		assertTrue(c.compare(Boolean.TRUE, Boolean.TRUE) == 0);
> 	}
> 
>=== 
>spring-nightly/test/org/springframework/web/util/ExpressionEvaluationUt
>ilsTests.java 
>==================================================================
>---
spring-nightly/test/org/springframework/web/util/ExpressionEvaluationUtilsTe
sts.java	(revision 79)
>+++
spring-nightly/test/org/springframework/web/util/ExpressionEvaluationUtilsTe
sts.java	(local)
>@@ -87,7 +87,7 @@
> 	public void testEvaluateBoolean() throws Exception {
> 		PageContext ctx = new MockPageContext();
> 		
>-		ctx.setAttribute("bla", new Boolean(true));
>+		ctx.setAttribute("bla", Boolean.valueOf(true));
> 		String expr = "${bla}";
> 		
> 		boolean b =
ExpressionEvaluationUtils.evaluateBoolean("test", expr, 
> ctx);
>
>  
>


-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. Download
it for free - -and be entered to win a 42" plasma tv or your very own
Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php
_______________________________________________
Springframework-developer mailing list
Spr...@li...
https://lists.sourceforge.net/lists/listinfo/springframework-developer

Re: [Springframework-developer] [PATCH 1/3]: Fix new Boolean

[Guillaume P. <gpo...@sy...>]

Boolean.valueOf() is indeed the better form, but the method is only 
avalaible since J2SE 1.4, and AFAIK, Spring is 1.3 compatible, that 
means that method cannot be used without having a fallback for 1.3.

Guillaume

Chris Tilden wrote:

>usage of Boolean constructor is not recommended:
>     switched to use Boolean.valueOf() instead
>  
>
>------------------------------------------------------------------------
>
>  ----------------------------------------------------------------------
>  r79:  chris | 2005-10-31 16:33:39 -0800
>  
>  branch for new Boolean fix
>  ----------------------------------------------------------------------
>  r80:  chris | 2005-10-31 16:35:04 -0800
>  
>  usage of Boolean constructor is not recommended:
>     switched to use Boolean.valueOf() instead
>  ----------------------------------------------------------------------
>
> samples/countries/src/org/springframework/samples/countries/web/CountriesExcelView.java |    4 ++--
> samples/countries/src/org/springframework/samples/countries/web/CountriesPdfView.java   |    4 ++--
> src/org/springframework/aop/framework/Cglib2AopProxy.java                               |    2 +-
> src/org/springframework/core/style/ToStringCreator.java                                 |    2 +-
> src/org/springframework/jdbc/datasource/LazyConnectionDataSourceProxy.java              |    6 +++---
> src/org/springframework/jdbc/support/lob/OracleLobHandler.java                          |    2 +-
> src/org/springframework/orm/hibernate/HibernateTemplate.java                            |    2 +-
> src/org/springframework/orm/hibernate3/HibernateTemplate.java                           |    2 +-
> src/org/springframework/remoting/jaxrpc/JaxRpcPortClientInterceptor.java                |    4 ++--
> src/org/springframework/web/servlet/tags/HtmlEscapingAwareTag.java                      |    2 +-
> test/org/springframework/jdbc/object/SqlUpdateTests.java                                |    4 ++--
> test/org/springframework/jdbc/support/rowset/ResultSetWrappingRowSetTests.java          |    4 ++--
> test/org/springframework/util/comparator/ComparatorTests.java                           |    4 ++--
> test/org/springframework/web/util/ExpressionEvaluationUtilsTests.java                   |    2 +-
> 14 files changed, 22 insertions(+), 22 deletions(-)
>
>=== spring-nightly/samples/countries/src/org/springframework/samples/countries/web/CountriesExcelView.java
>==================================================================
>--- spring-nightly/samples/countries/src/org/springframework/samples/countries/web/CountriesExcelView.java	(revision 79)
>+++ spring-nightly/samples/countries/src/org/springframework/samples/countries/web/CountriesExcelView.java	(local)
>@@ -113,12 +113,12 @@
> 		row++;
> 
> 		getCell(sheet, row, 0).setCellValue(getMessageSourceAccessor().getMessage("sort.asc"));
>-		getCell(sheet, row, 1).setCellValue(getMessageSourceAccessor().getMessage(new Boolean(sort.isAscending()).toString()));
>+		getCell(sheet, row, 1).setCellValue(getMessageSourceAccessor().getMessage(Boolean.valueOf(sort.isAscending()).toString()));
> 		getCell(sheet, row, 1).setCellStyle(csp);
> 		row++;
> 
> 		getCell(sheet, row, 0).setCellValue(getMessageSourceAccessor().getMessage("sort.igncase"));
>-		getCell(sheet, row, 1).setCellValue(getMessageSourceAccessor().getMessage(new Boolean(sort.isIgnoreCase()).toString()));
>+		getCell(sheet, row, 1).setCellValue(getMessageSourceAccessor().getMessage(Boolean.valueOf(sort.isIgnoreCase()).toString()));
> 		getCell(sheet, row, 1).setCellStyle(csp);
> 		row++;
> 
>=== spring-nightly/samples/countries/src/org/springframework/samples/countries/web/CountriesPdfView.java
>==================================================================
>--- spring-nightly/samples/countries/src/org/springframework/samples/countries/web/CountriesPdfView.java	(revision 79)
>+++ spring-nightly/samples/countries/src/org/springframework/samples/countries/web/CountriesPdfView.java	(local)
>@@ -119,13 +119,13 @@
> 
> 		cell = new PdfPCell(new Phrase(getMessageSourceAccessor().getMessage( "sort.asc"), HEADING_FONT));
> 		table.addCell(cell);
>-		cell = new PdfPCell(new Phrase(getMessageSourceAccessor().getMessage(new Boolean(sort.isAscending()).toString()),
>+		cell = new PdfPCell(new Phrase(getMessageSourceAccessor().getMessage(Boolean.valueOf(sort.isAscending()).toString()),
> 				HEADING_DATA_FONT));
> 		table.addCell(cell);
> 
> 		cell = new PdfPCell(new Phrase(getMessageSourceAccessor().getMessage( "sort.igncase"), HEADING_FONT));
> 		table.addCell(cell);
>-		cell = new PdfPCell(new Phrase(getMessageSourceAccessor().getMessage(new Boolean(sort.isIgnoreCase()).toString()),
>+		cell = new PdfPCell(new Phrase(getMessageSourceAccessor().getMessage(Boolean.valueOf(sort.isIgnoreCase()).toString()),
> 				HEADING_DATA_FONT));
> 		table.addCell(cell);
> 
>=== spring-nightly/src/org/springframework/aop/framework/Cglib2AopProxy.java
>==================================================================
>--- spring-nightly/src/org/springframework/aop/framework/Cglib2AopProxy.java	(revision 79)
>+++ spring-nightly/src/org/springframework/aop/framework/Cglib2AopProxy.java	(local)
>@@ -549,7 +549,7 @@
> 				return Boolean.FALSE;
> 			}
> 
>-			return new Boolean(AopProxyUtils.equalsInProxy(this.advised, otherAdvised));
>+			return Boolean.valueOf(AopProxyUtils.equalsInProxy(this.advised, otherAdvised));
> 		}
> 	}
> 
>=== spring-nightly/src/org/springframework/core/style/ToStringCreator.java
>==================================================================
>--- spring-nightly/src/org/springframework/core/style/ToStringCreator.java	(revision 79)
>+++ spring-nightly/src/org/springframework/core/style/ToStringCreator.java	(local)
>@@ -142,7 +142,7 @@
> 	 * @return this, to support call-chaining
> 	 */
> 	public ToStringCreator append(String fieldName, boolean value) {
>-		return append(fieldName, new Boolean(value));
>+		return append(fieldName, Boolean.valueOf(value));
> 	}
> 
> 	/**
>=== spring-nightly/src/org/springframework/jdbc/datasource/LazyConnectionDataSourceProxy.java
>==================================================================
>--- spring-nightly/src/org/springframework/jdbc/datasource/LazyConnectionDataSourceProxy.java	(revision 79)
>+++ spring-nightly/src/org/springframework/jdbc/datasource/LazyConnectionDataSourceProxy.java	(local)
>@@ -112,7 +112,7 @@
> 	 * @see java.sql.Connection#getAutoCommit
> 	 */
> 	public void setDefaultAutoCommit(boolean defaultAutoCommit) {
>-		this.defaultAutoCommit = new Boolean(defaultAutoCommit);
>+		this.defaultAutoCommit = Boolean.valueOf(defaultAutoCommit);
> 	}
> 
> 	/**
>@@ -160,7 +160,7 @@
> 	 */
> 	protected synchronized void checkDefaultConnectionProperties(Connection con) throws SQLException {
> 		if (this.defaultAutoCommit == null) {
>-			this.defaultAutoCommit = new Boolean(con.getAutoCommit());
>+			this.defaultAutoCommit = Boolean.valueOf(con.getAutoCommit());
> 		}
> 		if (this.defaultTransactionIsolation == null) {
> 			this.defaultTransactionIsolation = new Integer(con.getTransactionIsolation());
>@@ -317,7 +317,7 @@
> 					return null;
> 				}
> 				else if (method.getName().equals("isClosed")) {
>-					return new Boolean(this.closed);
>+					return Boolean.valueOf(this.closed);
> 				}
> 				else if (method.getName().equals("close")) {
> 					// Ignore: no target connection yet.
>=== spring-nightly/src/org/springframework/jdbc/support/lob/OracleLobHandler.java
>==================================================================
>--- spring-nightly/src/org/springframework/jdbc/support/lob/OracleLobHandler.java	(revision 79)
>+++ spring-nightly/src/org/springframework/jdbc/support/lob/OracleLobHandler.java	(local)
>@@ -160,7 +160,7 @@
> 	 * @see oracle.sql.CLOB#createTemporary
> 	 */
> 	public void setCache(boolean cache) {
>-		this.cache = new Boolean(cache);
>+		this.cache = Boolean.valueOf(cache);
> 	}
> 
> 
>=== spring-nightly/src/org/springframework/orm/hibernate/HibernateTemplate.java
>==================================================================
>--- spring-nightly/src/org/springframework/orm/hibernate/HibernateTemplate.java	(revision 79)
>+++ spring-nightly/src/org/springframework/orm/hibernate/HibernateTemplate.java	(local)
>@@ -508,7 +508,7 @@
> 	public boolean contains(final Object entity) throws DataAccessException {
> 		Boolean result = (Boolean) execute(new HibernateCallback() {
> 			public Object doInHibernate(Session session) {
>-				return new Boolean(session.contains(entity));
>+				return Boolean.valueOf(session.contains(entity));
> 			}
> 		}, true);
> 		return result.booleanValue();
>=== spring-nightly/src/org/springframework/orm/hibernate3/HibernateTemplate.java
>==================================================================
>--- spring-nightly/src/org/springframework/orm/hibernate3/HibernateTemplate.java	(revision 79)
>+++ spring-nightly/src/org/springframework/orm/hibernate3/HibernateTemplate.java	(local)
>@@ -549,7 +549,7 @@
> 	public boolean contains(final Object entity) throws DataAccessException {
> 		Boolean result = (Boolean) execute(new HibernateCallback() {
> 			public Object doInHibernate(Session session) {
>-				return new Boolean(session.contains(entity));
>+				return Boolean.valueOf(session.contains(entity));
> 			}
> 		}, true);
> 		return result.booleanValue();
>=== spring-nightly/src/org/springframework/remoting/jaxrpc/JaxRpcPortClientInterceptor.java
>==================================================================
>--- spring-nightly/src/org/springframework/remoting/jaxrpc/JaxRpcPortClientInterceptor.java	(revision 79)
>+++ spring-nightly/src/org/springframework/remoting/jaxrpc/JaxRpcPortClientInterceptor.java	(local)
>@@ -416,7 +416,7 @@
> 			stub._setProperty(Stub.ENDPOINT_ADDRESS_PROPERTY, this.endpointAddress);
> 		}
> 		if (this.maintainSession) {
>-			stub._setProperty(Stub.SESSION_MAINTAIN_PROPERTY, new Boolean(this.maintainSession));
>+			stub._setProperty(Stub.SESSION_MAINTAIN_PROPERTY, Boolean.valueOf(this.maintainSession));
> 		}
> 		if (this.customProperties != null) {
> 			Enumeration en = this.customProperties.propertyNames();
>@@ -572,7 +572,7 @@
> 			call.setTargetEndpointAddress(this.endpointAddress);
> 		}
> 		if (this.maintainSession) {
>-			call.setProperty(Call.SESSION_MAINTAIN_PROPERTY, new Boolean(this.maintainSession));
>+			call.setProperty(Call.SESSION_MAINTAIN_PROPERTY, Boolean.valueOf(this.maintainSession));
> 		}
> 		if (this.customProperties != null) {
> 			Enumeration en = this.customProperties.propertyNames();
>=== spring-nightly/src/org/springframework/web/servlet/tags/HtmlEscapingAwareTag.java
>==================================================================
>--- spring-nightly/src/org/springframework/web/servlet/tags/HtmlEscapingAwareTag.java	(revision 79)
>+++ spring-nightly/src/org/springframework/web/servlet/tags/HtmlEscapingAwareTag.java	(local)
>@@ -46,7 +46,7 @@
> 	 */
> 	public void setHtmlEscape(String htmlEscape) throws JspException {
> 		this.htmlEscape =
>-				new Boolean(ExpressionEvaluationUtils.evaluateBoolean("htmlEscape", htmlEscape, pageContext));
>+				Boolean.valueOf(ExpressionEvaluationUtils.evaluateBoolean("htmlEscape", htmlEscape, pageContext));
> 	}
> 
> 	/**
>=== spring-nightly/test/org/springframework/jdbc/object/SqlUpdateTests.java
>==================================================================
>--- spring-nightly/test/org/springframework/jdbc/object/SqlUpdateTests.java	(revision 79)
>+++ spring-nightly/test/org/springframework/jdbc/object/SqlUpdateTests.java	(local)
>@@ -432,7 +432,7 @@
> 		public int run(int performanceId, int type, String name, boolean confirmed) {
> 			Object[] params =
> 				new Object[] {new Integer(performanceId), new Integer(type), name,
>-											new Boolean(confirmed)};
>+											Boolean.valueOf(confirmed)};
> 			return update(params);
> 		}
> 	}
>@@ -466,7 +466,7 @@
> 		public int run(int performanceId, int type, String name, boolean confirmed) {
> 			Object[] params =
> 				new Object[] {
>-					new Integer(performanceId), new Integer(type), name, new Boolean(confirmed)};
>+					new Integer(performanceId), new Integer(type), name, Boolean.valueOf(confirmed)};
> 			return update(params);
> 		}
> 	}
>=== spring-nightly/test/org/springframework/jdbc/support/rowset/ResultSetWrappingRowSetTests.java
>==================================================================
>--- spring-nightly/test/org/springframework/jdbc/support/rowset/ResultSetWrappingRowSetTests.java	(revision 79)
>+++ spring-nightly/test/org/springframework/jdbc/support/rowset/ResultSetWrappingRowSetTests.java	(local)
>@@ -173,13 +173,13 @@
> 	public void testGetBooleanInt() throws Exception {
> 		Method rset = ResultSet.class.getDeclaredMethod("getBoolean", new Class[] {int.class});
> 		Method rowset = ResultSetWrappingSqlRowSet.class.getDeclaredMethod("getBoolean", new Class[] {int.class});
>-		doTest(rset, rowset, new Integer(1), new Boolean(true));
>+		doTest(rset, rowset, new Integer(1), Boolean.valueOf(true));
> 	}
> 
> 	public void testGetBooleanString() throws Exception {
> 		Method rset = ResultSet.class.getDeclaredMethod("getBoolean", new Class[] {String.class});
> 		Method rowset = ResultSetWrappingSqlRowSet.class.getDeclaredMethod("getBoolean", new Class[] {String.class});
>-		doTest(rset, rowset, "test", new Boolean(true));
>+		doTest(rset, rowset, "test", Boolean.valueOf(true));
> 	}
> 
> 	private void doTest(Method rsetMethod, Method rowsetMethod, Object arg, Object ret) throws Exception {
>=== spring-nightly/test/org/springframework/util/comparator/ComparatorTests.java
>==================================================================
>--- spring-nightly/test/org/springframework/util/comparator/ComparatorTests.java	(revision 79)
>+++ spring-nightly/test/org/springframework/util/comparator/ComparatorTests.java	(local)
>@@ -49,12 +49,12 @@
> 
> 	public void testBooleanComparatorTrueLow() {
> 		Comparator c = BooleanComparator.TRUE_LOW;
>-		assertTrue(c.compare(new Boolean(true), new Boolean(false)) < 0);
>+		assertTrue(c.compare(Boolean.valueOf(true), Boolean.valueOf(false)) < 0);
> 	}
> 
> 	public void testBooleanComparatorTrueHigh() {
> 		Comparator c = BooleanComparator.TRUE_HIGH;
>-		assertTrue(c.compare(new Boolean(true), new Boolean(false)) > 0);
>+		assertTrue(c.compare(Boolean.valueOf(true), Boolean.valueOf(false)) > 0);
> 		assertTrue(c.compare(Boolean.TRUE, Boolean.TRUE) == 0);
> 	}
> 
>=== spring-nightly/test/org/springframework/web/util/ExpressionEvaluationUtilsTests.java
>==================================================================
>--- spring-nightly/test/org/springframework/web/util/ExpressionEvaluationUtilsTests.java	(revision 79)
>+++ spring-nightly/test/org/springframework/web/util/ExpressionEvaluationUtilsTests.java	(local)
>@@ -87,7 +87,7 @@
> 	public void testEvaluateBoolean() throws Exception {
> 		PageContext ctx = new MockPageContext();
> 		
>-		ctx.setAttribute("bla", new Boolean(true));
>+		ctx.setAttribute("bla", Boolean.valueOf(true));
> 		String expr = "${bla}";
> 		
> 		boolean b = ExpressionEvaluationUtils.evaluateBoolean("test", expr, ctx);
>
>  
>

[Springframework-developer] Re: [PATCH 3/3]: Remove questionable casts

[Chris T. <chr...@gm...>]

http://opensource2.atlassian.com/projects/spring/browse/SPR-1451

On 11/7/05, Chris Tilden <chr...@gm...> wrote:
> removed questionable casts
>
>
>

[Springframework-developer] Re: [PATCH 2/3]: Fix new String

[Chris T. <chr...@gm...>]

http://opensource2.atlassian.com/projects/spring/browse/SPR-1450

On 11/7/05, Chris Tilden <chr...@gm...> wrote:
> usage of String constructor is not recommended:
>      switched to use "" instead
>
>
>

[Springframework-developer] [PATCH 3/3]: Remove questionable casts

[Chris T. <chr...@gm...>]

removed questionable casts

[Springframework-developer] [PATCH 2/3]: Fix new String

[Chris T. <chr...@gm...>]

usage of String constructor is not recommended:
     switched to use "" instead

[Springframework-developer] [PATCH 1/3]: Fix new Boolean

[Chris T. <chr...@gm...>]

usage of Boolean constructor is not recommended:
     switched to use Boolean.valueOf() instead

[Springframework-developer] spring build.371 Build Successful

[<al...@in...>]

View results here -> http://opensource.jteam.nl/build/buildresults/spring?log=log20051108001530Lbuild.371

[Springframework-developer] Form Simplification taglib?

[Boyce, K. G. <Kei...@bc...>]

 Does anyone know if there is a copy of the form simplification taglib
we can get started on for servlet 2.3 spec?

This message is a PRIVATE communication.
If you are not the intended recipient, please do not read, copy,
or use it, and do not disclose it to others. Please notify the
sender of the delivery error by replying to this message, and then
delete it from your system. Thank you.

[Springframework-developer] Spring reference document translation

[<mar...@s3...>]

Hi,

	I'm currently thinking about Polish translation for Spring
reference, this may help some people especially for education purposes. =
Can
anyone from reference document team contact me with some info about =
current
document sources, formats etc.

Regards,

--=20
Marcin =A3ukasiak
Software Design Egineer
Silicon & Software Systems=20
Email		: mar...@s3...
Tel. Direct	: +48 71 33 48 029 =20


The information contained in this e-mail and in any attachments is confidential and is designated solely for the attention of the intended recipient(s). If you are not an intended recipient, you must not use, disclose, copy, distribute or retain this e-mail or any part thereof. If you have received this e-mail in error, please notify the sender by return e-mail and delete all copies of this e-mail from your computer system(s).
Please direct any additional queries to: com...@s3....
Thank You.

[Springframework-developer] Documentation update

[Todd N. <tod...@gm...>]

Hi all,
I would like to contribute some additional documentation to section 17.2.
While spring strives to eliminate EJB, I have mostly used it as a tool to
integrate POJO business code with the benefits or Remote Stateless EJB's to
utilize clustering. I would like to elaborate on the section of using a
ContextSignltonBeanFactoryLocator to only cache the first initialization of
a BeanFactory. What would be the fasted way to get the update to you so tha=
t
it can be published with the next site push?

Thanks,
Todd

Re: [Springframework-developer] Access to ServletConfig in WebApplicationContext

[Juergen H. <ju...@in...>]

Hi John,

We can certainly support injection of the ServletConfig / PortletConfig. The
only issue there is that this just makes sense for beans running in a
FrameworkServlet / FrameworkPortlet, so this is not something for the core
WebApplicationContext implementations - rather a custom BeanPostProcessor to
be registered by FrameworkServlet / FrameworkPortlet.

In any case, let's consider this for Spring 1.3!

Juergen
 

-----Original Message-----
From: spr...@li...
[mailto:spr...@li...] On Behalf Of
John Lewis
Sent: Sunday, November 06, 2005 4:54 AM
To: spr...@li...
Subject: [Springframework-developer] Access to ServletConfig in
WebApplicationContext

I posted a question about this to the user list last week and no one had any
secret tricks for this, so I'd like to propose a minor change to
WebApplicationContext and to FrameworkServlet as follows:

I'd like to provide beans running in a WebApplicationContext with access to
the ServletConfig that they are running in.  I'd like to do this in order to
provide access to the portletName and the initParameters for the Servlet.  I
know several other developers have expressed an interest in this.

This can be done in the same way that Spring currently provides access to
the ServletContext.  In fact, we can also provide a ServletConfigAware
interface and inject the ServletConfig directly into any bean that wants it.

I will then also provide equivalent functionality in the Portlet MVC code so
that beans running in a PortletApplicationContext have access the
PortletConfig they are running in.  I'd like to do this in both frameworks
in order to keep them relatively synchronized.

Any objections to all this?

Juergen, I'd be happy to email you the code prior to committing it into CVS
if you would like to review the changes first.  Please let me know.

Thanks for your support.

John Lewis



-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. Download
it for free - -and be entered to win a 42" plasma tv or your very own
Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php
_______________________________________________
Springframework-developer mailing list
Spr...@li...
https://lists.sourceforge.net/lists/listinfo/springframework-developer

[Springframework-developer] spring build.370 Build Successful

[<al...@in...>]

View results here -> http://opensource.jteam.nl/build/buildresults/spring?log=log20051107001646Lbuild.370

Re: [Springframework-developer] Access to ServletConfig in WebApplicationContext

[Juergen H. <ju...@in...>]

Sounds perfectly feasible. We will consider this when merging the Portlet
support from the sandbox into the main source tree, which is gonna happen
very soon now.

Juergen
 

-----Original Message-----
From: spr...@li...
[mailto:spr...@li...] On Behalf Of
Yujin Kim
Sent: Sunday, November 06, 2005 7:30 PM
To: spr...@li...
Subject: Re: [Springframework-developer] Access to ServletConfig in
WebApplicationContext

Slightly off topic here, but something I mentioned in my recent post.
Would refactoring/abstraction of multipart handling considered worthwhile?

For example, currently there's MultipartHttpServletRequest which contains
three methods that are not tied to Servlet but the interface itself is a
subinterface of HttpServletRequest, which makes the whole multipart servlet
centric.

If an interim interface is introduced, then while still maintaing
MultipartHttpServletRequest and MultipartActionRequest, the rest of the
framework can operate off of the interim interface, which I think can
eliminiate quite a bit of code duplication.  (Multipart support for Portlet
was just sent over to John for his review.  And Enrique also posted a
version on wiki).

While I amt ait,  I was also wondering if it would be make a good argument
to introduce a "resolver" framework.  Currently it seems DispatcherServlet
(and DispatherPotlet for that matter) is doing a bit of manual check on the
beans implementing ServletContextAware and processing of each resolvers
registered.  it would be nice to define pointcuts inside servlet workflow
and make resolvers dynamically injected upon autodiscoery.

Let me know if I am being ignorant and sily.

On 11/6/05, Juergen Hoeller <ju...@in...> wrote:
> At the core web MVC level, such an abstraction is arguably not worthwhile.
>
> The control flow in a Portlet environment is quite different, which 
> needs to be reflected in the corresponding controller model. 
> Furthermore, web controllers should have full access to the native 
> Servlet/Portlet facilities, not just to a least common denominator.
>
> On the view side, we have full reuse anyway, so it's really only about 
> the dispatcher / controller side, including handler mapping and co.
>
> Higher-level web UI frameworks such as Web Flow, JSF or Tapestry are a 
> different matter here. To a large degree, they abstract from the 
> underlying request model, so can more naturally abstract from the 
> concrete Servlet/Portlet facilities, or in fact even the dispatcher 
> facility they run in.
>
> Juergen
>
>
> -----Original Message-----
> From: spr...@li...
> [mailto:spr...@li...] On 
> Behalf Of Boyce, Keith Garry
> Sent: Sunday, November 06, 2005 5:10 AM
> To: spr...@li...
> Subject: RE: [Springframework-developer] Access to ServletConfig in 
> WebApplicationContext
>
>
> Sounds good to me... While you are at it have you considered if it's 
> possible to abstract the http and portlet request and response similar 
> to webflow so that the code doesn't have be so duplicated?
>
> -----Original Message-----
> From: spr...@li...
> [mailto:spr...@li...] On 
> Behalf Of John Lewis
> Sent: Saturday, November 05, 2005 10:54 PM
> To: spr...@li...
> Subject: [Springframework-developer] Access to ServletConfig in 
> WebApplicationContext
>
> I posted a question about this to the user list last week and no one 
> had any secret tricks for this, so I'd like to propose a minor change 
> to WebApplicationContext and to FrameworkServlet as follows:
>
> I'd like to provide beans running in a WebApplicationContext with 
> access to the ServletConfig that they are running in.  I'd like to do 
> this in order to provide access to the portletName and the 
> initParameters for the Servlet.  I know several other developers have
expressed an interest in this.
>
> This can be done in the same way that Spring currently provides access 
> to the ServletContext.  In fact, we can also provide a 
> ServletConfigAware interface and inject the ServletConfig directly into
any bean that wants it.
>
> I will then also provide equivalent functionality in the Portlet MVC 
> code so that beans running in a PortletApplicationContext have access 
> the PortletConfig they are running in.  I'd like to do this in both 
> frameworks in order to keep them relatively synchronized.
>
> Any objections to all this?
>
> Juergen, I'd be happy to email you the code prior to committing it 
> into CVS if you would like to review the changes first.  Please let me
know.
>
> Thanks for your support.
>
> John Lewis
>
>
>
> -------------------------------------------------------
> SF.Net email is sponsored by:
> Tame your development challenges with Apache's Geronimo App Server.
> Download it for free - -and be entered to win a 42" plasma tv or your 
> very own Sony(tm)PSP.  Click here to play:
> http://sourceforge.net/geronimo.php
> _______________________________________________
> Springframework-developer mailing list 
> Spr...@li...
> https://lists.sourceforge.net/lists/listinfo/springframework-developer
>
>
> This message is a PRIVATE communication.
> If you are not the intended recipient, please do not read, copy, or 
> use it, and do not disclose it to others. Please notify the sender of 
> the delivery error by replying to this message, and then delete it from
your system.
> Thank you.
>
>
> -------------------------------------------------------
> SF.Net email is sponsored by:
> Tame your development challenges with Apache's Geronimo App Server. 
> Download it for free - -and be entered to win a 42" plasma tv or your 
> very own Sony(tm)PSP.  Click here to play: 
> http://sourceforge.net/geronimo.php
> _______________________________________________
> Springframework-developer mailing list 
> Spr...@li...
> https://lists.sourceforge.net/lists/listinfo/springframework-developer
>
>
>
>
> -------------------------------------------------------
> SF.Net email is sponsored by:
> Tame your development challenges with Apache's Geronimo App Server. 
> Download it for free - -and be entered to win a 42" plasma tv or your 
> very own Sony(tm)PSP.  Click here to play: 
> http://sourceforge.net/geronimo.php
> _______________________________________________
> Springframework-developer mailing list 
> Spr...@li...
> https://lists.sourceforge.net/lists/listinfo/springframework-developer
>


-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. Download
it for free - -and be entered to win a 42" plasma tv or your very own
Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php
_______________________________________________
Springframework-developer mailing list
Spr...@li...
https://lists.sourceforge.net/lists/listinfo/springframework-developer