Menu
▾
▴
Re: [Springframework-developer] [PATCH 1/3]: Fix new Boolean
|
From: Juergen H. <ju...@in...> - 2005-11-08 08:45:21
|
Indeed, that's the main reason why use the Boolean constructors. I consider
that acceptable for 1.3 compatibility, even without explicit 1.4/1.3
fallback.
I've fixed the "new String(...)" usages, where appropriate. The only ones
passing in Strings into the constructor where in the test suite, though.
In any case, thanks for pointing those out, Chris!
Juergen
-----Original Message-----
From: spr...@li...
[mailto:spr...@li...] On Behalf Of
Guillaume Poirier
Sent: Tuesday, November 08, 2005 1:43 AM
To: spr...@li...
Subject: Re: [Springframework-developer] [PATCH 1/3]: Fix new Boolean
Boolean.valueOf() is indeed the better form, but the method is only
avalaible since J2SE 1.4, and AFAIK, Spring is 1.3 compatible, that means
that method cannot be used without having a fallback for 1.3.
Guillaume
Chris Tilden wrote:
>usage of Boolean constructor is not recommended:
> switched to use Boolean.valueOf() instead
>
>
>-----------------------------------------------------------------------
>-
>
>
> ----------------------------------------------------------------------
> r79: chris | 2005-10-31 16:33:39 -0800
>
> branch for new Boolean fix
>
> ----------------------------------------------------------------------
> r80: chris | 2005-10-31 16:35:04 -0800
>
> usage of Boolean constructor is not recommended:
> switched to use Boolean.valueOf() instead
>
> ----------------------------------------------------------------------
>
>
samples/countries/src/org/springframework/samples/countries/web/CountriesExc
elView.java | 4 ++--
>
samples/countries/src/org/springframework/samples/countries/web/CountriesPdf
View.java | 4 ++--
> src/org/springframework/aop/framework/Cglib2AopProxy.java
| 2 +-
> src/org/springframework/core/style/ToStringCreator.java
| 2 +-
> src/org/springframework/jdbc/datasource/LazyConnectionDataSourceProxy.java
| 6 +++---
> src/org/springframework/jdbc/support/lob/OracleLobHandler.java
| 2 +-
> src/org/springframework/orm/hibernate/HibernateTemplate.java
| 2 +-
> src/org/springframework/orm/hibernate3/HibernateTemplate.java
| 2 +-
> src/org/springframework/remoting/jaxrpc/JaxRpcPortClientInterceptor.java
| 4 ++--
> src/org/springframework/web/servlet/tags/HtmlEscapingAwareTag.java
| 2 +-
> test/org/springframework/jdbc/object/SqlUpdateTests.java
| 4 ++--
>
test/org/springframework/jdbc/support/rowset/ResultSetWrappingRowSetTests.ja
va | 4 ++--
> test/org/springframework/util/comparator/ComparatorTests.java
| 4 ++--
> test/org/springframework/web/util/ExpressionEvaluationUtilsTests.java
| 2 +-
> 14 files changed, 22 insertions(+), 22 deletions(-)
>
>===
>spring-nightly/samples/countries/src/org/springframework/samples/countr
>ies/web/CountriesExcelView.java
>==================================================================
>---
spring-nightly/samples/countries/src/org/springframework/samples/countries/w
eb/CountriesExcelView.java (revision 79)
>+++
spring-nightly/samples/countries/src/org/springframework/samples/countries/w
eb/CountriesExcelView.java (local)
>@@ -113,12 +113,12 @@
> row++;
>
> getCell(sheet, row,
0).setCellValue(getMessageSourceAccessor().getMessage("sort.asc"));
>- getCell(sheet, row,
1).setCellValue(getMessageSourceAccessor().getMessage(new
Boolean(sort.isAscending()).toString()));
>+ getCell(sheet, row,
>+1).setCellValue(getMessageSourceAccessor().getMessage(Boolean.valueOf(
>+sort.isAscending()).toString()));
> getCell(sheet, row, 1).setCellStyle(csp);
> row++;
>
> getCell(sheet, row,
0).setCellValue(getMessageSourceAccessor().getMessage("sort.igncase"));
>- getCell(sheet, row,
1).setCellValue(getMessageSourceAccessor().getMessage(new
Boolean(sort.isIgnoreCase()).toString()));
>+ getCell(sheet, row,
>+1).setCellValue(getMessageSourceAccessor().getMessage(Boolean.valueOf(
>+sort.isIgnoreCase()).toString()));
> getCell(sheet, row, 1).setCellStyle(csp);
> row++;
>
>===
>spring-nightly/samples/countries/src/org/springframework/samples/countr
>ies/web/CountriesPdfView.java
>==================================================================
>---
spring-nightly/samples/countries/src/org/springframework/samples/countries/w
eb/CountriesPdfView.java (revision 79)
>+++
spring-nightly/samples/countries/src/org/springframework/samples/countries/w
eb/CountriesPdfView.java (local)
>@@ -119,13 +119,13 @@
>
> cell = new PdfPCell(new
Phrase(getMessageSourceAccessor().getMessage( "sort.asc"), HEADING_FONT));
> table.addCell(cell);
>- cell = new PdfPCell(new
Phrase(getMessageSourceAccessor().getMessage(new
Boolean(sort.isAscending()).toString()),
>+ cell = new PdfPCell(new
>+Phrase(getMessageSourceAccessor().getMessage(Boolean.valueOf(sort.isAs
>+cending()).toString()),
> HEADING_DATA_FONT));
> table.addCell(cell);
>
> cell = new PdfPCell(new
Phrase(getMessageSourceAccessor().getMessage( "sort.igncase"),
HEADING_FONT));
> table.addCell(cell);
>- cell = new PdfPCell(new
Phrase(getMessageSourceAccessor().getMessage(new
Boolean(sort.isIgnoreCase()).toString()),
>+ cell = new PdfPCell(new
>+Phrase(getMessageSourceAccessor().getMessage(Boolean.valueOf(sort.isIg
>+noreCase()).toString()),
> HEADING_DATA_FONT));
> table.addCell(cell);
>
>===
>spring-nightly/src/org/springframework/aop/framework/Cglib2AopProxy.jav
>a ==================================================================
>---
spring-nightly/src/org/springframework/aop/framework/Cglib2AopProxy.java
(revision 79)
>+++
spring-nightly/src/org/springframework/aop/framework/Cglib2AopProxy.java
(local)
>@@ -549,7 +549,7 @@
> return Boolean.FALSE;
> }
>
>- return new
Boolean(AopProxyUtils.equalsInProxy(this.advised, otherAdvised));
>+ return
Boolean.valueOf(AopProxyUtils.equalsInProxy(this.advised,
>+otherAdvised));
> }
> }
>
>===
>spring-nightly/src/org/springframework/core/style/ToStringCreator.java
>==================================================================
>--- spring-nightly/src/org/springframework/core/style/ToStringCreator.java
(revision 79)
>+++ spring-nightly/src/org/springframework/core/style/ToStringCreator.java
(local)
>@@ -142,7 +142,7 @@
> * @return this, to support call-chaining
> */
> public ToStringCreator append(String fieldName, boolean value) {
>- return append(fieldName, new Boolean(value));
>+ return append(fieldName, Boolean.valueOf(value));
> }
>
> /**
>===
>spring-nightly/src/org/springframework/jdbc/datasource/LazyConnectionDa
>taSourceProxy.java
>==================================================================
>---
spring-nightly/src/org/springframework/jdbc/datasource/LazyConnectionDataSou
rceProxy.java (revision 79)
>+++
spring-nightly/src/org/springframework/jdbc/datasource/LazyConnectionDataSou
rceProxy.java (local)
>@@ -112,7 +112,7 @@
> * @see java.sql.Connection#getAutoCommit
> */
> public void setDefaultAutoCommit(boolean defaultAutoCommit) {
>- this.defaultAutoCommit = new Boolean(defaultAutoCommit);
>+ this.defaultAutoCommit = Boolean.valueOf(defaultAutoCommit);
> }
>
> /**
>@@ -160,7 +160,7 @@
> */
> protected synchronized void
checkDefaultConnectionProperties(Connection con) throws SQLException {
> if (this.defaultAutoCommit == null) {
>- this.defaultAutoCommit = new
Boolean(con.getAutoCommit());
>+ this.defaultAutoCommit =
Boolean.valueOf(con.getAutoCommit());
> }
> if (this.defaultTransactionIsolation == null) {
> this.defaultTransactionIsolation = new
>Integer(con.getTransactionIsolation());
>@@ -317,7 +317,7 @@
> return null;
> }
> else if
(method.getName().equals("isClosed")) {
>- return new Boolean(this.closed);
>+ return Boolean.valueOf(this.closed);
> }
> else if (method.getName().equals("close")) {
> // Ignore: no target connection yet.
>===
>spring-nightly/src/org/springframework/jdbc/support/lob/OracleLobHandle
>r.java
>==================================================================
>---
spring-nightly/src/org/springframework/jdbc/support/lob/OracleLobHandler.jav
a (revision 79)
>+++
spring-nightly/src/org/springframework/jdbc/support/lob/OracleLobHandler.jav
a (local)
>@@ -160,7 +160,7 @@
> * @see oracle.sql.CLOB#createTemporary
> */
> public void setCache(boolean cache) {
>- this.cache = new Boolean(cache);
>+ this.cache = Boolean.valueOf(cache);
> }
>
>
>===
>spring-nightly/src/org/springframework/orm/hibernate/HibernateTemplate.
>java ==================================================================
>---
spring-nightly/src/org/springframework/orm/hibernate/HibernateTemplate.java
(revision 79)
>+++
spring-nightly/src/org/springframework/orm/hibernate/HibernateTemplate.java
(local)
>@@ -508,7 +508,7 @@
> public boolean contains(final Object entity) throws
DataAccessException {
> Boolean result = (Boolean) execute(new HibernateCallback() {
> public Object doInHibernate(Session session) {
>- return new
Boolean(session.contains(entity));
>+ return
Boolean.valueOf(session.contains(entity));
> }
> }, true);
> return result.booleanValue();
>===
>spring-nightly/src/org/springframework/orm/hibernate3/HibernateTemplate
>.java
>==================================================================
>---
spring-nightly/src/org/springframework/orm/hibernate3/HibernateTemplate.java
(revision 79)
>+++
spring-nightly/src/org/springframework/orm/hibernate3/HibernateTemplate.java
(local)
>@@ -549,7 +549,7 @@
> public boolean contains(final Object entity) throws
DataAccessException {
> Boolean result = (Boolean) execute(new HibernateCallback() {
> public Object doInHibernate(Session session) {
>- return new
Boolean(session.contains(entity));
>+ return
Boolean.valueOf(session.contains(entity));
> }
> }, true);
> return result.booleanValue();
>===
>spring-nightly/src/org/springframework/remoting/jaxrpc/JaxRpcPortClient
>Interceptor.java
>==================================================================
>---
spring-nightly/src/org/springframework/remoting/jaxrpc/JaxRpcPortClientInter
ceptor.java (revision 79)
>+++
spring-nightly/src/org/springframework/remoting/jaxrpc/JaxRpcPortClientInter
ceptor.java (local)
>@@ -416,7 +416,7 @@
> stub._setProperty(Stub.ENDPOINT_ADDRESS_PROPERTY,
this.endpointAddress);
> }
> if (this.maintainSession) {
>- stub._setProperty(Stub.SESSION_MAINTAIN_PROPERTY,
new Boolean(this.maintainSession));
>+ stub._setProperty(Stub.SESSION_MAINTAIN_PROPERTY,
>+Boolean.valueOf(this.maintainSession));
> }
> if (this.customProperties != null) {
> Enumeration en =
this.customProperties.propertyNames();
>@@ -572,7 +572,7 @@
> call.setTargetEndpointAddress(this.endpointAddress);
> }
> if (this.maintainSession) {
>- call.setProperty(Call.SESSION_MAINTAIN_PROPERTY, new
Boolean(this.maintainSession));
>+ call.setProperty(Call.SESSION_MAINTAIN_PROPERTY,
>+Boolean.valueOf(this.maintainSession));
> }
> if (this.customProperties != null) {
> Enumeration en =
this.customProperties.propertyNames();
>===
>spring-nightly/src/org/springframework/web/servlet/tags/HtmlEscapingAwa
>reTag.java
>==================================================================
>---
spring-nightly/src/org/springframework/web/servlet/tags/HtmlEscapingAwareTag
.java (revision 79)
>+++
spring-nightly/src/org/springframework/web/servlet/tags/HtmlEscapingAwareTag
.java (local)
>@@ -46,7 +46,7 @@
> */
> public void setHtmlEscape(String htmlEscape) throws JspException {
> this.htmlEscape =
>- new
Boolean(ExpressionEvaluationUtils.evaluateBoolean("htmlEscape", htmlEscape,
pageContext));
>+
>+Boolean.valueOf(ExpressionEvaluationUtils.evaluateBoolean("htmlEscape"
>+, htmlEscape, pageContext));
> }
>
> /**
>===
>spring-nightly/test/org/springframework/jdbc/object/SqlUpdateTests.java
>==================================================================
>--- spring-nightly/test/org/springframework/jdbc/object/SqlUpdateTests.java
(revision 79)
>+++ spring-nightly/test/org/springframework/jdbc/object/SqlUpdateTests.java
(local)
>@@ -432,7 +432,7 @@
> public int run(int performanceId, int type, String name,
boolean confirmed) {
> Object[] params =
> new Object[] {new Integer(performanceId),
new Integer(type), name,
>-
new Boolean(confirmed)};
>+
Boolean.valueOf(confirmed)};
> return update(params);
> }
> }
>@@ -466,7 +466,7 @@
> public int run(int performanceId, int type, String name,
boolean confirmed) {
> Object[] params =
> new Object[] {
>- new Integer(performanceId), new
Integer(type), name, new Boolean(confirmed)};
>+ new Integer(performanceId), new
Integer(type), name,
>+Boolean.valueOf(confirmed)};
> return update(params);
> }
> }
>===
>spring-nightly/test/org/springframework/jdbc/support/rowset/ResultSetWr
>appingRowSetTests.java
>==================================================================
>---
spring-nightly/test/org/springframework/jdbc/support/rowset/ResultSetWrappin
gRowSetTests.java (revision 79)
>+++
spring-nightly/test/org/springframework/jdbc/support/rowset/ResultSetWrappin
gRowSetTests.java (local)
>@@ -173,13 +173,13 @@
> public void testGetBooleanInt() throws Exception {
> Method rset =
ResultSet.class.getDeclaredMethod("getBoolean", new Class[] {int.class});
> Method rowset =
ResultSetWrappingSqlRowSet.class.getDeclaredMethod("getBoolean", new Class[]
{int.class});
>- doTest(rset, rowset, new Integer(1), new Boolean(true));
>+ doTest(rset, rowset, new Integer(1), Boolean.valueOf(true));
> }
>
> public void testGetBooleanString() throws Exception {
> Method rset =
ResultSet.class.getDeclaredMethod("getBoolean", new Class[] {String.class});
> Method rowset =
ResultSetWrappingSqlRowSet.class.getDeclaredMethod("getBoolean", new Class[]
{String.class});
>- doTest(rset, rowset, "test", new Boolean(true));
>+ doTest(rset, rowset, "test", Boolean.valueOf(true));
> }
>
> private void doTest(Method rsetMethod, Method rowsetMethod, Object
>arg, Object ret) throws Exception { ===
>spring-nightly/test/org/springframework/util/comparator/ComparatorTests
>.java
>==================================================================
>---
spring-nightly/test/org/springframework/util/comparator/ComparatorTests.java
(revision 79)
>+++
spring-nightly/test/org/springframework/util/comparator/ComparatorTests.java
(local)
>@@ -49,12 +49,12 @@
>
> public void testBooleanComparatorTrueLow() {
> Comparator c = BooleanComparator.TRUE_LOW;
>- assertTrue(c.compare(new Boolean(true), new Boolean(false))
< 0);
>+ assertTrue(c.compare(Boolean.valueOf(true),
Boolean.valueOf(false))
>+< 0);
> }
>
> public void testBooleanComparatorTrueHigh() {
> Comparator c = BooleanComparator.TRUE_HIGH;
>- assertTrue(c.compare(new Boolean(true), new Boolean(false))
> 0);
>+ assertTrue(c.compare(Boolean.valueOf(true),
Boolean.valueOf(false))
>+> 0);
> assertTrue(c.compare(Boolean.TRUE, Boolean.TRUE) == 0);
> }
>
>===
>spring-nightly/test/org/springframework/web/util/ExpressionEvaluationUt
>ilsTests.java
>==================================================================
>---
spring-nightly/test/org/springframework/web/util/ExpressionEvaluationUtilsTe
sts.java (revision 79)
>+++
spring-nightly/test/org/springframework/web/util/ExpressionEvaluationUtilsTe
sts.java (local)
>@@ -87,7 +87,7 @@
> public void testEvaluateBoolean() throws Exception {
> PageContext ctx = new MockPageContext();
>
>- ctx.setAttribute("bla", new Boolean(true));
>+ ctx.setAttribute("bla", Boolean.valueOf(true));
> String expr = "${bla}";
>
> boolean b =
ExpressionEvaluationUtils.evaluateBoolean("test", expr,
> ctx);
>
>
>
-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. Download
it for free - -and be entered to win a 42" plasma tv or your very own
Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php
_______________________________________________
Springframework-developer mailing list
Spr...@li...
https://lists.sourceforge.net/lists/listinfo/springframework-developer
|
