[SoX-devel] [ sox-Patches-3534117 ] flac (decoder): simplify EOF state and fix MD5 check

[SourceForge.net <no...@so...>]

Patches item #3534117, was opened at 2012-06-10 03:50
Message generated for change (Tracker Item Submitted) made by eric_wong
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=310706&aid=3534117&group_id=10706

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: eric_wong (eric_wong)
Assigned to: Nobody/Anonymous (nobody)
Summary: flac (decoder): simplify EOF state and fix MD5 check

Initial Comment:
This patch depends on commit e9a8dcf780f1cbb6a6faf63b7ba28591963c1cbd
(flac: fix invalid memory access w/ optimize_trim) in the "dot" branch.
This patch is also available from my git repo:

  git pull git://bogomips.org/sox dot-flac-eof-md5

There's no need to keep track of EOF state ourselves as the FLAC
decoder already keeps track of decoder state us.  Instead, we
only need to keep track of whether or not we've seeked for MD5
verification.

To test the ability of the flac handler to detect bad MD5s,
I changed the MD5 checksum of a good FLAC file using the
undocumented "--set-md5sum" option of metaflac(1):

  metaflac --set-md5sum d41d8cd98f00b204e9800998ecf8427e foo.flac

This let me decode the entire file without errors, but
ultimately fail the MD5 check.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=310706&aid=3534117&group_id=10706