[SoX-devel] [ sox-Bugs-2675504 ] undefined behaviour

[SourceForge.net <no...@so...>]

Bugs item #2675504, was opened at 2009-03-09 15:34
Message generated for change (Comment added) made by sf-robot
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110706&aid=2675504&group_id=10706

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
Resolution: None
Priority: 5
Private: No
Submitted By: Pavol Rusnak (prusnak)
Assigned to: Nobody/Anonymous (nobody)
Summary: undefined behaviour

Initial Comment:
I received a bug report from one of our reporters:

mp3.c:487: warning: operation on 'written2' may be undefined

The source code is

  else if (lsx_writebuf(ft, mp3buffer, written2 = written) < written2){

There is no requirement that the LHS of an expression is evaluated
before the RHS of an expression.

I suggest to replace the code with:

  else {
    written2 = written;
    if (lsx_writebuf(ft, mp3buffer, written) < written2) {



----------------------------------------------------------------------

>Comment By: SourceForge Robot (sf-robot)
Date: 2009-04-19 02:21

Message:
This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).

----------------------------------------------------------------------

Comment By: robs (robs)
Date: 2009-03-17 21:58

Message:
Thanks, cleaned up code now in CVS.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110706&aid=2675504&group_id=10706