From: Christiaan H. <cmh...@gm...> - 2007-11-30 22:09:58
|
I realized the problem. The target should be archived as a conditionalObject or not. Now it archives the mainWindowController (which is the target) and then for the customization panel it unarchives it. However this is just a copy, and as it is not retained it is deallocated. As it never loaded the nib it also never registered as an observer. Christiaan On 30 Nov 2007, at 10:51 PM, Adam R. Maxwell wrote: > AFAIK the target isn't retained. Interesting point, though...if I > remove the target/action ivars from SKColorSwatch and use super's > implementation, things work (no exception). Are the overrides needed? > > adam > > On Friday, November 30, 2007, at 01:42PM, "Christiaan Hofman" > <cmh...@gm...> wrote: >> Is the target of a control retained? That may be the problem (in >> [SKColorSwatch initWithCoder:]). I assumed it's not retained, as the >> target can be the "owner" (of a nib or something). >> >> Christiaan >> >> On 30 Nov 2007, at 10:21 PM, Adam R. Maxwell wrote: >> >>> >>> On Friday, November 30, 2007, at 01:08PM, "Christiaan Hofman" >>> <cmh...@gm...> wrote: >>>> >>>> On 30 Nov 2007, at 9:15 PM, Adam R. Maxwell wrote: >>>> >>>>> >>>>> On Friday, November 30, 2007, at 11:53AM, "Christiaan Hofman" >>>>> <cmh...@gm...> wrote: >>>>> >>>>>> And what about the note adorns, in particular in the optional Add >>>>>> Note segmented control? >>>>> >>>>> I'm not sure which one that is, but I can't customize the toolbar. >>>>> The console logs this: >>>>> >>>>> 11/30/07 12:10:19 Skim[3127] Cannot remove an observer >>>>> <SKMainWindowController 0x5658e20> for the key path >>>>> "values.SKBackgroundColor" from <NSUserDefaultsController >>>>> 0x251880> >>>>> because it is not registered as an observer. >>>>> >>>>> I'll look at it in the debugger later. >>>> >>>> Strange log, it does register as an observer, unless the nib is >>>> never >>>> loaded. But I doubt it has anything to d with toolbar >>>> customization, >>>> as it should be logged at dealloc. >>> >>> Looks like it's copying a view. The item identifier is >>> SKDocumentToolbarColorSwatchItemIdentifier. >>> >>> #0 0x91064680 in objc_exception_throw >>> #1 0x90a4fe50 in +[NSException raise:format:arguments:] >>> #2 0x90a4fe88 in +[NSException raise:format:] >>> #3 0x954fbf18 in -[NSObject(NSKeyValueObserverRegistration) >>> _removeObserver:forProperty:] >>> #4 0x954fbc2c in -[NSObject(NSKeyValueObserverRegistration) >>> removeObserver:forKeyPath:] >>> #5 0x93aedf94 in -[NSController removeObserver:forKeyPath:] >>> #6 0x000d3380 in -[NSUserDefaultsController(SKExtensions) >>> removeObserver:forKeys:] at >>> NSUserDefaultsController_SKExtensions.m:64 >>> #7 0x0001f5b4 in -[SKMainWindowController unregisterAsObserver] at >>> SKMainWindowController.m:599 >>> #8 0x0001bd88 in -[SKMainWindowController dealloc] at >>> SKMainWindowController.m:279 >>> #9 0x9399f8c0 in -[NSWindowController release] >>> #10 0x909b443c in __CFDictionaryDeallocate >>> #11 0x909e48c4 in _CFRelease >>> #12 0x954a7c7c in -[NSKeyedUnarchiver dealloc] >>> #13 0x955016e8 in +[NSKeyedUnarchiver unarchiveObjectWithData:] >>> #14 0x93e86208 in -[NSToolbarItem _copyOfCustomView] >>> #15 0x93e862c0 in -[NSToolbarItem copyWithZone:] >>> #16 0x0005235c in -[SKMainWindowController >>> toolbar:itemForItemIdentifier:willBeInsertedIntoToolbar:] at >>> SKMainWindowController.m:5067 >>> #17 0x93a81750 in -[NSToolbar >>> _newItemFromDelegateWithItemIdentifier:willBeInsertedIntoToolbar:] >>> #18 0x93a7eb6c in -[NSToolbar >>> _newItemFromItemIdentifier:requireImmediateLoad:willBeInsertedIntoTo >>> ol >>> bar:] >>> #19 0x93e8115c in -[NSToolbar >>> toolbar:itemForItemIdentifier:willBeInsertedIntoToolbar:] >>> #20 0x93a81750 in -[NSToolbar >>> _newItemFromDelegateWithItemIdentifier:willBeInsertedIntoToolbar:] >>> #21 0x93a7eb6c in -[NSToolbar >>> _newItemFromItemIdentifier:requireImmediateLoad:willBeInsertedIntoTo >>> ol >>> bar:] >>> #22 0x93a7e97c in -[NSToolbar >>> _insertNewItemWithItemIdentifier:atIndex:notifyDelegate:notifyView:n >>> ot >>> ifyFamilyAndUpdateDefaults:] >>> #23 0x93a80338 in -[NSToolbar >>> _setCurrentItemsToItemIdentifiers:notifyDelegate:notifyView:notifyFa >>> mi >>> lyAndUpdateDefaults:] >>> #24 0x93e7f57c in -[NSToolbar >>> _loadInitialItemIdentifiers:requireImmediateLoad:] >>> #25 0x93e84428 in -[NSToolbarConfigPanel _loadData] >>> #26 0x93e83ed8 in -[NSToolbarConfigPanel initForToolbar:withWidth:] >>> #27 0x93e7fa98 in -[NSToolbar _runCustomizationPanel] >>> #28 0x939d635c in -[NSApplication sendAction:to:from:] >>> #29 0x93a71994 in -[NSMenu performActionForItemAtIndex:] >>> #30 0x93a716c4 in -[NSCarbonMenuImpl >>> performActionWithHighlightingForItemAtIndex:] >>> >>> >>> >>> -------------------------------------------------------------------- >>> -- >>> --- >>> SF.Net email is sponsored by: The Future of Linux Business White >>> Paper >>> from Novell. From the desktop to the data center, Linux is going >>> mainstream. Let it simplify your IT future. >>> http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4 >>> _______________________________________________ >>> skim-app-develop mailing list >>> ski...@li... >>> https://lists.sourceforge.net/lists/listinfo/skim-app-develop >> >> >> --------------------------------------------------------------------- >> ---- >> SF.Net email is sponsored by: The Future of Linux Business White >> Paper >> from Novell. From the desktop to the data center, Linux is going >> mainstream. Let it simplify your IT future. >> http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4 >> _______________________________________________ >> skim-app-develop mailing list >> ski...@li... >> https://lists.sourceforge.net/lists/listinfo/skim-app-develop >> >> > > ---------------------------------------------------------------------- > --- > SF.Net email is sponsored by: The Future of Linux Business White Paper > from Novell. From the desktop to the data center, Linux is going > mainstream. Let it simplify your IT future. > http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4 > _______________________________________________ > skim-app-develop mailing list > ski...@li... > https://lists.sourceforge.net/lists/listinfo/skim-app-develop |