#200 crash on export with embedded notes

[James Howison]

Version 1.0RC1 (v16) (just updated using internal update function) on Leopard (10.5.0)

Skim crashes for me when I choose File->Export->PDF with embedded notes using the attached PDF and skim file (which I zipped along with the Error Detail from the report to Apple pop-up).

Hmmm, too big to attach. It's available here:

http://freelancepropaganda.com/temp/exportingThisCrashesSkim.zip

[Christiaan Hofman]

Logged In: YES
user_id=1162009
Originator: NO

I can't test this, as I don't have Leopard. This is probably a Leopard bug, as we just save the PDF using PDFKit. But I'm really surprised at where it crashes, namely when the error is presented. We make sure tt there is an error, so this should never fail. Sounds like a double Leopard bug.

[Christiaan Hofman]

Logged In: YES
user_id=1162009
Originator: NO

I also wonder: is it a particular type of notes that leads to a crash?

[Adam Maxwell]

Logged In: YES
user_id=732757
Originator: NO

This is not a Leopard bug. It's not correct to test *outError == nil before setting an error, because callers aren't required to initialize them to anything. The only thing you're supposed to test is a NO or nil return value. This bit me a few times in BD.

[Nobody/Anonymous]

Logged In: NO

Hey, Skim is also crashing for me when I export ONE certain pdf. I've been doing this all day, exporting into Papers, and there is literally one smaller (five pages) pdf that crashes skim every time. I actually only have a few highlights added, so its not a big deal, its just bothering me. I'm running Leopard, and am exporting pdf with embedded notes.