#38 Bug in request header parsing

[Anonymous]

The SegmentConsumer has a bug that causes Simple to close the connection to the client. The bug occurs when the request, including headers, have a length of 1024+n*512.

[Anonymous]

A unit test reproducing the bug

[Anonymous]

Run the attached unit test to reproduce the bug

[Anonymous]

The bug is fixed by replacing the SegmentConsumer.value() method to:

private void value() {
Token token = new Token(pos, 0);

scan: for(int mark = 0; pos < count;){
if(terminal(array[pos])) { /* CR or LF */
for(int i = 0; pos < count; i++){
if(array[pos++] == 10) { /* skip the LF */
if(pos < array.length && space(array[pos])) {
mark += i + 1; /* account for bytes examined */
break; /* folding line */
}
break scan; /* not a folding line */
}
}
} else {
if(!space(array[pos])){
token.size = ++mark;
} else {
mark++;
}
pos++;
}
}
value = token.text();
}

[Niall Gallagher]

Can u provide more info???

[Anonymous]

The bug causes Simple to close the connection to the client. I have attached a unittest reproducing the issue