#23 inefficient org.simpleframework.SegmentBuilder.isReference()

[Anonymous]

I think SegmentBuilder.isReference() :

public boolean isReference() {
boolean shared = false;

for(Packet packet : ready) {
if(packet.isReference()) {
shared = true;
}
}
return shared;
}

coulb be rewritten like

public boolean isReference() {

for(Packet packet : ready) {
if(packet.isReference()) {
return true;
}
}
return false;
}

[Nobody/Anonymous]

Thanks, yes this is inefficient. I will address in the next release.