[Simpletest-devel] [ simpletest-Bugs-1962781 ] Dead code

[SourceForge.net <no...@so...>]

Bugs item #1962781, was opened at 2008-05-13 15:14
Message generated for change (Comment added) made by dermanomann
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=547455&aid=1962781&group_id=76550

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Unit test framework
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: Dead code

Initial Comment:
lines 512 through 520 of test_unit.php read:

    function add($test_case) {
        if (! is_string($test_case)) {
            $this->test_cases[] = $test_case;
        } elseif (TestSuite::getBaseTestCase($test_case) == 'testsuite') {
            $this->test_cases[] = new $test_case();
        } else {
            $this->test_cases[] = $test_case;
        }
    }

The middle test is dead because an object !is_string().

It works as is, so maybe the middle code isn't needed?

----------------------------------------------------------------------

Comment By: DerManoMann (dermanomann)
Date: 2008-08-04 12:40

Message:
Logged In: YES 
user_id=1046384
Originator: NO

I disagree with 'works as is'.

In my environment simpletest seems to have problems handling references
properly (and others).

$suite->add('MyTest'); 
results in: Call to a member function getSize() on a non-object

and this:
$suite->add($test1);
$suite->add($test2);
will execute the first test twice.

All this using PHP5.2.6!

So, what works for me is actually to use the deprecated method
$suite->addTestClass('MyTest');

mano

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=547455&aid=1962781&group_id=76550