Re: [SMW-devel] Help:Category page returns as empty because of || (bug 9178)

[Markus <ma...@ai...>]

On Thursday 08 March 2007 20:48, S Page wrote:
> Thanks for your reply.
> I tracked it down some more.  As I updated the bug, I think this broke
> in revision 17529 when normalizeRedirects() switched from working on
> article names to working on Title objects.  The function uses array_diff
> with an empty array, I think to remove duplicates, but this casts to
> string when comparing array entries, and this fails for MediaWiki's
> Title objects.
>
>  > I will soon rewrite the Inline Query code to separate parsing
>  > and query execution. If this does not fix the bug, it will at least
>
> make it
>
>  > easier to track it down.
>
> OK then.  I think the fix here is to rewrite this routine to work with
> an array of article_ids.
>
>
> I have a general question: isn't
>    $check_list =3D array_unique($list); // Copies the array without
> duplicate values
>
> a better idiom than
>    $check_list =3D array_diff( $list, array() ); // Copies the array

Probably yes, though I do not know now whether duplicates can occur in this=
=20
place. I think there are even copy constructors for arrays in PHP?

Best,

Markus

>
> ?
>
> Regards,
> --
> =3DS

=2D-=20
Markus Kr=F6tzsch
Institute AIFB, University of Karlsruhe, D-76128 Karlsruhe
ma...@ai...        phone +49 (0)721 608 7362
www.aifb.uni-karlsruhe.de/WBS/     fax +49 (0)721 693  717