Re: [Semediawiki-user] SF: form adds space on last property

[Krabina B. <kr...@kd...>]

Hi Robert,

there are two problems: The textarea input results in the problem of the additional \n at the last property when using indexed properties. 

But the second problem is that properties get mixed up if the first property is empty. This shows up using indexed properties and works fine using named properties. I have pages with no textarea input and still the properties get mixed up in the form when the first property is empty. 

regards,
Bernhard

-- 
Mag. Bernhard Krabina
KDZ - Zentrum für Verwaltungsforschung
Centre for Public Administration Research
Guglgasse 13, 1110 Wien
Telefon: +43 1 8923492-27, Fax: +43 1 8923492-20
Mobil:   +43 676 4848109
mailto:kr...@kd... - http://www.kdz.or.at

- Plattform Verwaltungskooperation:
  http://www.verwaltungskooperation.at 
- RISER: Europäische Meldeauskunft
  http://www.kdz.or.at/riser

----- "Robert Michel" <xol...@ho...> schrieb:

> Hi Bernhard,
> 
> actually you seem to have hit some rare combination SF implementation,
> your 
> form definition and Mediawiki template parsing...
> 
> normally, the template call generated by SF would look like
> 
> {{<templatename>|val1|val2|val3...|valx}}
> 
> for indexed templates, and
> 
> {{<templatename>
> |var1=val1
> |var2=val2
> ...
> |varx=valx
> }}
> 
> for named properties
> 
> The SF code checks, if a line break is in the template and adds an 
> additional "\n" before the closing "}}" (just for readability).
> In indexed templates this seem to happen only, when you use textarea
> input 
> (which allows multiline input) AND actually input multiline text!
> 
> So the statement in SF doc should be: "Do not use textarea input with
> 
> indexed templates".
> Or Yaron just removes this line of code from further versions.
> 
> Also, MW seems to handle parsing differently in both cases (not
> removing 
> line breaks at value end in indexed templates, but removing them on
> named 
> properties....
> 
> Robert
> 
> 
> --------------------------------------------------
> From: "Krabina Bernhard" <kr...@kd...>
> Sent: Tuesday, September 01, 2009 1:53 PM
> To: "Robert Michel" <xol...@ho...>
> Cc: <sem...@li...>
> Subject: Re: [Semediawiki-user] SF: form adds space on last property
> 
> > Hi,
> >
> > as I didn't want to change the source, I tried the second option and
> it 
> > worked. The downside was that I had to manually reformat all pages
> because 
> > of the changed template usage.
> >
> > Yaron, can you please update the info on the SF page, that you
> should NOT 
> > use indexed properties at all! (or even better fix the bug in SF
> ;-)
> >
> >> btw., how is the linebreak in "Guglgasse 13
> >> 1110 Vienna
> >> AUSTRIA" getting into the value?
> >
> > The address property is of type string. I just declared the form
> input as 
> > input type=textarea and this works fine.
> >
> > -Bernhard
> >
> > ----- "Robert Michel" <xol...@ho...> schrieb:
> >
> >> Hi,
> >>
> >> you could try 2 things:
> >> 1.) in SF_FormPrinter.inc in extensions/SemanticForms/includes
> around
> >> line
> >> 866 ther should be three lines like:
> >>           if (strpos($template_text, "\n"))
> >>             $template_text .= "\n";
> >>           $template_text .= "}}";
> >> try removing the first and second line (the whole if...)
> >>
> >> 2.) you could try using templates with named, not indexed
> properties.
> >>
> >> btw., how is the linebreak in "Guglgasse 13
> >> 1110 Vienna
> >> AUSTRIA" getting into the value?
> >>
> >> Robert
> >>
> >> --------------------------------------------------
> >> From: "Krabina Bernhard" <kr...@kd...>
> >> Sent: Monday, August 31, 2009 7:33 PM
> >> To: <sem...@li...>
> >> Subject: [Semediawiki-user] SF: form adds space on last property
> >>
> >> > Hi,
> >> >
> >> > I have the following problems with a form. I have a property
> >> "Profession"
> >> > that is defined like this:
> >> >
> >> > This is a property of type [[Has type::String]].
> >> >
> >> > The allowed values for this property are:
> >> > * [[Allows value::Practitioner]]
> >> > * [[Allows value::Expert]]
> >> >
> >> > The allowed values are displayed correctly in the Form:Person
> with:
> >> >
> >> > ...
> >> > ! Language(s) spoken:
> >> > | {{{field|9|size=30|autocomplete on property=Language}}}
> >> > |-
> >> > ! Profession:
> >> > | {{{field|10}}}
> >> > |}
> >> >
> >> > If I submit the form, i get:
> >> >
> >> > {{Person|Mag.|Bernhard|Krabina|KDZ|Guglgasse 13
> >> > 1110 Vienna
> >> > AUSTRIA|kr...@kd...|+43 1 8923492 27||German,
> English,|Expert
> >> > }}
> >> >
> >> > This results in a warning message: "Expert " is not in the list
> of
> >> > possible values (Practitioner, Expert) for this property. Which
> is
> >> > correct, because the value is "Expert", not "Expert ".
> >> >
> >> > If i manually change the source to
> >> >
> >> > {{Person|Mag.|Bernhard|Krabina|KDZ|Guglgasse 13
> >> > 1110 Vienna
> >> > AUSTRIA|kr...@kd...|+43 1 8923492 27||German,
> >> English,|Expert}}
> >> >
> >> > removing the last space, everything works again. When I hit
> "edit
> >> with
> >> > form" again, change noting and save, the space gets added again.
> >> >
> >> > Is this a bug in SF or is something else wrong?
> >> >
> >> > A second mistake is that if i leave the first property in the
> form
> >> empty,
> >> > the second property moves to the first form field when I hit
> "edit
> >> with
> >> > form"...
> >> >
> >> > - Bernhard
> >> >
> >> >
> >>
> ------------------------------------------------------------------------------
> >> > Let Crystal Reports handle the reporting - Free Crystal Reports
> 2008
> >>
> >> > 30-Day
> >> > trial. Simplify your report design, integration and deployment -
> and
> >> focus
> >> > on
> >> > what you do best, core application coding. Discover what's new
> with
> >> > Crystal Reports now.  http://p.sf.net/sfu/bobj-july
> >> > _______________________________________________
> >> > Semediawiki-user mailing list
> >> > Sem...@li...
> >> > https://lists.sourceforge.net/lists/listinfo/semediawiki-user
> >> >
> >