- W_ESC_SEQ_OOR_FOR_CHAR = 137, /* Escape sequence of of range for char */
+ W_ESC_SEQ_OOR_FOR_CHAR = 137, /* Escape sequence of range for char */
The I/P should have been I/O:
-elseif(TARGET_IS_SM83&&IS_ABSOLUTE(sym->etype)&&SPEC_SCLS(sym->etype)==S_SFR)// Unlike the otehr z80-like ports, sm83 has I/P in the 0xff00-0xffff range.+elseif(TARGET_IS_SM83&&IS_ABSOLUTE(sym->etype)&&SPEC_SCLS(sym->etype)==S_SFR)// Unlike the other z80-like ports, sm83 has I/P in the 0xff00-0xffff range.
Looks more like "problem" than "probable" to me:
-// To get around this proble, the peep rule can be followed
+// To get around this probable, the peep rule can be followed
The original looks wrong to me, but so does fix:
-unsignedisPublic:1;/* True if the reg is not static and can be modified in another module (ie a another c or asm file) */+unsignedisPublic:1;/* True if the reg is not static and can be modified in another module (ie an another c or asm file) */
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
oups, sorry.. patch is broken (EOL sensitive)
new one should be better
Last edit: Konstantin Kim 2023-02-10
Thanks for looking through all that SDCC source. I had quick look at the patch.
This bit looks odd (with very few exceptions, text files in SDCC are UTF-8):
This apparently should have been "out of range":
The I/P should have been I/O:
Looks more like "problem" than "probable" to me:
The original looks wrong to me, but so does fix:
It seems patch was applied well selectively ;)
Fixed in [r15575].
Related
Commit: [r15575]
Perhaps hand work is not so productive.
I may suggest to use some SVN pre-action with tools like following one:
https://github.com/intgr/topy