Menu

#460 sdcc/src code spell check

None
closed-accepted
spell (4)
5
2025-08-10
2023-02-10
No

a few more suggestions
to be tested

1 Attachments

Related

Wiki: NGI0-Commons-SDCC

Discussion

  • Konstantin Kim

    Konstantin Kim - 2023-02-10

    oups, sorry.. patch is broken (EOL sensitive)
    new one should be better

     

    Last edit: Konstantin Kim 2023-02-10
    • Philipp Klaus Krause

      Thanks for looking through all that SDCC source. I had quick look at the patch.

      This bit looks odd (with very few exceptions, text files in SDCC are UTF-8):

      -// (c) 2010-2011 Goethe-Universität Frankfurt
      +// (c) 2010-2011 Goethe-Universit\E4t Frankfurt
      

      This apparently should have been "out of range":

      -  W_ESC_SEQ_OOR_FOR_CHAR        = 137, /* Escape sequence of of range for char */
      +  W_ESC_SEQ_OOR_FOR_CHAR        = 137, /* Escape sequence of range for char */
      

      The I/P should have been I/O:

      -  else if (TARGET_IS_SM83 && IS_ABSOLUTE (sym->etype) && SPEC_SCLS (sym->etype) == S_SFR) // Unlike the otehr z80-like ports, sm83 has I/P in the 0xff00-0xffff range.
      +  else if (TARGET_IS_SM83 && IS_ABSOLUTE (sym->etype) && SPEC_SCLS (sym->etype) == S_SFR) // Unlike the other z80-like ports, sm83 has I/P in the 0xff00-0xffff range.
      

      Looks more like "problem" than "probable" to me:

      -// To get around this proble, the peep rule can be followed
      +// To get around this probable, the peep rule can be followed
      

      The original looks wrong to me, but so does fix:

      -  unsigned isPublic:1;        /* True if the reg is not static and can be modified in another module (ie a another c or asm file) */
      +  unsigned isPublic:1;        /* True if the reg is not static and can be modified in another module (ie an another c or asm file) */
      
       
      • Konstantin Kim

        Konstantin Kim - 2023-03-06

        It seems patch was applied well selectively ;)

        -          /* otherwise perfer to load a last */
        +          /* otherwise prefer to load a last */
        
        - * genm6502Code - generate code for for a block of instructions
        + * genm6502Code - generate code for a block of instructions
        
        -          // Using ldw results in substancially shorter, but somewhat slower code.
        +          // Using ldw results in substantially shorter, but somewhat slower code.
        
        -// If what is 0, just check if hte ith argument is in registers.
        +// If what is 0, just check if the ith argument is in registers.
        
        -  /* fixing all of the stack offsets; this is too dificult to consider. */
        +  /* fixing all of the stack offsets; this is too difficult to consider. */
        
        -       /* if this is cast for intergral promotion then
        +       /* if this is cast for integral promotion then
        
        -        && !IS_CODEPTR (OP_SYM_TYPE (op))   /* --> get symbols address instread */    \
        +        && !IS_CODEPTR (OP_SYM_TYPE (op))   /* --> get symbols address instead */    \
        
        - * this instruction geenrated? Here is the answer... */
        + * this instruction generated? Here is the answer... */
        
        -/* genIpush - genrate code for pushing this gets a little complex  */
        +/* genIpush - generate code for pushing this gets a little complex  */
        
        -/* unsaverbank - restores the resgister bank from stack            */
        +/* unsaverbank - restores the register bank from stack            */
        
         
        • Philipp Klaus Krause

          Fixed in [r15575].

           

          Related

          Commit: [r15575]

  • Konstantin Kim

    Konstantin Kim - 2023-03-07

    Perhaps hand work is not so productive.
    I may suggest to use some SVN pre-action with tools like following one:
    https://github.com/intgr/topy

     
  • Philipp Klaus Krause

    • status: open --> closed-accepted
    • assigned_to: Philipp Klaus Krause
    • Group: -->
     

Log in to post a comment.

MongoDB Logo MongoDB