Thanks. I applied most of the regression test spelling patch in [r12887]. I chose not to apply the bits that would affect tests from based on external sources, since I prefer to keep the diff to upstream small for them.
❤️
1
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
For the tests in tests/ that are based on external sources, those external sources are mentioned in the comments at the beginnings of the files.
Later, we also introduced separate directories for such tests (e.g. gte for GCC tests, but not all GCC tests have been migrated to that new structure yet).
AFAIR the spelling fixes that I did not apply are all tests from GCC (filename starts with gcc-), with one exception: p99-confomrance.c, which is from P99.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Thanks. I applied it in [r13889], with the following changes:
I didn't apply the targetting to targeting change, as my dictionary lists both as valid spellings.
For the changes in SDCCerr.h, I instead synced the comments with the actual error messages (since this is how it has been done for for the error messages added in the last 10 years or so). By replacing the comment by the error message text in all cases except for one: for that one the spelling was wrong even in the error message, so I fixed the message, too.
+ucsim
While I assigned this ticket to myself, since I dealt with the regression test spelling patch, I'll leave the uCsim bits to @drdani.
Applied in [r13888]
Thanks. I applied most of the regression test spelling patch in [r12887]. I chose not to apply the bits that would affect tests from based on external sources, since I prefer to keep the diff to upstream small for them.
Maybe it's not so bad to indicate external sources?
then we may correct the source
For the tests in tests/ that are based on external sources, those external sources are mentioned in the comments at the beginnings of the files.
Later, we also introduced separate directories for such tests (e.g. gte for GCC tests, but not all GCC tests have been migrated to that new structure yet).
AFAIR the spelling fixes that I did not apply are all tests from GCC (filename starts with gcc-), with one exception: p99-confomrance.c, which is from P99.
another one, if you don't mind ;)
Last edit: Konstantin Kim 2023-02-09
Thanks. I applied it in [r13889], with the following changes:
Related
Commit: [r13889]
in my dictionary "targetting" marked as uncommon/unusual.
https://www.future-perfect.co.uk/grammar-tips/just-plain-wrong/is-it-targetted-or-targeted
https://thecontentauthority.com/blog/targetting-vs-targeting
My goal is not to fix them all. The goal is to reduce the number of obvious misspellings, and don't make new ones..
At the same time, "targetting" sounds cute to me :)
I found about a hundred more cases. Can I post a patch here or is it better to open a new ticket?
I suggest a new ticket,
I wonder how "signess" in SDCCast.c passed these spelling checks.
Shouldn't that be "signedness" ?