Menu

#307 Typo in SDCCsymt.h

None
closed-accepted
None
5
2019-10-11
2019-08-17
RvS
No

Hi,

I noticed, what I think is, a typo in the file SDCCsymt.h.
I attached a patch to fix this.

Regards,
Ruud van Silfhout

1 Attachments

Discussion

  • Philipp Klaus Krause

    It indeed looks like a typo. But I wonder, what effect, if any, it had, given it probably has been there for very long. Could the fix break something.
    Do we have a bug that results from this typo (preferably with a small example to show it)?

     
    • Philipp Klaus Krause

      This is definitely something that should be fixed; please also report the others. I'm just worried about breaking something that essentially worked by accident.

       
  • Philipp Klaus Krause

    • status: open --> closed-fixed
    • assigned_to: Philipp Klaus Krause
    • Group: -->
     
  • Philipp Klaus Krause

    On second look, the patch only fixes an error message used in case of internal compiler errors, so there is no risk of breaking anything, and it obviously fixes a bug.

    Applied in [r11422].

     
  • Philipp Klaus Krause

    • status: closed-fixed --> closed-accepted
     
  • Philipp Klaus Krause

    On second look, the patch only fixes an error message used in case of internal compiler errors, so there is no risk of breaking anything, and it obviously fixes a bug.

    Applied in [r11422].

     

Log in to post a comment.

MongoDB Logo MongoDB