#4025 f8(l) --opt-code speed logic issues

[Philipp Klaus Krause]

I see tests for logical operators failing for f8 and f8l:

philipp@notebook7:~/sdcc-trunk/sdcc/support/regression$ make random-test-15841302869033788780 random-test-487828595760370920
Creating random-15841302869033788780 based on f8l with additional options: --opt-code-speed --nopurity --nogenconstprop --no-peep --max-allocs-per-node 4096 
..
populated MakeList...
gce: gcc torture execute.. 174
m4: macro tests.. 1
qct: QuickC tests.. 108
tcc: tinycc tests.. 117
tpl: template tests.. 134
tst: plain tests.. 1558
Running random-15841302869033788780 regression tests
results/random-15841302869033788780/tst_bug1738367.out:17:--- FAIL: "Assertion failed" on !ternary_inv(0x10) at cases/./../tests/bug1738367.c:59
results/random-15841302869033788780/tst_bug1738367.out:18:--- FAIL: "Assertion failed" on !ternary1_inv(0x10) at cases/./../tests/bug1738367.c:65
results/random-15841302869033788780/tst_bug1738367.out:19:--- FAIL: "Assertion failed" on !ternary2_inv(0x10) at cases/./../tests/bug1738367.c:71
Failure: bug1738367.c
tst_bug1738367                      (f:  3, t:  13, c:    1, b:    1240, T:     13272)
results/random-15841302869033788780/logic/logic_type_char_storage_none_attr_volatile_values_31734.out:20:--- FAIL: "Assertion failed" on !val at cases/logic/logic_type_char_storage_none_attr_volatile_values_31734.c:136
results/random-15841302869033788780/logic/logic_type_char_storage_none_attr_volatile_values_350.out:20:--- FAIL: "Assertion failed" on !val at cases/logic/logic_type_char_storage_none_attr_volatile_values_350.c:136
results/random-15841302869033788780/logic/logic_type_char_storage_none_attr_volatile_values_5.out:20:--- FAIL: "Assertion failed" on !val at cases/logic/logic_type_char_storage_none_attr_volatile_values_5.c:136
results/random-15841302869033788780/logic/logic_type_char_storage_static_attr_volatile_values_31734.out:20:--- FAIL: "Assertion failed" on !val at cases/logic/logic_type_char_storage_static_attr_volatile_values_31734.c:136
results/random-15841302869033788780/logic/logic_type_char_storage_static_attr_volatile_values_350.out:20:--- FAIL: "Assertion failed" on !val at cases/logic/logic_type_char_storage_static_attr_volatile_values_350.c:136
results/random-15841302869033788780/logic/logic_type_char_storage_static_attr_volatile_values_5.out:20:--- FAIL: "Assertion failed" on !val at cases/logic/logic_type_char_storage_static_attr_volatile_values_5.c:136
Failure: gen/random-15841302869033788780/logic/logic_type_char_storage_none_attr_volatile_values_31734
Failure: gen/random-15841302869033788780/logic/logic_type_char_storage_none_attr_volatile_values_350
Failure: gen/random-15841302869033788780/logic/logic_type_char_storage_none_attr_volatile_values_5
Failure: gen/random-15841302869033788780/logic/logic_type_char_storage_static_attr_volatile_values_31734
Failure: gen/random-15841302869033788780/logic/logic_type_char_storage_static_attr_volatile_values_350
Failure: gen/random-15841302869033788780/logic/logic_type_char_storage_static_attr_volatile_values_5
logic                               (f:  6, t: 288, c:   72, b:   32540, T:    149658)
results/random-15841302869033788780/tcc_80_flexarray.out:18:--- FAIL: "Assertion failed" on !main_(MAINARGS) at cases/tcc_80_flexarray.c:16
Failure: tcc/80_flexarray
tcc_80_flexarray                    (f:  1, t:   1, c:    1, b:     876, T:      7250)
Summary for 'random-15841302869033788780': 10 failures, 36232 tests, 6253 test cases, 6222693 bytes, 172756627 ticks
   Failure: bug1738367.c
   Failure: logic_type_char_storage_none_attr_volatile_values_31734
   Failure: logic_type_char_storage_none_attr_volatile_values_350
   Failure: logic_type_char_storage_none_attr_volatile_values_5
   Failure: logic_type_char_storage_static_attr_volatile_values_31734
   Failure: logic_type_char_storage_static_attr_volatile_values_350
   Failure: logic_type_char_storage_static_attr_volatile_values_5
   Failure: tcc/80_flexarray

Creating random-487828595760370920 based on f8 with additional options: --opt-code-speed --nogenconstprop --noloopreverse --max-allocs-per-node 8192 
Running random-487828595760370920 regression tests
results/random-487828595760370920/tst_bug1738367.out:17:--- FAIL: "Assertion failed" on !ternary_inv(0x10) at cases/./../tests/bug1738367.c:59
results/random-487828595760370920/tst_bug1738367.out:18:--- FAIL: "Assertion failed" on !ternary1_inv(0x10) at cases/./../tests/bug1738367.c:65
results/random-487828595760370920/tst_bug1738367.out:19:--- FAIL: "Assertion failed" on !ternary2_inv(0x10) at cases/./../tests/bug1738367.c:71
Failure: bug1738367.c
tst_bug1738367                      (f:  3, t:  13, c:    1, b:    1166, T:     10963)
results/random-487828595760370920/logic/logic_type_char_storage_none_attr_volatile_values_31734.out:20:--- FAIL: "Assertion failed" on !val at cases/logic/logic_type_char_storage_none_attr_volatile_values_31734.c:136
results/random-487828595760370920/logic/logic_type_char_storage_none_attr_volatile_values_350.out:20:--- FAIL: "Assertion failed" on !val at cases/logic/logic_type_char_storage_none_attr_volatile_values_350.c:136
results/random-487828595760370920/logic/logic_type_char_storage_none_attr_volatile_values_5.out:20:--- FAIL: "Assertion failed" on !val at cases/logic/logic_type_char_storage_none_attr_volatile_values_5.c:136
results/random-487828595760370920/logic/logic_type_char_storage_static_attr_volatile_values_31734.out:20:--- FAIL: "Assertion failed" on !val at cases/logic/logic_type_char_storage_static_attr_volatile_values_31734.c:136
results/random-487828595760370920/logic/logic_type_char_storage_static_attr_volatile_values_350.out:20:--- FAIL: "Assertion failed" on !val at cases/logic/logic_type_char_storage_static_attr_volatile_values_350.c:136
results/random-487828595760370920/logic/logic_type_char_storage_static_attr_volatile_values_5.out:20:--- FAIL: "Assertion failed" on !val at cases/logic/logic_type_char_storage_static_attr_volatile_values_5.c:136
Failure: gen/random-487828595760370920/logic/logic_type_char_storage_none_attr_volatile_values_31734
Failure: gen/random-487828595760370920/logic/logic_type_char_storage_none_attr_volatile_values_350
Failure: gen/random-487828595760370920/logic/logic_type_char_storage_none_attr_volatile_values_5
Failure: gen/random-487828595760370920/logic/logic_type_char_storage_static_attr_volatile_values_31734
Failure: gen/random-487828595760370920/logic/logic_type_char_storage_static_attr_volatile_values_350
Failure: gen/random-487828595760370920/logic/logic_type_char_storage_static_attr_volatile_values_5
logic                               (f:  6, t: 288, c:   72, b:   28772, T:    126060)
results/random-487828595760370920/tcc_80_flexarray.out:18:--- FAIL: "Assertion failed" on !main_(MAINARGS) at cases/tcc_80_flexarray.c:16
Failure: tcc/80_flexarray
tcc_80_flexarray                    (f:  1, t:   1, c:    1, b:     801, T:      5901)
Summary for 'random-487828595760370920': 10 failures, 36226 tests, 6253 test cases, 5431515 bytes, 77624080 ticks
   Failure: bug1738367.c
   Failure: logic_type_char_storage_none_attr_volatile_values_31734
   Failure: logic_type_char_storage_none_attr_volatile_values_350
   Failure: logic_type_char_storage_none_attr_volatile_values_5
   Failure: logic_type_char_storage_static_attr_volatile_values_31734
   Failure: logic_type_char_storage_static_attr_volatile_values_350
   Failure: logic_type_char_storage_static_attr_volatile_values_5
   Failure: tcc/80_flexarray

[Philipp Klaus Krause]

The underlaying bug was unrelated to f8(l) or --opt-code-speed. It was an issue with --nogenconstprop that could (and probably did) affect other ports, too. Fixed in [r16668].