Compiling FatFs with FF_USE_MKFS defined

The Small Device C Compiler (SDCC), targeting 8-bit architectures

Brought to you by: benshi, drdani, epetrich, jesusc, and 3 others

#2793 Compiling FatFs with FF_USE_MKFS defined

Status: closed-fixed

Owner: Erik Petrich

Labels: None

Category: redundancy elimination

Priority: 7

Updated: 2019-03-21

Created: 2018-08-04

Creator: Philipp Klaus Krause

Private: No

Compiling current FatFs R0.13b with current SDCC 3.7.1 #10498 fails when FF_USE_MKFS is defined.
I tracked the issue down to the funktion f_mkfs. The attached file contains a simplified version of ff.c, which reproduces the bug (but still needs the headers from FatFs).

1 Attachments

ff.c

Related

Support Requests: ~~#116~~

Discussion

Philipp Klaus Krause - 2018-08-04

Attachments has changed:

Diff:

--- old +++ new @@ -1 +0,0 @@ -ff.c (24.2 kB; text/x-csrc)
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Philipp Klaus Krause - 2018-08-04

Attachments has changed:

Diff:

--- old +++ new @@ -0,0 +1 @@ +ff.c (21.8 kB; text/x-csrc)
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Philipp Klaus Krause - 2018-08-04

Attachments has changed:

Diff:

--- old +++ new @@ -1 +0,0 @@ -ff.c (21.8 kB; text/x-csrc)
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Philipp Klaus Krause - 2018-08-04

Attachments has changed:

Diff:

--- old +++ new @@ -0,0 +1 @@ +ff.c (16.4 kB; text/x-csrc)
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Philipp Klaus Krause - 2018-08-04

Category: STM8 --> other
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Philipp Klaus Krause - 2018-08-04

This fails for z80, too (but apaprently not mcs51 or hc08).

Philipp

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Philipp Klaus Krause - 2018-08-05
  
  Actually, for mcs51 with --stack auto, there is no assertion failure at compile time, but wrong code is generated silenty.
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Philipp Klaus Krause - 2018-08-05

Apparently, the iCode at register allocation is already wrong (looking at --dump-ralloc output). It pushes an unsigned long paramter, where the mem_set() expects an unsigned int. So we push 2 more bytes of parameters than we readjust the stack after the call for.

Philipp

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Philipp Klaus Krause - 2018-08-05

Category: other --> redundancy elimination
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Philipp Klaus Krause - 2018-08-05

dumpraw1 is still correct, dumpcse is already wrong, so this is probably a bug in CSE.

Philipp

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Philipp Klaus Krause - 2018-08-05

Priority: 5 --> 6
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Philipp Klaus Krause - 2018-08-05

dumpraw1 is correct, dumpcse is alredy wrong, so this is a bug in CSE.

Philipp

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Philipp Klaus Krause - 2018-08-05

In [r10500], I added a (disabled by #if 0 until the bug is fixed) regression test for this bug.

Philipp

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Philipp Klaus Krause - 2018-08-06

summary: Compiling FatFs with FF_USE_MKFS defined failsfor stm8 --> Compiling FatFs with FF_USE_MKFS defined
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Philipp Klaus Krause - 2018-12-31

Priority: 6 --> 7
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Erik Petrich - 2019-03-21

status: open --> closed-fixed

assigned_to: Erik Petrich
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Erik Petrich - 2019-03-21

Fixed in [r11130]

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.