long long integer constants

The Small Device C Compiler (SDCC), targeting 8-bit architectures

Brought to you by: benshi, drdani, epetrich, jesusc, and 3 others

#1996 long long integer constants

Status: closed-fixed

Owner: Ben Shi

Labels: C-Front End (396)

Category: other

Priority: 8

Updated: 2016-04-10

Created: 2012-03-30

Creator: Philipp Klaus Krause

Private: No

AFAIR, historically, long long constants have been missing feature, i.e. they only worked inside the range of long constants,and there was an out of range warning otherwise.
Recently, it seems that long long constants only work in the range 0 to 127 or so. Other values result in wrong code being generated silently (tyüpically a value that is all-zero except for the lowest byte).

Philipp

Discussion

Philipp Klaus Krause - 2012-04-02

priority: 6 --> 8
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Philipp Klaus Krause - 2012-04-02

While long long is new functionality, something as basic as integer constants really shouldn't fail silently. Thus increasing priority.

Philipp

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Maarten Brock - 2012-04-02

Are you sure no 'pedantic' warning is generated? Remember that regression tests are run with --less-pedantic.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Philipp Klaus Krause - 2012-06-11

I do get a "warning 158: overflow in implicit constant conversion" for really big values, but it seems there are some smaller constants for which the code is (or was) wrong but no there is no warning.

Philipp

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Philipp Klaus Krause - 2012-06-17

In revision #7923 I implemented a warning for long long literals, since this bug seems to take some time to fix.

Philipp

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Philipp Klaus Krause - 2015-04-09

There have been a lot of long long fixes around the end of 2014 / beginning of 2015. The situation with long long literals improved a lot, but there are a few remaining issues.

Philipp

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Ben Shi - 2015-06-17

Bug [#1945] is a (partial?) duplicate, which is about type promotion from ulong to longlong.

Related

Bugs: ~~#1945~~

Last edit: Maarten Brock 2015-06-17

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Ben Shi - 2015-07-22

Category: --> other
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Ben Shi - 2015-08-26

There are still several tests disabled in longlong.c, which need more work to do.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Ben Shi - 2015-11-25

todo,

division, shift

enable more regression test cases

double2ull has precision loss

gbz80, hc08 specific issues
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Ben Shi - 2016-03-04

Can we remove warning #212 after revision 9510?

I added more tests in longlong.c which had cover most longlong operation (+ - * / % & | ~ ^ << >> comparason), and they all passed on stm8 and z80 family.

Though there are remaining longlong issues, they are specific ones but not common defects.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Philipp Klaus Krause - 2016-03-04
  
  IMO, the warning is no longer needed.
  
  Philipp
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Ben Shi - 2016-03-04

Remaining long long issues,

bug #2477
bug #2329
bug #2118

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Ben Shi - 2016-03-28

It seems long long support has gained big improvements after revision #9527.

More long long test cases (in the attached tests.zip) can be enabled.

There are still several failed long long test cases, and I will look into them later.

tests.zip
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Ben Shi - 2016-04-10

Currently all regression test cases have been enabled and passed on stm8 and z80 family (except gbz80).

Though there are remaining issues, they are port specific not common ones.

bug #2329
bug #2118

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Ben Shi - 2016-04-10

status: open --> closed-fixed

assigned_to: Ben Shi
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.