Re: [Scst-devel] Block-io Module

[Vladislav B. <vs...@vl...>]

Ross S. W. Walker wrote:
>>-----Original Message-----
>>From: Vladislav Bolkhovitin [mailto:vs...@vl...] 
>>Sent: Thursday, February 22, 2007 6:00 AM
>>To: Vu Pham
>>Cc: scs...@li...; Johan Kragsterman; Ross 
>>S. W. Walker
>>Subject: Re: [Scst-devel] Block-io Module
>>
>>Vu, BTW, why do you use generic_make_request() instead of submit_bio()
>>as it was in the original code?
>>
>>Vladislav Bolkhovitin wrote:
>>
>>>Vu Pham wrote:
>>>
>>>
>>>>This patch may fix the BLOCKIO data corruption problem
>>>
>>>
>>>Nothing has changed. Can't you reproduce the problem on 
>>
>>your site? It's
>>
>>>easily reproducible even with dd.
> 
> 
> I believe ramfs uses a sector size of 1024 bytes instead of 512, so all
> the shift calculations will be off.
> 
> The code should read the actual sector size of the underlying device
> upon attaching.

Yes, apparently, there should be some logic translating SCST's block
numbers to the actual device's ones (SCST allows any power of 2 block
size). Or SCST's block size should be always set to the actual device's
one and user shouldn't be allowed to change it.

Vlad

> -Ross
> 
> ______________________________________________________________________
> This e-mail, and any attachments thereto, is intended only for use by
> the addressee(s) named herein and may contain legally privileged
> and/or confidential information. If you are not the intended recipient
> of this e-mail, you are hereby notified that any dissemination,
> distribution or copying of this e-mail, and any attachments thereto,
> is strictly prohibited. If you have received this e-mail in error,
> please immediately notify the sender and permanently delete the
> original and any copy or printout thereof.
> 
>