Re: [Scst-devel] Changes to scst_scsi_op_table

[Vladislav B. <vs...@vl...>]

Hi,

OK, I corrected the code. Next time please send a patch instead of
explaining "on fingers" ;).

Maybe do you have an implementation of those commands?

Thanks,
Vlad

Dhiraj Shetty wrote:
> Hi,
> 
> According to me, the definitions of both PERSISTENT RESERVE commands'
> opcode in scst_scsi_op_table need to be changed. The existing definition
> is as follows:
> 
> a.    {0x5E, "                ", "PERSISTENT_RESERV_IN", SCST_DATA_NONE,
> 0, 0, 0, 0}
> b.    {0x5F, "                ", "PERSISTENT_RESERV_OUT",
> SCST_DATA_NONE, 0, 0, 0, 0}
> 
> The value SCST_DATA_NONE in both the above definitions says that there
> is neither any input parameter data nor any response data for both the
> commands. However the definition of PERSISTENT RESERVE IN as per SPC-3
> needs us to return some response data to each of the possible service
> actions. Similarly the definition of PERSISTENT RESERVE OUT as per SPC-3
> requires some input parameter data to be sent with each of the
> associated service actions.
> 
> Hence the definitions of both the above commands need to be changed to
> the following:
> 
> a.    {0x5E, "                ", "PERSISTENT_RESERV_IN", SCST_DATA_READ,
> 0, 0, 0, 0}
> b.    {0x5F, "                ", "PERSISTENT_RESERV_OUT",
> SCST_DATA_WRITE, 0, 0, 0, 0}
> 
> Please verify the same.
> 
> Regards,
> Dhiraj.
> 
> 
> ------------------------------------------------------------------------
> 
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share your
> opinions on IT & business topics through brief surveys - and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Scst-devel mailing list
> Scs...@li...
> https://lists.sourceforge.net/lists/listinfo/scst-devel