Menu
▾
▴
[Scst-devel] make error with ubuntu 20.04 and mofed
|
From: Grant A. <Cr...@Cr...> - 2020-05-05 23:42:48
|
Hello I am having an issue installing scst against ofed in ubuntu 20.04. further down bart proposed a patch for 19.10. perhaps the same patch is appropriate? If so let me know if there is also a mofed bugfix as before please.
Building against MOFED InfiniBand kernel headers.
make[2]: Entering directory '/usr/src/linux-headers-5.4.0-29-generic'
CC [M] /usr/src/scst-trunk/iscsi-scst/kernel/isert-scst/isert.o
CC [M] /usr/src/scst-trunk/iscsi-scst/kernel/isert-scst/isert_login.o
CC [M] /usr/src/scst-trunk/iscsi-scst/kernel/isert-scst/iser_datamover.o
CC [M] /usr/src/scst-trunk/iscsi-scst/kernel/isert-scst/iser_rdma.o
/usr/src/scst-trunk/iscsi-scst/kernel/isert-scst/iser_rdma.c: In function ‘isert_post_recv’:
/usr/src/scst-trunk/iscsi-scst/kernel/isert-scst/iser_rdma.c:87:50: error: passing argument 3 of ‘ib_post_recv’ from incompatible pointer type [-Werror=incompatible-pointer-types]
87 | err = ib_post_recv(isert_conn->qp, first_ib_wr, &bad_wr);
|^~~~~~~
||
|struct ib_recv_wr **
In file included from /usr/src/scst-trunk/iscsi-scst/kernel/isert-scst/../../../scst/include/backport.h:43,
from /usr/src/scst-trunk/iscsi-scst/kernel/isert-scst/../../../scst/include/scst_debug.h:42,
from /usr/src/scst-trunk/iscsi-scst/kernel/isert-scst/isert_dbg.h:29,
from /usr/src/scst-trunk/iscsi-scst/kernel/isert-scst/iser_rdma.c:45:
/usr/src/ofa_kernel/default/include/rdma/ib_verbs.h:4005:37: note: expected ‘const struct ib_recv_wr **’ but argument is of type ‘struct ib_recv_wr **’
4005 | const struct ib_recv_wr **bad_recv_wr)
| ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~
/usr/src/scst-trunk/iscsi-scst/kernel/isert-scst/iser_rdma.c: In function ‘isert_post_send’:
/usr/src/scst-trunk/iscsi-scst/kernel/isert-scst/iser_rdma.c:134:50: error: passing argument 3 of ‘ib_post_send’ from incompatible pointer type [-Werror=incompatible-pointer-types]
134 | err = ib_post_send(isert_conn->qp, first_ib_wr, &bad_wr);
|^~~~~~~
||
|struct ib_send_wr **
In file included from /usr/src/scst-trunk/iscsi-scst/kernel/isert-scst/../../../scst/include/backport.h:43,
from /usr/src/scst-trunk/iscsi-scst/kernel/isert-scst/../../../scst/include/scst_debug.h:42,
from /usr/src/scst-trunk/iscsi-scst/kernel/isert-scst/isert_dbg.h:29,
from /usr/src/scst-trunk/iscsi-scst/kernel/isert-scst/iser_rdma.c:45:
/usr/src/ofa_kernel/default/include/rdma/ib_verbs.h:3988:37: note: expected ‘const struct ib_send_wr **’ but argument is of type ‘struct ib_send_wr **’
3988 | const struct ib_send_wr **bad_send_wr)
| ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~
/usr/src/scst-trunk/iscsi-scst/kernel/isert-scst/iser_rdma.c: In function ‘isert_post_drain_sq’:
/usr/src/scst-trunk/iscsi-scst/kernel/isert-scst/iser_rdma.c:164:33: error: passing argument 3 of ‘ib_post_send’ from incompatible pointer type [-Werror=incompatible-pointer-types]
164 | &drain_wr_sq->send_wr.wr, &bad_wr);
| ^~~~~~~
| |
| struct ib_send_wr **
In file included from /usr/src/scst-trunk/iscsi-scst/kernel/isert-scst/../../../scst/include/backport.h:43,
from /usr/src/scst-trunk/iscsi-scst/kernel/isert-scst/../../../scst/include/scst_debug.h:42,
from /usr/src/scst-trunk/iscsi-scst/kernel/isert-scst/isert_dbg.h:29,
from /usr/src/scst-trunk/iscsi-scst/kernel/isert-scst/iser_rdma.c:45:
/usr/src/ofa_kernel/default/include/rdma/ib_verbs.h:3988:37: note: expected ‘const struct ib_send_wr **’ but argument is of type ‘struct ib_send_wr **’
3988 | const struct ib_send_wr **bad_send_wr)
| ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~
/usr/src/scst-trunk/iscsi-scst/kernel/isert-scst/iser_rdma.c: In function ‘isert_post_drain_rq’:
/usr/src/scst-trunk/iscsi-scst/kernel/isert-scst/iser_rdma.c:189:30: error: passing argument 3 of ‘ib_post_recv’ from incompatible pointer type [-Werror=incompatible-pointer-types]
189 | &drain_wr_rq->recv_wr, &bad_wr);
|^~~~~~~
||
|struct ib_recv_wr **
In file included from /usr/src/scst-trunk/iscsi-scst/kernel/isert-scst/../../../scst/include/backport.h:43,
from /usr/src/scst-trunk/iscsi-scst/kernel/isert-scst/../../../scst/include/scst_debug.h:42,
from /usr/src/scst-trunk/iscsi-scst/kernel/isert-scst/isert_dbg.h:29,
from /usr/src/scst-trunk/iscsi-scst/kernel/isert-scst/iser_rdma.c:45:
/usr/src/ofa_kernel/default/include/rdma/ib_verbs.h:4005:37: note: expected ‘const struct ib_recv_wr **’ but argument is of type ‘struct ib_recv_wr **’
4005 | const struct ib_recv_wr **bad_recv_wr)
| ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~
/usr/src/scst-trunk/iscsi-scst/kernel/isert-scst/iser_rdma.c: In function ‘isert_device_create’:
/usr/src/scst-trunk/iscsi-scst/kernel/isert-scst/iser_rdma.c:1072:8: error: macro "ib_create_cq" passed 6 arguments, but takes just 5
1072 | i); /* completion vector */
| ^
In file included from /usr/src/scst-trunk/iscsi-scst/kernel/isert-scst/../../../scst/include/backport.h:43,
from /usr/src/scst-trunk/iscsi-scst/kernel/isert-scst/../../../scst/include/scst_debug.h:42,
from /usr/src/scst-trunk/iscsi-scst/kernel/isert-scst/isert_dbg.h:29,
from /usr/src/scst-trunk/iscsi-scst/kernel/isert-scst/iser_rdma.c:45:
/usr/src/ofa_kernel/default/include/rdma/ib_verbs.h:4102: note: macro "ib_create_cq" defined here
4102 | #define ib_create_cq(device, cmp_hndlr, evt_hndlr, cq_ctxt, cq_attr) \
|
/usr/src/scst-trunk/iscsi-scst/kernel/isert-scst/iser_rdma.c:1067:8: error: ‘ib_create_cq’ undeclared (first use in this function); did you mean ‘ib_create_wq’?
1067 | cq = ib_create_cq(ib_dev,
| ^~~~~~~~~~~~
| ib_create_wq
/usr/src/scst-trunk/iscsi-scst/kernel/isert-scst/iser_rdma.c:1067:8: note: each undeclared identifier is reported only once for each function it appears in
/usr/src/scst-trunk/iscsi-scst/kernel/isert-scst/iser_rdma.c: In function ‘isert_conn_create’:
/usr/src/scst-trunk/iscsi-scst/kernel/isert-scst/iser_rdma.c:1299:47: error: ‘struct ib_device_attr’ has no member named ‘max_sge’; did you mean ‘max_cqe’?
1299 | isert_conn->max_sge = isert_dev->device_attr.max_sge - 3;
| ^~~~~~~
| max_cqe
/usr/src/scst-trunk/iscsi-scst/kernel/isert-scst/iser_rdma.c: In function ‘isert_portal_create’:
/usr/src/scst-trunk/iscsi-scst/kernel/isert-scst/iser_rdma.c:1813:20: error: macro "rdma_create_id" requires 5 arguments, but only 4 given
1813 | IB_QPT_RC);
|^
In file included from /usr/src/scst-trunk/iscsi-scst/kernel/isert-scst/iser.h:5 ,
from /usr/src/scst-trunk/iscsi-scst/kernel/isert-scst/iser_rdma.c:46:
/usr/src/ofa_kernel/default/include/rdma/rdma_cm.h:162: note: macro "rdma_create_id" defined here
162 | #define rdma_create_id(net, event_handler, context, ps, qp_type) \
|
/usr/src/scst-trunk/iscsi-scst/kernel/isert-scst/iser_rdma.c:1812:10: error: ‘rdma_create_id’ undeclared (first use in this function); did you mean ‘rdma_create_qp’?
1812 | cm_id = rdma_create_id(isert_cm_evt_handler, portal, RDMA_PS_TCP,
|^~~~~~~~~~~~~~
|rdma_create_qp
At top level:
/usr/src/scst-trunk/iscsi-scst/kernel/isert-scst/iser_rdma.c:1701:12: warning: isert_cm_evt_handler’ defined but not used [-Wunused-function]
1701 | static int isert_cm_evt_handler(struct rdma_cm_id *cm_id,
| ^~~~~~~~~~~~~~~~~~~~
/usr/src/scst-trunk/iscsi-scst/kernel/isert-scst/iser_rdma.c:826:13: warning: ‘isert_cq_comp_handler’ defined but not used [-Wunused-function]
826 | static void isert_cq_comp_handler(struct ib_cq *cq, void *context)
| ^~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
make[3]: *** [scripts/Makefile.build:275: /usr/src/scst-trunk/iscsi-scst/kernel/isert-scst/iser_rdma.o] Error 1
make[2]: *** [Makefile:1719: /usr/src/scst-trunk/iscsi-scst/kernel/isert-scst] Error 2
make[2]: Leaving directory '/usr/src/linux-headers-5.4.0-29-generic'
make[1]: *** [Makefile:131: mods] Error 2
make[1]: Leaving directory '/usr/src/scst-trunk/iscsi-scst'
make: *** [Makefile:257: iscsi] Error 2
root@SAN:/usr/src/scst-trunk# ^C
-----Original Message-----
From: Bart Van Assche <bva...@ac...>
Sent: Friday, December 27, 2019 11:33 PM
To: Grant Albitz <GA...@Al...>; scs...@li...
Subject: Re: [Scst-devel] make error with ubuntu 19.10 and ofed 4.7-3.2
Hi Grant,
So you downloaded and installed the MOFED binaries while I was trying to install MOFED from source? Anyway, a fix for building SCST against MOFED has been checked in on the trunk (r8758). Please note that the following MOFED change is required to make SCST build against MOFED (this is a MOFED bug fix):
--- /usr/src/ofa_kernel/5.3.0-24-generic/include/linux/compat-2.6.h.orig 2019-12-27 20:24:46.912960767 -0800
+++ /usr/src/ofa_kernel/5.3.0-24-generic/include/linux/compat-2.6.h 2019-12-27 20:25:05.152496617 -0800
@@ -64,7 +64,7 @@
backport_dependency_symbol(); \
return initfn(); \
} \
- int init_module(void) __copy(initfn) __attribute__((alias("__init_backport")));
+ int __init init_module(void) __copy(initfn)
+__attribute__((alias("__init_backport")));
/*
Bart.
On 2019-12-27 18:56, Grant Albitz wrote:
> Bart,
>
> I ran ./mlnxofedinstall alone as well as later I tried:
> mlnxofedinstall --upstream-libs --dpdk
>
> Both installed successfully but scst failed the the previously provided errors.
>
>
>
> -----Original Message-----
> From: Bart Van Assche <bva...@ac...>
> Sent: Friday, December 27, 2019 9:45 PM
> To: Grant Albitz - Comstar <ga...@co...>;
> scs...@li...
> Subject: Re: [Scst-devel] make error with ubuntu 19.10 and ofed
> 4.7-3.2
>
> On 2019-12-27 06:06, Grant Albitz wrote:
>> Hello, full disclosure I was running the ubuntu inbox ofed with scst
>> on this system but decided to try installing the Mellanox ofed since
>> it was officially supported on 19.10. I do not believe my errors are
>> related to this change and are simply an issue with the changed made
>> in the newest OFED but I could be mistaken. Error below, bit over my
>> head but assume a patch is needed.
>
> Please share the command-line options passed to the MOFED install.pl script. I tried with kernel-mft=y in the config file (-c) but that causes the MOFED build to fail.
|
