Re: [Scst-devel] How to respond to scst_user op_flags not valid

[Rob T. <ro...@rt...>]

Hi Bart,

Is this acceptable? Created against 8421

Rob

diff -u scst_lib.c.orig scst_lib.c
--- scst_lib.c.orig     2019-06-13 13:10:06.145000000 +0200
+++ scst_lib.c  2019-06-13 13:28:26.124393505 +0200
@@ -717,6 +717,11 @@
          .info_op_flags = FLAG_NONE,
          .info_lba_off = 2, .info_lba_len = 2,
          .get_cdb_info = get_cdb_info_lba_2_none},
+       {.ops = 0x0B, .devkey = " O              ",
+        .info_op_name = "SET CAPACITY",
+        .info_data_direction = SCST_DATA_NONE,
+        .info_op_flags = SCST_WRITE_MEDIUM|SCST_STRICTLY_SERIALIZED,
+        .get_cdb_info = get_cdb_info_none},
         {.ops = 0x0B, .devkey = "  O             ",
          .info_op_name = "SLEW AND PRINT",
          .info_data_direction = SCST_DATA_NONE,



On 6/10/2019 11:13 PM, Bart Van Assche wrote:
> On 6/10/19 12:28 AM, Rob Turk wrote:
>> When my user mode software receives SCST_USER_PARSE, it processes the 
>> data as described in the scst_user_spec.pdf manual. One of the fields 
>> is cmd->op_flags which has a SCST_INFO_VALID flag bit, which is 
>> almost always set.
>>
>> When my tape emulator software receives a SCSI Set Capacity command 
>> (SCSI command 0x0b), the SCST_INFO_VALID bit is not set. What are the 
>> proper steps to set up a valid response from this situation?
>
> Hi Rob,
>
> I think that adding support for the Set Capacity command requires to 
> add an entry to the scst_scsi_op_table[] array in scst_lib.c. A patch 
> that adds Set Capacity command support would be welcome.
>
> Thanks,
>
> Bart.
>