Re: [Scst-devel] SCST Source Build 7256 Fails on Ubuntu 17.10 kernel version 4.13.0-16-generic #19-Ubuntu SMP x86_64

[Gilbert S. <gil...@ho...>]

Thanks for your reply!  I just got it working!  Sorry for all the enthusiasm...here's what I did not sure if all steps were necessary.

(1)  Note I am on Ubuntu 17.10 server edition not desktop edition in case that's a factor.
(2)  Ubuntu 17.10 server edition introduced gcc-7 by default in the "build-essential" package which scst-files.tar bundle installs prior to doing the deb package builds.  So I changed my scripting to install all the packages in build-essential package as an explicit list and changed all the gcc-7 g++-7 etc. to gcc-6 etc. i.e.

if [ $UbuntuRelease = '17.10' ]
then
     sudo apt-get install -y perl gawk multipath-tools open-iscsi make checkinstall git subversion
     sudo apt-get install -y cpp cpp-6 dpkg-dev fakeroot g++ g++-6 gcc gcc-6 libalgorithm-diff-perl libalgorithm-diff-xs-perl libalgorithm-merge-perl libasan4 libdpkg-perl libfakeroot libfile-fcntllock-perl libgcc-6-dev libstdc++-6-dev
else
     sudo apt-get install -y perl gawk multipath-tools open-iscsi build-essential checkinstall git subversion
fi

If gcc-7 etc. are already installed they can be setup in alternatives using this guide:

https://askubuntu.com/questions/26498/choose-gcc-and-g-version


After I had done that, these warnings went away:

event.c: In function ‘handle_iscsi_events’:
event.c:607:41: warning: ‘%s’ directive output may be truncated writing up to 1025 bytes into a region of size 512 [-Wformat-truncation=]
     snprintf(res_str, sizeof(res_str), "%s:%d %s\n",
                                         ^~
In file included from /usr/include/stdio.h:862:0,
                 from event.c:22:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:64:10: note: ‘__builtin___snprintf_chk’ output between 9 and 1044 bytes into a destination of size 512
   return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        __bos (__s), __fmt, __va_arg_pack ());
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
event.c:610:41: warning: ‘%s’ directive output may be truncated writing up to 1025 bytes into a region of size 512 [-Wformat-truncation=]
     snprintf(res_str, sizeof(res_str), "%s %s\n",
                                         ^~
In file included from /usr/include/stdio.h:862:0,
                 from event.c:22:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:64:10: note: ‘__builtin___snprintf_chk’ output between 7 and 1032 bytes into a destination of size 512
   return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        __bos (__s), __fmt, __va_arg_pack ());
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

(3)  After verifying that gcc-6 and g++-6 were indeed in use:


ubuntu@ul1710a-server:~/Downloads/orabuntu-lxc-master/orabuntu/archives/scst-files/scst-3.4.0$ gcc --version
gcc (Ubuntu 6.4.0-8ubuntu1) 6.4.0 20171010
Copyright (C) 2017 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.


ubuntu@ul1710a-server:~/Downloads/orabuntu-lxc-master/orabuntu/archives/scst-files/scst-3.4.0$ g++ --version
g++ (Ubuntu 6.4.0-8ubuntu1) 6.4.0 20171010
Copyright (C) 2017 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

ubuntu@ul1710a-server:~/Downloads/orabuntu-lxc-master/orabuntu/archives/scst-files/scst-3.4.0$

(4) I then did the following edit to the SCST source code:

ubuntu@ul1710a-server:~/Downloads/orabuntu-lxc-master/orabuntu/archives/scst-files/scst-3.4.0$ grep -A2 -B2 WRITE_VERIFY_16 scst/include/scst_const.h
#endif
#if LINUX_VERSION_CODE < KERNEL_VERSION(4, 14, 0)  <-- in build 7256 changed "12 to "14"
#define WRITE_VERIFY_16             0x8E
#endif
#define VERIFY_6                    0x13

(5) re-ran sudo fakeroot debian/rules binary

got clean build  no errors or warnings!



________________________________
From: Bart Van Assche <bva...@ac...>
Sent: Saturday, November 11, 2017 10:38:14 AM
To: Gilbert Standen; scs...@li...
Subject: Re: [Scst-devel] SCST Source Build 7256 Fails on Ubuntu 17.10 kernel version 4.13.0-16-generic #19-Ubuntu SMP x86_64

On 11/11/17 08:30, Gilbert Standen wrote:
> Just another update - I don't think this has anything to do with the
> kernel version on 17.10 nor does it have to do with the SCST  code
> either imho.  I'm think there is something the build needs that is not
> present on Ubuntu 17.10 - don't know if that sounds dumb or not but it
> seems like might be something like that.  Anyway trying to get a handle
> on what the issue is still.
>
> I'm not sure what the problem is yet but I've tested alot of kernels
> SCST should be building with and it's not working with any of them on
> Ubuntu 17.10.

That's weird. Trunk r7256 builds fine on my setup on Ubuntu 17.10. Have
you already tried to build the trunk without any of the Orabuntu patches?

Bart.