From: Duane G. <dua...@ql...> - 2016-02-08 17:46:33
|
Hi Eli, We’ll take a look at your patch and discuss your suggestion. Thanks, Duane From: Eli Shagam <eli...@gm...<mailto:eli...@gm...>> Date: Sunday, February 7, 2016 at 3:22 PM To: Duane Grigsby <dua...@ql...<mailto:dua...@ql...>>, Quinn Tran <qui...@ql...<mailto:qui...@ql...>>, Bart Van Assche <bar...@sa...<mailto:bar...@sa...>> Cc: scst <scs...@li...<mailto:scs...@li...>> Subject: Re: [Scst-devel] Fwd: git://git.qlogic.com/scst-qla2xxx.git. fails for linux kernel 4.1.12 and 4.2.5 Hi, Is there a target date to fix scst-qla2xxxfor kernel 4 ? keeping two almost duplicate separate repositories linux/drivers/scsi/qla2xxxx and scst-qla2xxx/drivers/scsi/qla2xxxx Is very difficult, and becomes more and more difficult. Keeping scst-qla2xxx for 6 years, compile-able and runnable is a big achievement. Most the differences are: * Renames * scst-qla2xxx need to support many versions. * Reorganize The only way to handle such project is to keep a diff file, and apply it to each version, of Linux kernel. This patch (diff) would be much smaller, and easier to maintain. Just for testing purpose I commented all lines that fail to compile. (See the attached diff) Luckily the main path runs. Is there anyone familiar enough with this driver to create this diff file? On Tue, Nov 3, 2015 at 4:54 PM, Duane Grigsby <dua...@ql...<mailto:dua...@ql...>> wrote: Hi Shagam, We will have to look into its failing to compile on 4.2. Thanks, Duane Sent from my handheld device, so please excuse my typos. On Nov 2, 2015, at 11:22 PM, Eli Shagam <eli...@gm...<mailto:eli...@gm...>> wrote: Hi, I use Qlogic qla driver for a while, and it works fin for kernel 3.18.10 and below For kernel 4.0 4.1.12 and 4.2.5 it fails, because some data structure has changed in qla_os. cd ~/Downloads; git clone git://git.qlogic.com/scst-qla2xxx.git<http://git.qlogic.com/scst-qla2xxx.git>. cd ~/Downloads/scst-qla2xxx; sudo make install cd ~/Downloads/scst-qla2xxx; find . -name "*.ko" ./drivers/scsi/qla2xxx/qla2x00_scst.ko ./drivers/scsi/qla2xxx/qla2x00-target/qla2x00tgt.ko See the attached err file. for kernel 3.18 there was no need for symbolic link, which also fails for kernel 4.0 Does Qlogic still maintain this driver? I noticed major management changes in Qlogic. When I use the old driver which requires symbolic link into the kernel tree ~/Downloads/linux-4.2.5/drivers/scsi$ ln -s ~/scst/qla2x00t ./qla2xxx errors for qla_os.c file CC [M] drivers/scsi/qla2xxx/qla_os.o /home/eli/Downloads/linux-4.2.5/drivers/scsi/qla2xxx/qla_os.c: In function ‘qla2x00_relogin’: /home/eli/Downloads/linux-4.2.5/drivers/scsi/qla2xxx/qla_os.c:3924:2: error: implicit declaration of function ‘qla_ini_mode_enabled’ [-Werror=implicit-function-declaration] if (!qla_ini_mode_enabled(vha)) ^ cc1: some warnings being treated as errors make[4]: *** [drivers/scsi/qla2xxx/qla_os.o] Error 1 make[3]: *** [drivers/scsi/qla2xxx] Error 2 make[2]: *** [drivers/scsi] Error 2 make[1]: *** [drivers] Error 2 make[1]: Leaving directory `/home/eli/Downloads/build-4.2.5' make: *** [sub-make] Error 2 Thanks for any help, or hint Eli Shagam Techophil Ltd. <err> ------------------------------------------------------------------------------ _______________________________________________ Scst-devel mailing list https://lists.sourceforge.net/lists/listinfo/scst-devel ________________________________ This message and any attached documents contain information from the sending company or its parent company(s), subsidiaries, divisions or branch offices that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message. ________________________________ This message and any attached documents contain information from the sending company or its parent company(s), subsidiaries, divisions or branch offices that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message. |