Re: [Scst-devel] SCST.pm profiling and optimalization

[Marcin H. <mar...@op...>]

> On 31 March 2013 at 09:37 Bart Van Assche <bva...@ac...> wrote:
>
>
> On 03/28/13 16:54, Marcin Haba wrote:
> > I tried to profiling and optimalizing scstadmin by changes SCST.pm
> > module (for sysfs). After profiling I noticed a few subroutines which
> > are used lots of time during one scstadmin command. After optimalization
> > time for one scstadmin command I noticed decrese usage SCST.pm module
> > for about ~40% to ~50%, and subroutines calls decrese notably too.
>
> Nice work ! However, it would be appreciated if you could test the patch
> attached to this e-mail. It realizes almost the same execution time
> reduction but with fewer source code changes.
>
> Bart.

Hi,

Thank you for the patch. It looks very well for me and in fact it is shorter
from mine. I will be analyze it gladly. I will be able to perform tests in this
tuesday and then I will send results to this mailing list.

Best regards
Marcin Haba