Re: [Scst-devel] [PATCH] Unify the three SCST init scripts

[Vladislav B. <vs...@vl...>]

Bart Van Assche, on 06/10/2011 02:44 PM wrote:
> On Fri, Jun 10, 2011 at 4:41 AM, Vladislav Bolkhovitin <vs...@vl...> wrote:
> 
>>  It looks very good and definitely the right thing to do. Committed,
>> thanks!
>>
>> Should you now update the related parts of READMEs and HOWTOs?
>>
> 
> Here is a patch for the iSCSI howto - I hope I haven't missed to update
> anything:

Unfortunately, it's corrupted and because of it hardly reviewable. Can you repost
it as an attachment (or configure your e-mail client to not corrupt patches, if
you prefer sending them inline)?

Thanks,
Vlad

> Index: iscsi-scst/doc/iscsi-scst-howto.txt
> ===================================================================
> --- iscsi-scst/doc/iscsi-scst-howto.txt    (revision 3567)
> +++ iscsi-scst/doc/iscsi-scst-howto.txt    (working copy)
> @@ -16,12 +16,12 @@
>  While iSCSI-SCST works fine with an unpatched Linux kernel with the same
>  or better speed as other open source iSCSI targets, including IET, if
>  you want even better performance you have to patch and rebuild the
> -kernel. Select the patch according to your kernel version (2.6.18.1 in
> +kernel. Select the patch according to your kernel version (2.6.38.x in
>  the example below):
> 
> -  cd /usr/src/kernels/linux-2.6.18.1
> -  patch -p1 <
> $HOME/scst/iscsi-scst/kernel/patches/put_page_callback-2.6.18.1.patch
> -  patch -p1 < $HOME/scst/scst/kernel/scst_exec_req_fifo-2.6.18.patch
> +  cd /usr/src/kernels/linux-2.6.38.8
> +  patch -p1 <
> $HOME/scst/iscsi-scst/kernel/patches/put_page_callback-2.6.38.patch
> +  patch -p1 < $HOME/scst/scst/kernel/scst_exec_req_fifo-2.6.38.patch
>    make clean
> 
>  Next, build and install the kernel:
> @@ -29,21 +29,25 @@
>    make && make modules
>    make modules_install && make install
> 
> -For some Linux distributions (a.o. Ubuntu and openSUSE) the above steps do
> not
> -rebuild the initial RAM disk. Make sure you regenerate the RAM disk before
> -rebooting. Please look up the documentation of the update-initrd,
> -update-initramfs or the mkinitrd command supplied with your distribution.
> +For some Linux distributions (e.g. Ubuntu) the above steps do not rebuild
> the
> +initial RAM disk. Make sure you regenerate the RAM disk before rebooting.
> +Please look up the documentation of the update-initrd, update-initramfs or
> the
> +mkinitrd command supplied with your distribution.