Re: [Scst-devel] About the [key] line in SCST sysfs attributes

[Mark B. <mar...@gm...>]

On Mon, Dec 27, 2010 at 3:19 PM, Bart Van Assche <bva...@ac...> wrote:

> On Sun, Dec 26, 2010 at 4:46 AM, Mark Buechler <mar...@gm...>
> wrote:
> > [ ... ]
> > Scstadmin already saves all read/writable attributes if -non_key is used.
> > - Mark.
>
> I had to apply this patch before -nonkey worked properly. Does this make
> sense ?
>
> Bart.
>
> Modified: branches/sysfs-tree-changes/scstadmin/scstadmin.sysfs/scstadmin
> ===================================================================
> --- branches/sysfs-tree-changes/scstadmin/scstadmin.sysfs/scstadmin
>  2010-12-27 12:32:25 UTC (rev 3181)
> +++ branches/sysfs-tree-changes/scstadmin/scstadmin.sysfs/scstadmin
>  2010-12-27 20:17:16 UTC (rev 3182)
> @@ -1085,9 +1085,7 @@
>                       my $attribute_buff_nk;
>                       foreach my $attribute (sort keys %{$attributes}) {
>                               next if
> (defined($$attributes{$attribute}->{'set'}));
> -
> -                               if (!defined($$handler_attrs{$attribute}))
> {
> -                                       if
> (!$$attributes{$attribute}->{'static'}) {
> +                               if
> (defined($$handler_attrs{$attribute}) ||
> !$$attributes{$attribute}->{'static'}) {
>                                               if
> (defined($$attributes{$attribute}->{'keys'})) {
>                                                       foreach my $key
> (keys %{$$attributes{$attribute}->{'keys'}}) {
>                                                               my
> $value = $$attributes{$attribute}->{'keys'}->{$key}->{'value'};
> @@ -1106,7 +1104,6 @@
>                                                                if
> (defined($value));
>                                                       }
>                                               }
> -                                       }
>                               }
>                       }
>

I'm on vacation currently, but I'll take a look and let you know.

- Mark.