Re: [Scst-devel] To export a 3 parameters fc_vport_create for qla2xxx

[Uri Y. <Uri...@ng...>]

Hi Chenq

Don't get me wrong, I think you done the right thing.
From my point of view, I can't make it work on older kernels without your patch.

Thanks
Uri
  

-----Original Message-----
From: Cheng Renquan [mailto:cr...@gm...] 
Sent: Sunday, October 31, 2010 4:34 PM
To: Uri Yanai
Cc: Vladislav Bolkhovitin; scs...@li...; Dorit Halsadi
Subject: Re: [Scst-devel] To export a 3 parameters fc_vport_create for qla2xxx

On Sun, Oct 31, 2010 at 5:31 PM, Uri Yanai <Uri...@ng...> wrote:
> Hi
> Unfortunately in kernels prior to 2.6.28 fc_vport_create() is declared
> static.
> I don't see how can I call it from outside the scsi_transport_fc.c
> without adding a kernel patch, except maybe writing
> To /sys/class/fc_host/hostX/vport_create in the kernel.

But why not just use my this patch, as you said, prior to 2.6.28,
fc_vport_create is static and with 5 arguments, my patch is just a
backport from higher kernels:
1) rename it to fc_vport_setup, still static and with 5 arguments same
semantics exactly, create another fc_vport_create, with 3 arguments
and is just a wrapper of this fc_vport_setup, and make fc_vport_create
exported, further also need to move "struct fc_vport_identifiers" from
c file to header file, to make the struct exported to modules;

Could you point out some problems of this patch, if it has; I just
didn't see it;

http://sourceforge.net/mailarchive/message.php?msg_name=128...@gm...

At least I verified this patch works well for scst-2.0 (code under
scst/trunk/{scst,qla2xxx}) on top of linux-2.6.26;

Thanks a lot,