Re: [Scst-devel] Compilation of SCST on RHEL / CentOS is broken

[Vladislav B. <vs...@vl...>]

Bart Van Assche, on 03/31/2010 01:24 PM wrote:
> On Tue, Mar 30, 2010 at 1:35 PM, Vladislav Bolkhovitin <vs...@vl... 
> <mailto:vs...@vl...>> wrote:
> 
> 
>     Bart Van Assche, on 03/27/2010 03:15 PM wrote:
> 
> 
>         According to "svn blame", compilation of SCST on RHEL / CentOS
>         was broken by r1563. The output I get on CentOS 5.4 is as follows:
> 
>         $ uname -a
>         Linux localhost.localdomain 2.6.18-164.15.1.el5 #1 SMP Wed Mar
>         17 11:30:06 EDT 2010 x86_64 x86_64 x86_64 GNU/Linux
>         $ cd ~/software/scst-centos && make scst
>         cd scst && make all
>         make[1]: Entering directory `/home/bart/software/scst-centos/scst'
>         cd src && make all
>         make[2]: Entering directory
>         `/home/bart/software/scst-centos/scst/src'
>         make -C /lib/modules/2.6.18-164.15.1.el5/build
>         SUBDIRS=/home/bart/software/scst-centos/scst/src BUILD_DEV=m
>         make[3]: Entering directory
>         `/usr/src/kernels/2.6.18-164.15.1.el5-x86_64'
>          CC [M]  /home/bart/software/scst-centos/scst/src/scst_main.o
>         /home/bart/software/scst-centos/scst/src/scst_main.c:46:2:
>         warning: #warning "Patch scst_exec_req_fifo-<kernel-version> was
>         not applied on your kernel and CONFIG_SCST_STRICT_SERIALIZING
>         isn't defined. Pass-through dev handlers will not work."
>         /home/bart/software/scst-centos/scst/src/scst_main.c:46:2:
>         warning: #warning "Patch scst_exec_req_fifo-<kernel-version> was
>         not applied on your kernel and CONFIG_SCST_STRICT_SERIALIZING
>         isn't defined. Pass-through dev handlers will not work."
>          CC [M]  /home/bart/software/scst-centos/scst/src/scst_targ.o
>         /home/bart/software/scst-centos/scst/src/scst_targ.c: In
>         function 'scst_cmd_thread':
>         /home/bart/software/scst-centos/scst/src/scst_targ.c:3763:
>         error: implicit declaration of function 'ioc_task_link'
>         /home/bart/software/scst-centos/scst/src/scst_targ.c:3764:
>         error: too many arguments to function 'get_io_context'
>         /home/bart/software/scst-centos/scst/src/scst_targ.c:3764:
>         warning: assignment makes pointer from integer without a cast
>         /home/bart/software/scst-centos/scst/src/scst_targ.c:3772:
>         warning: assignment makes pointer from integer without a cast
>         make[4]: ***
>         [/home/bart/software/scst-centos/scst/src/scst_targ.o] Error 1
>         make[3]: *** [_module_/home/bart/software/scst-centos/scst/src]
>         Error 2
>         make[3]: Leaving directory
>         `/usr/src/kernels/2.6.18-164.15.1.el5-x86_64'
>         make[2]: *** [all] Error 2
>         make[2]: Leaving directory
>         `/home/bart/software/scst-centos/scst/src'
>         make[1]: *** [all] Error 2
>         make[1]: Leaving directory `/home/bart/software/scst-centos/scst'
>         make: *** [scst] Error 2
> 
>         Compilation exited abnormally with code 2 at Sat Mar 27 13:10:48
> 
> 
>     Should be fixed now, although I don't have a possibility to run it
>     (my compiler refuses to compile this kernel), so it's compile tested
>     only.
> 
>     If would be great if you also try if this code works and doesn't
>     crash. For that it would be sufficient to connect/disconnect/connect
>     from single iSCSI initiator to 2 targets with the same FILEIO and
>     BLOCKIO devices and then rmmod on the target all SCST modules under
>     load.
> 
> 
> Sorry, the resulting code still doesn't compile properly. I'm getting 
> the following compiler errors with the 2.6.23 kernel (the output of the 
> commands below is independent of the running kernel version, so you can 
> run these commands too):
> $ scripts/run-regression-tests 2.6.23.17
> $ grep -i error regr*/compilation-2.6.23.17-output.txt
> drivers/scst/scst_targ.c:3771: error: too few arguments to function 
> 'get_io_context'
> make[1]: *** [drivers/scst/scst_targ.o] Error 1
> drivers/scst/scst_lib.c:2421: error: too few arguments to function 
> 'get_io_context'
> make[1]: *** [drivers/scst/scst_lib.o] Error 1

Should be fixed now.

Thanks,
Vlad