Re: [Scst-devel] [Scst-svn] SF.net SVN: scst:[542] trunk

[Bart V. A. <bar...@gm...>]

On Sat, Oct 25, 2008 at 6:31 PM,  <vl...@us...> wrote:
> Revision: 542
...
> Modified: trunk/iscsi-scst/kernel/Makefile
> ===================================================================
> --- trunk/iscsi-scst/kernel/Makefile    2008-10-25 17:14:08 UTC (rev 541)
> +++ trunk/iscsi-scst/kernel/Makefile    2008-10-25 17:31:10 UTC (rev 542)
> @@ -21,11 +21,11 @@
>  # Note 2! The CFLAGS definitions are now in the main makefile.
>
>  EXTRA_CFLAGS += -I$(src)/../include -I$(SCST_INC_DIR)
> -# -Wextra -Wno-unused-parameter
> +EXTRA_CFLAGS += -Wextra -Wno-unused-parameter -Wno-missing-field-initializers
>
>  EXTRA_CFLAGS += -DCONFIG_SCST_EXTRACHECKS
>  #EXTRA_CFLAGS += -DCONFIG_SCST_TRACING
> -EXTRA_CFLAGS += -DCONFIG_SCST_DEBUG -g -W -Wno-unused-parameter
> +EXTRA_CFLAGS += -DCONFIG_SCST_DEBUG -g -W
>
>  #EXTRA_CFLAGS += -DCONFIG_SCST_ISCSI_DEBUG_DIGEST_FAILURES

The above patch does not what it should do, namely disabling the
warnings on unused parameters and missing field initializers. The
reason is that the iscsi-scst Makefile passes the following flags to
the compiler:
... -Wextra -Wno-unused-parameter -Wno-missing-field-initializers ... -W ...
The last -W cancels the effect of the earlier -Wno-...

Bart.