From: Vladislav B. <vs...@vl...> - 2008-07-29 09:32:47
|
Christoph Hellwig wrote: > On Mon, Jul 28, 2008 at 12:56:16PM -0500, James Bottomley wrote: >> On Mon, 2008-07-28 at 21:33 +0400, Vladislav Bolkhovitin wrote: >>> This patch fixes race on dpc_thread field of struct scsi_qla_host, >>> which can lead to crash on the module unload. >>> >>> This patch is against 2.6.26 >> I'm afraid adding a lock is almost certainly the wrong way to handle >> this type of failure. What should be done is to make sure the qla is >> correctly shut down (i.e. no tasks requiring the dpc_thread can be >> performed) *before* killing the thread ... it sounds like shutdown is >> slightly broken in the current driver ... could you post the oops >> details and we can try to work out what the problem is > > I'm not even sure it's the current driver as he mentions that he using > some out of tree target driver which might be the problem. > > Can you reproduce it with a stock 2.6.27-rc tree? The race is still in 2.6.27-rc1. Vlad |