Re: [Sax-devel] severities (was SAX exception IDs)
Brought to you by:
dmegginson
From: David B. <da...@pa...> - 2002-05-09 18:16:04
|
Given the choice between unique integers or objects, and the strings that are already in use, I prefer not to add a new model (stick with strings). It might make sense to use string constants though, so folk can do if (e.getSeverity () == e.warning) ... rather than if (e.getSeverity () == "warning") ... if they're concerned that they'll have typos, and don't want to actually test things. - Dave ----- Original Message ----- From: "Elliotte Rusty Harold" <el...@me...> To: <sax...@li...> Sent: Thursday, May 09, 2002 5:55 AM Subject: RE: [Sax-devel] SAX exception IDs > At 11:56 AM -0700 5/8/02, Yuval Oren wrote: > >I like the severity idea but think it would be better to use integer > >constants instead of strings: WARNING, ERROR, and FATAL_ERROR. That would be > >more consistent with the JDK (e.g. java.util.logging package) and would also > >prevent spelling mistakes. > > > > How about a type-safe enum instead of either one; e.g. > > public class Error { > > private Error() {}; > > public static final Error FATAL_ERROR = new Error(); > etc... > -- > > +-----------------------+------------------------+-------------------+ > | Elliotte Rusty Harold | el...@me... | Writer/Programmer | > +-----------------------+------------------------+-------------------+ |