#63 Remove warnings

[Philip Leishman]

Hi,

compiling rosegarden on gcc 9.1 (newest release) gives lots of warnings. I like my code warning free - you too ?

here is a patch to remove all warnings (no functional change)

Most of the changes are for catching exceptions by value - change to catch by reference
Some copy constructors explicitely defined
suppress warnings where the code does what it should !

[Ted Felix]

Thanks for the patch. I will apply as I have time.

[Ted Felix]

The attached patch contains the changes from this patch that weren't introduced by [patches:#64] and [patches:#65]. Need to review and apply.

[Philip Leishman]

The patch seems to be a patch for an old revision.
Here is a patch removing the remaining warnings for revision 15592

[Ted Felix]

The XmlExporter warning should be fixed in [r15599]. I went with switching to memcpy() which I believe is the original intent of the code. I assume this gets rid of the warning. Please test.

Thanks for the new patch file, I will switch to using it to evaluate the remaining work that needs to be done.

[Philip Leishman]

Almost there !!
Yes the XmlExporter is now warning free. I just have two warnings in 15599 using gcc 9.1. Here is a patch for them

[Ted Felix]

OK, all should be fixed now in [r15600], [r15601] and [r15603]. Please test.

[Philip Leishman]

All good with gcc 9.1 :-)