Philip Leishman

The "heap-use-after-free" worried me - it was a thread race condition. I always feel nervous about multi-threading But without the document in TransportControl - maybe OK !

So - I decided I don't need document or composition in TransportControl. That should take care of the "heap after free" error Also fixed a bug with autostop without stopping jack. I added comments about which threads call which routines. Probably need some sort of mutex locking ! See latest version.

TransportControl fix auto stop

I managed to reproduce the error by adding a short sleep between the delete of currentDocument and the setting of currentDocument to nullptr in RosegardenMainWindow. So this is a thread race situation. This may be a weakness of TransportControl at the moment - no mutex locking although various threads are involved. I suspect I should not be using RosegardenDocument::currentDocument in the sequencer or ajck threads. I only need it for the stop at end functionality. Maybe I can find an alternative...

Hmm.. I don't see this. Does this always occur or just occasionally ? I thought I was safe with the line if (! doc) return 0; Must I do anything apart from just starting and stopping Rosegarden to get this error ?

TransportControl - Allow for jack not running

Of course not having jack running is an important use case - I spent years running Rosegarden without jack as a pure midi sequencer. I am using pipewire so for me jack was always running. However I found a way of emulating jack not running. Hopefully it will work now with the newest version.

The logic is: If the segement contains notes - default to select tool If the segment contains no notes - default to draw tool As the segment in note-down-crash.rg contains no notes it is correct that the draw tool is active.